From 5d8a0e99078ef027ed3fe72dae8eb41a0e3993a7 Mon Sep 17 00:00:00 2001 From: Junwei Zhao Date: Sat, 5 Sep 2020 16:33:04 +1000 Subject: [PATCH] Update secrets for ui --- manifest.yaml | 10 ++++++++-- www/nuxt.config.js | 4 ++-- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/manifest.yaml b/manifest.yaml index 8fafd72..36db80b 100644 --- a/manifest.yaml +++ b/manifest.yaml @@ -94,6 +94,14 @@ spec: env: - name: BASE_URL value: "https://badges.toozhao.com" + - name: GITHUB_CLIENT_ID + valueFrom: + { secretKeyRef: { name: github-credentials, key: clientId } } + - name: GITHUB_CLIENT_SECRET + valueFrom: + { + secretKeyRef: { name: github-credentials, key: clientSecret }, + } ports: - containerPort: 80 name: ui-port @@ -108,7 +116,6 @@ spec: imagePullSecrets: - name: regcred --- - apiVersion: v1 kind: Service metadata: @@ -200,7 +207,6 @@ spec: serviceName: badger servicePort: 80 - --- apiVersion: monitoring.coreos.com/v1 kind: ServiceMonitor diff --git a/www/nuxt.config.js b/www/nuxt.config.js index a45ba95..f1ad3df 100644 --- a/www/nuxt.config.js +++ b/www/nuxt.config.js @@ -112,8 +112,8 @@ export default { }, strategies: { github: { - clientId: "e5f10ed97cf95f71c5b7", - clientSecret: "8543545533ca899c8d9b40b89c3685202c8eb683" + clientId: process.env.GITHUB_CLIENT_ID, + clientSecret: process.env.GITHUB_CLIENT_SECRET }, local: { token: {