From 592bfc7edca6ff044ad73a486dd84540e45161cb Mon Sep 17 00:00:00 2001 From: James Munnelly Date: Mon, 18 Jun 2018 01:55:45 +0100 Subject: [PATCH] issuers: Skip triggering API update if status has not changed --- pkg/controller/clusterissuers/sync.go | 5 +++++ pkg/controller/issuers/sync.go | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/pkg/controller/clusterissuers/sync.go b/pkg/controller/clusterissuers/sync.go index 3b5769d5e..ec8acf530 100644 --- a/pkg/controller/clusterissuers/sync.go +++ b/pkg/controller/clusterissuers/sync.go @@ -2,6 +2,7 @@ package clusterissuers import ( "context" + "reflect" "github.com/golang/glog" "k8s.io/api/core/v1" @@ -26,6 +27,10 @@ func (c *Controller) Sync(ctx context.Context, iss *v1alpha1.ClusterIssuer) (err err = i.Setup(ctx) defer func() { + // TODO: replace this with more efficient comparison? + if reflect.DeepEqual(issuerCopy.Status, iss.Status) { + return + } if saveErr := c.updateIssuerStatus(issuerCopy); saveErr != nil { errs := []error{saveErr} if err != nil { diff --git a/pkg/controller/issuers/sync.go b/pkg/controller/issuers/sync.go index 5a865b5b5..f2d977481 100644 --- a/pkg/controller/issuers/sync.go +++ b/pkg/controller/issuers/sync.go @@ -2,6 +2,7 @@ package issuers import ( "context" + "reflect" "github.com/golang/glog" "k8s.io/api/core/v1" @@ -26,6 +27,10 @@ func (c *Controller) Sync(ctx context.Context, iss *v1alpha1.Issuer) (err error) err = i.Setup(ctx) defer func() { + // TODO: replace this with more efficient comparison? + if reflect.DeepEqual(issuerCopy.Status, iss.Status) { + return + } if saveErr := c.updateIssuerStatus(issuerCopy); saveErr != nil { errs := []error{saveErr} if err != nil {