From 779cdc7276d856aaf82467bf7ab8f295cc965bb5 Mon Sep 17 00:00:00 2001 From: Michael Tsang Date: Mon, 20 May 2019 13:03:22 +0100 Subject: [PATCH] Ensure managed zone picked for CloudDNS is public Signed-off-by: Michael Tsang --- pkg/issuer/acme/dns/clouddns/clouddns.go | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/pkg/issuer/acme/dns/clouddns/clouddns.go b/pkg/issuer/acme/dns/clouddns/clouddns.go index 4465e9733..2c28b83d1 100644 --- a/pkg/issuer/acme/dns/clouddns/clouddns.go +++ b/pkg/issuer/acme/dns/clouddns/clouddns.go @@ -217,7 +217,13 @@ func (c *DNSProvider) getHostedZone(domain string) (string, error) { return "", fmt.Errorf("No matching GoogleCloud domain found for domain %s", authZone) } - return zones.ManagedZones[0].Name, nil + for _, zone := range zones.ManagedZones { + if zone.Visibility == "public" { + return zone.Name, nil + } + } + + return "", fmt.Errorf("No matching public GoogleCloud managed-zone found for domain %s", authZone) } func (c *DNSProvider) findTxtRecords(zone, fqdn string) ([]*dns.ResourceRecordSet, error) {