From 9d0559cfdaecb464a8bad0a41eb5d9df808eefef Mon Sep 17 00:00:00 2001 From: Richard Wall Date: Thu, 27 Aug 2020 09:10:57 +0100 Subject: [PATCH] Compare email addresses in RequestMatchesSpec Signed-off-by: Richard Wall --- pkg/controller/certificates/util.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pkg/controller/certificates/util.go b/pkg/controller/certificates/util.go index ec34fd60f..582cc7c12 100644 --- a/pkg/controller/certificates/util.go +++ b/pkg/controller/certificates/util.go @@ -119,7 +119,9 @@ func RequestMatchesSpec(req *cmapi.CertificateRequest, spec cmapi.CertificateSpe if !util.EqualUnsorted(pki.URLsToString(x509req.URIs), spec.URIs) { violations = append(violations, "spec.uris") } - // TODO: Check EmailAddresses here too + if !util.EqualUnsorted(x509req.EmailAddresses, spec.EmailAddresses) { + violations = append(violations, "spec.emailAddresses") + } if x509req.Subject.SerialNumber != spec.Subject.SerialNumber { violations = append(violations, "spec.subject.serialNumber") }