From aae91fbb5d2295f456f736d944361dff65d197b7 Mon Sep 17 00:00:00 2001 From: Nicolas Degory Date: Sun, 29 Aug 2021 09:20:37 -0700 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Richard Wall Signed-off-by: Nicolas Degory --- .../charts/cert-manager/templates/startupapicheck-psp.yaml | 1 + hack/verify-chart-version.sh | 7 +------ 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/deploy/charts/cert-manager/templates/startupapicheck-psp.yaml b/deploy/charts/cert-manager/templates/startupapicheck-psp.yaml index 68ecfe77d..c87e7ec25 100644 --- a/deploy/charts/cert-manager/templates/startupapicheck-psp.yaml +++ b/deploy/charts/cert-manager/templates/startupapicheck-psp.yaml @@ -26,6 +26,7 @@ spec: allowedCapabilities: [] # default set of capabilities are implicitly allowed volumes: - 'projected' + - 'secret' hostNetwork: false hostIPC: false hostPID: false diff --git a/hack/verify-chart-version.sh b/hack/verify-chart-version.sh index 1459145ef..228c13613 100755 --- a/hack/verify-chart-version.sh +++ b/hack/verify-chart-version.sh @@ -18,17 +18,12 @@ set -o errexit set -o nounset set -o pipefail -readonly REPO_ROOT=$(git rev-parse --show-toplevel) - chart_dir="deploy/charts/cert-manager" echo "Linting chart: ${chart_dir}" bazel build //deploy/charts/cert-manager -case $(uname) in - Darwin) tmpdir="$(mktemp -d)";; - *) tmpdir="$(mktemp -d -p "${REPO_ROOT}")";; -esac +tmpdir="$(mktemp -d)" trap "rm -rf ${tmpdir}" EXIT tar -C "${tmpdir}" -xvf bazel-bin/deploy/charts/cert-manager/cert-manager.tgz