From de07651142006ffc63bc388c0cc011e501e4ccb0 Mon Sep 17 00:00:00 2001 From: JoshVanL Date: Mon, 23 Sep 2019 13:00:36 +0100 Subject: [PATCH] Remote updatestatus todos and add minimal version to docs Signed-off-by: JoshVanL --- docs/getting-started/install/kubernetes.rst | 5 +++++ pkg/controller/certificaterequests/sync.go | 3 --- pkg/controller/certificates/util.go | 3 --- pkg/controller/clusterissuers/sync.go | 3 --- pkg/controller/issuers/sync.go | 3 --- 5 files changed, 5 insertions(+), 12 deletions(-) diff --git a/docs/getting-started/install/kubernetes.rst b/docs/getting-started/install/kubernetes.rst index a153c403f..19b700235 100644 --- a/docs/getting-started/install/kubernetes.rst +++ b/docs/getting-started/install/kubernetes.rst @@ -14,6 +14,11 @@ resources which represent certificate authorities. More information on configuring different Issuer types can be found in the :doc:`respective setup guides `. +.. note:: + From cert-manager v0.11.0 onwards, the minimum supported version of + Kubernetes is v1.11.0. Users still running Kubernetes v1.10 or below should + upgrade to a supported version before installing cert-manager. + .. warning:: You should not install multiple instances of cert-manager on a single diff --git a/pkg/controller/certificaterequests/sync.go b/pkg/controller/certificaterequests/sync.go index a2e5b216d..32cfc2380 100644 --- a/pkg/controller/certificaterequests/sync.go +++ b/pkg/controller/certificaterequests/sync.go @@ -157,8 +157,5 @@ func (c *Controller) updateCertificateRequestStatus(ctx context.Context, old, ne } log.V(logf.DebugLevel).Info("updating resource due to change in status", "diff", pretty.Diff(string(oldBytes), string(newBytes))) - // TODO: replace Update call with UpdateStatus. This requires a custom API - // server with the /status subresource enabled and/or subresource support - // for CRDs (https://github.com/kubernetes/kubernetes/issues/38113) return c.cmClient.CertmanagerV1alpha2().CertificateRequests(new.Namespace).UpdateStatus(new) } diff --git a/pkg/controller/certificates/util.go b/pkg/controller/certificates/util.go index 6149ecbf0..f9c3d62d5 100644 --- a/pkg/controller/certificates/util.go +++ b/pkg/controller/certificates/util.go @@ -222,9 +222,6 @@ func updateCertificateStatus(ctx context.Context, m *metrics.Metrics, cmClient c return nil, nil } log.V(logf.DebugLevel).Info("updating resource due to change in status", "diff", pretty.Diff(string(oldBytes), string(newBytes))) - // TODO: replace Update call with UpdateStatus. This requires a custom API - // server with the /status subresource enabled and/or subresource support - // for CRDs (https://github.com/kubernetes/kubernetes/issues/38113) return cmClient.CertmanagerV1alpha2().Certificates(new.Namespace).UpdateStatus(new) } diff --git a/pkg/controller/clusterissuers/sync.go b/pkg/controller/clusterissuers/sync.go index 47658aa2c..088555e37 100644 --- a/pkg/controller/clusterissuers/sync.go +++ b/pkg/controller/clusterissuers/sync.go @@ -89,8 +89,5 @@ func (c *controller) updateIssuerStatus(old, new *v1alpha2.ClusterIssuer) (*v1al if reflect.DeepEqual(old.Status, new.Status) { return nil, nil } - // TODO: replace Update call with UpdateStatus. This requires a custom API - // server with the /status subresource enabled and/or subresource support - // for CRDs (https://github.com/kubernetes/kubernetes/issues/38113) return c.cmClient.CertmanagerV1alpha2().ClusterIssuers().UpdateStatus(new) } diff --git a/pkg/controller/issuers/sync.go b/pkg/controller/issuers/sync.go index 699a16b46..475cf48e1 100644 --- a/pkg/controller/issuers/sync.go +++ b/pkg/controller/issuers/sync.go @@ -89,8 +89,5 @@ func (c *controller) updateIssuerStatus(old, new *v1alpha2.Issuer) (*v1alpha2.Is if reflect.DeepEqual(old.Status, new.Status) { return nil, nil } - // TODO: replace Update call with UpdateStatus. This requires a custom API - // server with the /status subresource enabled and/or subresource support - // for CRDs (https://github.com/kubernetes/kubernetes/issues/38113) return c.cmClient.CertmanagerV1alpha2().Issuers(new.Namespace).UpdateStatus(new) }