home/cert-manager
2
0
Fork 0
mirror of https://github.com/wahyd4/cert-manager.git synced 2026-08-09 05:06:38 +10:00
Code Issues Packages Projects Releases Wiki Activity
6,158 Commits 37 Branches 119 Tags
release-1.6
Commit Graph
2644 Commits
Author SHA1 Message Date
irbekrmandjetstack-bot 5a2b14afd4 Don't process Order CRs that have failed 
Ensure that cert-manager does not attempt to create new ACME Orders for cert-manager Order CRs that are in failed (errored, invalid or expired) state. If the CertificateRequest was created from a Certificate, the issuance will be retried after 1 hour

Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-11-23 17:10:29 +00:00
irbekrm 598ed35e4a Uses go/crypto ListCertAlternates function to fetch alternative certificate chains 
This allows us to use upstream go/crypto again instead of our own fork

Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-10-07 15:21:26 +01:00
Richard Wall 5d91f0a3c4 Fix flaky test by using EqualUnsorted to compare Events 
Supplants https://github.com/jetstack/cert-manager/pull/4297

Signed-off-by: Richard Wall <richard.wall@jetstack.io>
 2021-10-01 12:41:15 +01:00
irbekrm 7e9753c92e Fix CertificateRequest test 
In Go 1.17 x509.CreateCertificate fails if public key doesn't match private key https://golang.org/doc/go1.17

Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-09-30 10:08:40 +01:00
irbekrm cb6a746726 Runs ./hack/update-all.sh 
New format of Go build tags gets added

Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-09-30 10:08:19 +01:00
Richard Wall 41ef0e3f2b A note about testing the handling of errors relating to the ValidatingWebhook 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
 2021-09-29 13:05:53 +01:00
Richard Wall b71eb11fd1 A note about the relevance of conversion webhook unit-tests 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
 2021-09-29 13:02:44 +01:00
Richard Wall 969ca6d91a Use the v1 API rather than v1alpha2 in the API checker 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
 2021-09-29 12:54:42 +01:00
jetstack-botandGitHub 898dc0e254 Merge pull request #4419 from artificial-aidan/master 
Add Certificate RenewBefore prometheus metrics
 2021-09-27 17:51:46 +01:00
jetstack-botandGitHub f4be63c208 Merge pull request #4465 from andrewmwhite/show-invalid-access-token 
Clouldflare: Show API error messages (e.g., invalid access token)
 2021-09-27 15:20:46 +01:00
jetstack-botandGitHub 5a8b970c97 Merge pull request #4456 from JoshVanL/vault-client-health-err-check 
Vault internal client should check health conn err before checking response status
 2021-09-27 13:07:46 +01:00
Jake Sanders e58af020a6 go fmt 
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
 2021-09-21 10:41:28 +01:00
Jake Sanders 745b4edaa3 Additional tests from code review feedback 
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
 2021-09-21 09:55:59 +01:00
Jake Sanders 57e9e57fbf Use IngressClassName field for v1 Ingresses 
As of Kubernetes 1.18, the deprecated annotation should not be used. This coincides with the support for networking v1 Ingresses in the Kubernetes API.
This commit adds logic to the internal conversion code to add the annotation back on v1beta1 Ingresses, used on Kubernetes 1.16 and 1.17

Signed-off-by: Jake Sanders <i@am.so-aweso.me>
 2021-09-21 09:24:15 +01:00
Jake Sanders 8b25cac161 Rename httpDomainCfg function to http01IngressCfg 
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
 2021-09-21 09:24:12 +01:00
Andrew M. White 4e336d28f4 Cloudflare: output meaningful error message on request failure (e.g. for invalid access tokens). 
Signed-off-by: Andrew M. White <andrewmwhite@gmail.com>
 2021-09-16 19:35:27 -07:00
Andrew M. White fe4945de6f Support Cloudflare API token in live tests. 
Previously only API keys were supported.

Signed-off-by: Andrew M. White <andrewmwhite@gmail.com>
 2021-09-16 19:35:27 -07:00
joshvanl f21a947523 Adds comment as to why the GetAuthorization is called instead of 
GetChallenge

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-09-16 14:44:38 +01:00
joshvanl f83f02cc8b Replace GetChallenge call in acmechallenge controller to 
GetAuthorization

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-09-15 16:05:37 +01:00
joshvanl b75a68088c Vault internal client should check health conn err before checking 
response status

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-09-15 15:57:05 +01:00
jetstack-botandGitHub fcf379d6e9 Merge pull request #4428 from mol-george/issue-4189-keystore-upgrade 
Issue 4189 keystore upgrade
 2021-09-13 10:45:56 +01:00
George Moldoveanu b94b678f6d reinstated keystore.go comment 
Signed-off-by: George Moldoveanu <mol.george@gmail.com>
 2021-09-10 13:33:46 +01:00
George Moldoveanu 563aeb1789 fixed keystore.go and keystore_test.go modules imports 
Signed-off-by: George Moldoveanu <mol.george@gmail.com>
 2021-09-10 13:28:45 +01:00
jetstack-botandGitHub 6e1b6bda56 Merge pull request #4429 from JoshVanL/acme-client-middleware-orders 
Adds the ACME client middleware when create an ACME account
 2021-09-03 18:35:22 +01:00
jetstack-botandGitHub 8f0225189e Merge pull request #4332 from tomasfreund/feature/azure-dns-msi-id 
Add option to specify managed identity id when using azure dns
 2021-09-03 17:17:22 +01:00
joshvanl 0c96c54416 Adds the ACME client middleware when create an ACME account 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-09-03 13:47:43 +01:00
George Moldoveanu 0463681244 updates go deps and bazel files 
Signed-off-by: George Moldoveanu <mol.george@gmail.com>
 2021-09-02 23:45:11 +01:00
George Moldoveanu d0151f7175 fixed TestEncodeJKSKeystore tests to work with upgraded keystore-go api (v4) 
Signed-off-by: George Moldoveanu <mol.george@gmail.com>
 2021-09-02 23:33:45 +01:00
George Moldoveanu 155e90d175 upgraded keystore-go to v4 and fixed code to use v4 api 
Signed-off-by: George Moldoveanu <mol.george@gmail.com>
 2021-09-02 23:24:06 +01:00
Aidan Jensen 15d1ba96fe Fix spelling error. Fix tests 
Signed-off-by: Aidan Jensen <aidan@artificial.com>
 2021-09-01 10:47:46 -07:00
Aidan Jensen 3bd35642a7 Use status.renewalTime instead of renewBefore 
Signed-off-by: Aidan Jensen <aidan@artificial.com>
 2021-09-01 10:07:21 -07:00
AidanAidan JensenSteven E. Harris
 		d9dc7eff1b Update pkg/metrics/certificates.go 
Co-authored-by: Steven E. Harris <seh@panix.com>
Signed-off-by: Aidan Jensen <aidan@artificial.com>
 2021-08-31 14:13:30 -07:00
Aidan Jensen 168a4b35a2 Update comment on UpdateCertificate metric from PR 
Signed-off-by: Aidan Jensen <aidan@artificial.com>
 2021-08-31 10:17:30 -07:00
Aidan Jensen c6bc180f58 Add Certificate RenewBefore prometheus metrics 
Signed-off-by: Aidan Jensen <aidan@artificial.com>
 2021-08-30 10:52:21 -07:00
Charlie Haley e06e208f9b fix typo in error message 
Signed-off-by: Charlie Haley <27928201+charlie-haley@users.noreply.github.com>
 2021-08-28 00:15:07 +01:00
jetstack-botandGitHub e5cc0be04b Merge pull request #4399 from irbekrm/fix_renewal_issue 
Fix renewalTime skew issue
 2021-08-23 16:36:50 +01:00
irbekrm ec1bdc4983 Adds a test case for renewal time skew and a comment 
Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-08-23 15:00:57 +01:00
Eng Zer Jun 54e70d2cc4 refactor: move from io/ioutil to io and os package 
The io/ioutil package has been deprecated in Go 1.16. This commit
replaces the existing io/ioutil functions with their new definitions in
io and os packages.

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
 2021-08-23 19:50:42 +08:00
irbekrm 50e90dfe6e Fix renewalTime skew issue 
Ensure the time returned by RenewalTime function is the same time as that which will be read from Certificate's status

Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-08-20 17:57:35 +01:00
jetstack-botandGitHub 38ab6f4bdd Merge pull request #4365 from jonathansp/master 
fix: flaky test when comparing unordered elements
 2021-08-20 13:02:44 +01:00
jetstack-botandGitHub 0ff741c9d2 Merge pull request #4392 from SgtCoDFish/fixversions 
Fix manually specified Certificate and CertificateRequest versions
 2021-08-20 12:16:45 +01:00
Jake Sanders 5df1dd4932 Update Docs on solver type to reflect default service type 
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
 2021-08-19 14:55:50 +01:00
Jake Sanders f1ac6efade Add integration test for ensuring default solver service type is NodePort 
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
 2021-08-19 14:52:23 +01:00
Jake Sanders 326783ca32 Fix regression in solver service builder - default service type should be NodePort rather than empty 
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
 2021-08-19 14:51:21 +01:00
Ashley Davis 68f5ceb3b4 Fix manually specified Certificate and CertificateRequest versions 
Basically all modern X.509 certs are version 3, but confusingly to
specify "version 3" in an encoded cert, the version number is actually
2.

For PKCS#10 CSRs, the only valid version is 1, which again
confusingly has the value "0" when encoded.

This was incorrect in many places, including one place in which the
version number on a CSR was used as a certificate's version number,
when the two are entirely unrelated.

Go ignores these values, so there's no functional changes here; still,
it's better to be accurate.

Go ignoring CSR version and specifying 0:
https://cs.opensource.google/go/go/+/refs/tags/go1.17:src/crypto/x509/x509.go;l=1958

Go ignoring Certificate version and specifying 2:
https://cs.opensource.google/go/go/+/refs/tags/go1.17:src/crypto/x509/x509.go;l=1534

PKCS#10 CSR specification in RFC 2986 section 4.1:
https://datatracker.ietf.org/doc/html/rfc2986#section-4

X.509 Cert specification in RFC 5280 section 4.1.2.1:
https://datatracker.ietf.org/doc/html/rfc5280#section-4.1.2.1

Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
 2021-08-19 14:48:12 +01:00
jetstack-botandGitHub bea6c20e26 Merge pull request #4369 from irbekrm/improve_owner_not_found_errors 
Improve owner not found errors
 2021-08-18 17:23:29 +01:00
Jake Sanders 38ce03e3ec Fix regression in Ingress PathType introduced in v1.5.0 
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
 2021-08-18 15:16:23 +01:00
irbekrm 904d4e3c15 Don't error if owner not found in cache 
Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-08-17 08:31:49 +01:00
Jonathan Prates 1ff50d3dd8 fix: flaky test when comparing unordered elements 
Signed-off-by: jonathansp <jonathansimonprates@gmail.com>
 2021-08-16 15:04:01 +01:00
Tomáš Freund 1a9de78bfd add managed identity config validation success tests 
Signed-off-by: Tomáš Freund <tomas.freund@datamole.cz>
 2021-08-16 13:34:59 +02:00