jetstack-bot and GitHub
8f0225189e
Merge pull request #4332 from tomasfreund/feature/azure-dns-msi-id
...
Add option to specify managed identity id when using azure dns
2021-09-03 17:17:22 +01:00
Eng Zer Jun
54e70d2cc4
refactor: move from io/ioutil to io and os package
...
The io/ioutil package has been deprecated in Go 1.16. This commit
replaces the existing io/ioutil functions with their new definitions in
io and os packages.
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com >
2021-08-23 19:50:42 +08:00
jetstack-bot and GitHub
38ab6f4bdd
Merge pull request #4365 from jonathansp/master
...
fix: flaky test when comparing unordered elements
2021-08-20 13:02:44 +01:00
Jake Sanders
5df1dd4932
Update Docs on solver type to reflect default service type
...
Signed-off-by: Jake Sanders <i@am.so-aweso.me >
2021-08-19 14:55:50 +01:00
Jonathan Prates
1ff50d3dd8
fix: flaky test when comparing unordered elements
...
Signed-off-by: jonathansp <jonathansimonprates@gmail.com >
2021-08-16 15:04:01 +01:00
Tomáš Freund
1a9de78bfd
add managed identity config validation success tests
...
Signed-off-by: Tomáš Freund <tomas.freund@datamole.cz >
2021-08-16 13:34:59 +02:00
Tomáš Freund
283f606625
fix azure dns validation and add tests
...
Signed-off-by: Tomáš Freund <tomas.freund@datamole.cz >
2021-08-13 16:50:33 +02:00
Tomáš Freund
4ce6c33a1d
fix typo
...
Signed-off-by: Tomáš Freund <tomas.freund@datamole.cz >
2021-08-13 16:20:47 +02:00
Tomáš Freund
8e737dd1b7
move azure managed identity config to nested struct, improve validation
...
Signed-off-by: Tomáš Freund <tomas.freund@datamole.cz >
2021-08-13 16:17:08 +02:00
Tomáš Freund
e343ff5015
add validation to the correct place
...
Signed-off-by: Tomáš Freund <tomas.freund@datamole.cz >
2021-08-12 13:26:16 +02:00
jetstack-bot and GitHub
d647e543e3
Merge pull request #4276 from jakexks/gateway-http01
...
Experimental Gateway API support for ACME HTTP-01 Solving
2021-08-03 18:51:49 +01:00
Jake Sanders
2b9fc73dcb
Fix Gateway validation tests
...
Signed-off-by: Jake Sanders <i@am.so-aweso.me >
2021-08-03 15:53:04 +01:00
Jake Sanders
23e1acdd5c
Update Gateway HTTPRoute Label doc string
...
Signed-off-by: Jake Sanders <i@am.so-aweso.me >
2021-08-03 15:26:40 +01:00
Jake Sanders
c2d7a98192
Remove PodTemplate from Gateway Solver, rename to GatewayHTTPRoute
...
Signed-off-by: Jake Sanders <i@am.so-aweso.me >
2021-08-03 14:26:45 +01:00
Jonathan Prates
50bb91a032
feat: update object description explaning the current behaviour
...
Signed-off-by: jonathansp <jonathansimonprates@gmail.com >
2021-08-03 09:26:23 +01:00
Jonathan Prates
aed1d7137e
feat: add validation to block annotations containing cert-manager.io/ prefix
...
Signed-off-by: jonathansp <jonathansimonprates@gmail.com >
2021-08-03 01:19:11 +01:00
Jonathan Prates
12363f91e2
fix: move secretTemplate validations to validation package
...
Signed-off-by: jonathansp <jonathansimonprates@gmail.com >
2021-08-03 01:19:11 +01:00
Jonathan Prates
d8be463426
fix: update autogenerated converison code
...
Signed-off-by: jonathansp <jonathansimonprates@gmail.com >
2021-08-03 01:19:11 +01:00
Jonathan Prates
9f36f8984b
feat: copy SecretTemplate api to v1alpha2 v1alpha3 and v1beta1
...
Signed-off-by: jonathansp <jonathansimonprates@gmail.com >
2021-08-03 01:19:11 +01:00
Jonathan Prates
1f87c098a1
fix: update autogenerated code
...
Signed-off-by: jonathansp <jonathansimonprates@gmail.com >
2021-08-03 01:19:11 +01:00
Jake Sanders
34a844b150
Fix validation test, add RBAC for gateway API
...
Signed-off-by: Jake Sanders <i@am.so-aweso.me >
2021-08-02 14:06:21 +01:00
Jake Sanders
deb9ccc5a9
HTTP01 solver support for the Gateway API
...
Signed-off-by: Jake Sanders <i@am.so-aweso.me >
2021-08-02 14:06:16 +01:00
Jake Sanders
6f6213c5fd
APIs and validation
...
Signed-off-by: Jake Sanders <i@am.so-aweso.me >
2021-08-02 14:06:09 +01:00
jetstack-bot and GitHub
b04e42c437
Merge pull request #4253 from JoshVanL/apiextensions-v1beta1-v1
...
Conversion: Apiextensions v1beta1 -> v1
2021-07-30 15:49:49 +01:00
18235e3624
Improve ParseSingleCertificateChain when no root is present
...
Fixes when the certificate chain does not have a root CA,
in which case the chain should contain all available intermediates
and ca.crt should contain the rootmost certificate.
Co-authored-by: Josh Van Leeuwen <joshua.vanleeuwen@jetstack.io >
Signed-off-by: Wilson Júnior <wilsonpjunior@gmail.com >
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io >
2021-07-28 14:05:19 +01:00
Jake Sanders and Maël Valais
d69a48c1dc
Add comment to exported ConvertedGVKAnnotation constant.
...
Co-authored-by: Maël Valais <mael@vls.dev >
Signed-off-by: Jake Sanders <i@am.so-aweso.me >
2021-07-27 17:01:50 +01:00
Jake Sanders
90f006c907
nit: imports
...
Signed-off-by: Jake Sanders <i@am.so-aweso.me >
2021-07-27 16:58:59 +01:00
Jake Sanders
fc428d763e
Fix e2e tests on Kube 1.16 by removing last references to NetworkingV1
...
Signed-off-by: Jake Sanders <i@am.so-aweso.me >
2021-07-26 22:30:41 +01:00
Jake Sanders
63d7cb551e
./hack/update-all
...
Signed-off-by: Jake Sanders <i@am.so-aweso.me >
2021-07-26 19:15:08 +01:00
Jake Sanders
756917cc24
Ensure functionality works against v1beta1 API server
...
Signed-off-by: Jake Sanders <i@am.so-aweso.me >
2021-07-26 18:30:01 +01:00
Jake Sanders
6fa758b616
Remove unused argument
...
Signed-off-by: Jake Sanders <i@am.so-aweso.me >
2021-07-26 18:29:58 +01:00
Jake Sanders
67c6586161
Addressing code review comments in #4225
...
Signed-off-by: Jake Sanders <i@am.so-aweso.me >
2021-07-26 18:29:54 +01:00
Jake Sanders
496488027e
Ingress Backend should not specify Name and Port
...
Signed-off-by: Jake Sanders <i@am.so-aweso.me >
2021-07-26 18:29:51 +01:00
Jake Sanders
0d93b93fc5
Feature: Support both v1 and v1beta1 ingresses.
...
Kubernetes is removing support for the v1beta1 Ingress type in 1.22: https://kubernetes.io/blog/2021/07/14/upcoming-changes-in-kubernetes-1-22/#api-changes
However, we still wish to support k8s v1.16 until mid 2022 when Openshift 3 becomes out of support.
cert-manager will now use v1 Ingress if available by using the discovery API.
Signed-off-by: Jake Sanders <i@am.so-aweso.me >
2021-07-26 18:29:42 +01:00
joshvanl
f180f0a0e6
Change internal ACME API to use apiextensions v1beta1 -> v1
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-07-26 17:00:08 +01:00
Maël Valais
b62e51dc2c
validation: leftmost align and guard statements instead of 'switch'
...
The switch statement was making it a bit harder to read. I also renamed
variables to make more sense in the context of this function.
Signed-off-by: Maël Valais <mael@vls.dev >
2021-07-06 12:51:01 +02:00
Maël Valais
d6d9aee9c7
linter party: ineffective 'break', commented "do nothing" instead
...
Signed-off-by: Maël Valais <mael@vls.dev >
Signed-off-by: Maël Valais <mael@vls.dev >
2021-07-06 12:51:01 +02:00
ulrich giraud and Maël Valais
b9c9231305
vault issuer: specify that the caBundle must be base64-encoded
...
Signed-off-by: Ulrich GIRAUD <ulrich.giraud@pole-emploi.fr >
Signed-off-by: Maël Valais <mael@vls.dev >
2021-07-02 20:54:03 +02:00
joshvanl
67ba2b15da
Updates comment for internal vault client New func, that errors should
...
be considered for retrying
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com >
2021-06-29 14:34:49 +01:00
jetstack-bot and GitHub
02d90248de
Merge pull request #4079 from annerajb/support-ed25519
...
support-ed25519
2021-06-15 16:17:53 +01:00
Anner J. Bonilla and Ashley Davis
9546a357a5
Add support for certificates with ed25519 private keys
...
Note that using ed25519 on the public internet is not currently
recommended, since it's not widely supported. You'd likely not be able
to use an Ed25519 cert with an ACME issuer today.
Ed25519 certs might be useful for internal PKI, though - an ed25519 CA
issuer, say - or for testing ed25519 certs before they become more
widely available on the public internet. They're not currently
supported by Vault, Venafi or ACME (Letsencrypt) issuers.
Signed-off-by: Anner J. Bonilla <abonilla@hoyosintegrity.com >
Signed-off-by: Anner J. Bonilla <annerjb@gmail.com >
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io >
2021-06-14 11:17:35 +01:00
irbekrm
118cfb6029
Remove the defaulting for renewBefore from fuzzer
...
We now calculate this default at reneal time
Signed-off-by: irbekrm <irbekrm@gmail.com >
2021-06-11 15:35:46 +01:00
irbekrm
e6b748047d
Remove the default renewBefore value
...
Signed-off-by: irbekrm <irbekrm@gmail.com >
2021-06-11 10:03:12 +01:00
jetstack-bot and GitHub
7eb301f74c
Merge pull request #4021 from irbekrm/deprecate_apis
...
Deprecates old APIs
2021-05-21 18:30:32 +01:00
Ashley Davis
333af8fd94
further static check fixes
...
pkg/internal/apis/certmanager/validation/certificate_for_issuer_test.go:34:2 deadcode `defaultTestCrtName` is unused
pkg/issuer/acme/dns/rfc2136/provider_test.go:42:23 errcheck Error return value of `server.Shutdown` is not checked
pkg/issuer/acme/dns/rfc2136/provider_test.go:77:23 errcheck Error return value of `server.Shutdown` is not checked
pkg/issuer/vault/setup.go:37:2 deadcode `messageVaultHealthCheckFailed` is unused
pkg/issuer/venafi/client/request.go:143:5 gosimple S1023: redundant break statement
pkg/logs/logs.go:68:8 errcheck Error return value of `fs.Set` is not checked
the following fixes introduce a panic when the returned error is
non-nil, which could be a breaking change but was deemed to be worth it
pkg/webhook/server/server.go:58:30 errcheck Error return value is not checked
pkg/webhook/server/server.go:59:25 errcheck Error return value is not checked
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io >
2021-05-21 12:04:05 +01:00
irbekrm
6c4d819d1d
Determine requested API version from RequestKind (code review feedback)
...
Signed-off-by: irbekrm <irbekrm@gmail.com >
2021-05-20 15:29:51 +01:00
jetstack-bot and GitHub
e30dae687a
Merge pull request #3860 from jsoref/spelling-commitment
...
Deprecate UsageContentCommittment and improve public comments
2021-05-20 11:09:52 +01:00
jetstack-bot and GitHub
85c943ffc2
Merge pull request #4018 from kmodules/jp
...
Use gomodules.xyz/jsonpatch instead of mattbaird/jsonpatch
2021-05-19 18:57:51 +01:00
Josh Soref
64fb1ebc91
Deprecate UsageContentCommittment
...
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com >
2021-05-19 12:40:10 -04:00
irbekrm
a42771b7e4
Adds a bunch of comments for exported types
...
Signed-off-by: irbekrm <irbekrm@gmail.com >
2021-05-19 10:19:43 +01:00