Commit Graph
781 Commits
Author SHA1 Message Date
Richard Wall 0a2a4b0d7a Revert the introduction of errors.WithStack
* The logging isn't configured to show the stack traces anyway.

Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2020-09-18 12:08:10 +01:00
Richard Wall ea73ab534c Document newIndependentCacheAndDelegatingClient
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2020-09-18 12:02:52 +01:00
Richard Wall 35f10ef439 Explain why we're not using the controller.Builder
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2020-09-18 11:58:30 +01:00
Richard Wall 975e98e285 Log an error if WaitForCacheSync fails
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2020-09-18 11:51:45 +01:00
Richard Wall a5e6f6c262 Stop creating new controllers if one of the errgroup has already erred
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2020-09-18 11:41:11 +01:00
Richard Wall 602043013e Revert the increased number of reconcile threads
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2020-09-18 11:39:52 +01:00
Richard Wall 2bffaf9270 A clearer name for the function which creates each controller
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2020-09-18 11:38:00 +01:00
Richard Wall 7c6374ff07 Explain why we ignore objects with a deletionTimestamp
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2020-09-18 10:28:32 +01:00
Richard Wall e2765f720a Remove debug log
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2020-09-18 10:04:28 +01:00
Richard Wall e27e503624 Ensure that each controller's delegating client refers to the correct cache
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2020-09-18 08:29:07 +01:00
Richard Wall 98fff7dcf8 Clearer logging
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2020-09-17 16:43:15 +01:00
Richard Wall 1bb99dee1a Increase the number of reconciler goroutines
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2020-09-17 16:42:51 +01:00
Richard Wall ebd7ba5e70 Ignore objects that are being deleted
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2020-09-17 16:41:58 +01:00
Richard Wall 3d63a76da9 Make the injector sources read from the same cache as the controller
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2020-09-17 14:41:28 +01:00
Richard Wall b772f3295b Use cancellable contexts and errgroups
...to control the starting and stopping of controllers and caches

Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2020-09-17 09:37:05 +01:00
Richard Wall 3723ea5a52 Update all
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2020-09-11 10:32:07 +01:00
Richard Wall 0f7b23c23b Pass the specific cache to the indexer functions
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2020-09-11 10:21:12 +01:00
Richard Wall 81874895b0 Use NewUnmanaged and separate caches for each controller
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2020-09-11 10:09:27 +01:00
Stevo Slavić 8d983226e2 Remove extra space
Signed-off-by: Stevo Slavić <sslavic@gmail.com>
2020-09-03 15:11:45 +02:00
Maartje Eyskens c73c121ce1 Order imports
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-09-01 15:08:31 +02:00
9d0a1b136e Update pkg/controller/certificaterequests/acme/acme.go
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>

Co-authored-by: Richard Wall <wallrj@users.noreply.github.com>
2020-09-01 15:05:48 +02:00
Maartje Eyskens 6756856e82 Nil out request in spec again for order
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-08-31 10:08:54 +02:00
Maartje Eyskens f1c6c93df5 Fix CR and make a general function
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-08-28 15:06:54 +02:00
Maartje Eyskens 69186afbdd Move logic to utils
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-08-28 09:59:48 +02:00
Maartje Eyskens bb89b50c8f Fix invalid DNS-1123 on ACME computed names
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-08-28 09:54:18 +02:00
Richard Wall 9d0559cfda Compare email addresses in RequestMatchesSpec
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2020-08-27 09:10:57 +01:00
Richard Wall 3107b380f2 Replace some references to URISANs and EmailSANs
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2020-08-26 16:52:08 +01:00
Richard Wall e8185e73f1 Remove duplicate import
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2020-08-26 16:47:47 +01:00
jetstack-botandGitHub 6a2f9538fc Merge pull request #3208 from meyskens/acme-multi-chain
Add support for alternate certs with PrefferedChain in ACME
2020-08-26 12:03:35 +01:00
Maartje Eyskens 824e075bf8 fmt
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-08-24 17:45:52 +02:00
Maartje Eyskens 75e31fe54c Add a unit test for alt chains
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-08-24 17:33:27 +02:00
Lars Lehtonen aab6b479c5 pkg/controller/certificates/internal: fix dropped test errors
Signed-off-by: Lars Lehtonen <lars.lehtonen@gmail.com>
2020-08-21 21:39:29 -07:00
Maartje Eyskens 90d6a54151 Add support for alternate certs with PrefferedChain in ACME
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-08-21 17:56:26 +02:00
Richard Wall 55514f048c Move Venafi Pickup ID annotation key to the external API package
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2020-08-21 10:27:47 +01:00
Richard Wall dbc3d95b92 Fix an import alias that still called v1alpha1
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2020-08-20 17:13:48 +01:00
Richard Wall 821d824cc2 Revert renaming of CSR > Request in comments and in error messages
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2020-08-20 14:28:07 +01:00
Richard Wall 3fb3db27ff Fix ACME challenge type in unit tests
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2020-08-20 14:28:06 +01:00
Maartje EyskensandRichard Wall 5aba6f956b Fix ACME
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-08-20 14:28:06 +01:00
Richard Wall 01b5d0fa88 Fix tests in ./pkg/controller/certificates/...
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2020-08-20 14:28:06 +01:00
Richard Wall 758131ada2 Fix tests in github.com/jetstack/cert-manager/pkg/controller/acmeorders
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2020-08-20 14:28:06 +01:00
Richard Wall 5d936930e6 Revert an accidental change of CSR > Request
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2020-08-20 14:28:06 +01:00
Richard Wall 9cca8a1da4 Update hash based API resource names to account for changed API
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2020-08-20 14:28:06 +01:00
Richard Wall 81eb53f597 ./hack/update-all.sh
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2020-08-20 14:28:06 +01:00
Richard Wall a70298180a Run a script to update v1alpha2 usage to v1
Script is available at https://github.com/jetstack/cert-manager/pull/3201

Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2020-08-20 14:26:51 +01:00
Richard Wall 2b1e1d1d2b Remove deprecated issuer related annotation key constants from the API
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2020-08-14 17:07:36 +01:00
jetstack-botandGitHub d9ad986823 Merge pull request #3173 from wallrj/p12-intermed-cert
Add intermediate cert to P12 chain if ca.crt is empty
2020-08-12 13:18:59 +01:00
Maartje EyskensandRichard Wall d2f86c410a Add intermediate cert to P12 chain if ca.crt is empty
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-08-12 12:39:27 +01:00
Richard Wall 5acb052194 A test for certificate chains
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2020-08-12 12:39:27 +01:00
Maartje Eyskens 3259fdfe9b Implement feedback
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-08-12 10:59:42 +02:00
Maartje Eyskens 33702ed413 Address feedback
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-08-12 10:59:42 +02:00