Commit Graph
1000 Commits
Author SHA1 Message Date
jetstack-botandGitHub 0ff2b8778c Merge pull request #3983 from JoshVanL/parse-certificate-chain-venafi
Parse certificate chain venafi
2021-05-13 14:21:14 +01:00
jetstack-botandGitHub 22ff380f39 Merge pull request #3984 from JoshVanL/parse-certificate-chain-acme
Parse certificate chain acme
2021-05-13 13:50:14 +01:00
jetstack-botandGitHub 96ea5e51d4 Merge pull request #3985 from JoshVanL/parse-certificate-chain-ca
Parse certificate chain CA Issuer
2021-05-13 13:23:14 +01:00
joshvanl 58a25314f7 Changes CR CA controller to use ECDSA keys
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-05-12 15:07:25 +01:00
joshvanl ea2cfdc3c9 Updates CA issuer to updates SignCSRTemplate and propagate CA
certificate down

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-05-12 14:22:59 +01:00
joshvanl e4d3d3f725 Change ParseCertificateChain to ParseSingleCertificateChain
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-05-12 14:17:41 +01:00
joshvanl 33fcf0d082 Uses ParseCertificateChainPEM for ACME Order Response
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-05-12 14:17:02 +01:00
joshvanl d69a4e1a3c Change ParseCertificateChain to ParseSingleCertificateChain
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-05-12 14:15:54 +01:00
joshvanl 1030bbadb5 Change Venafi Signer to use ParseCertificateChain to populate Status.CA
correctly

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-05-12 14:14:47 +01:00
Jake Sanders ef2a830614 ./hack/update-bazel.sh
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
2021-05-11 14:50:28 +01:00
Jake Sanders 79d8d9cb7b Revert "Merge pull request #3724 from inteon/istio-virtualservice-for-http01"
This reverts commit 80f27739b5, reversing
changes made to 96604d02a3.

Signed-off-by: Jake Sanders <i@am.so-aweso.me>
2021-05-11 14:50:25 +01:00
Jake Sanders 423e82b65b Revert "Merge pull request #3939 from JoshVanL/istio-api-to-internal-apis"
This reverts commit f2a74ade5e, reversing
changes made to 7ff54e61e9.

Signed-off-by: Jake Sanders <i@am.so-aweso.me>
2021-05-11 14:50:23 +01:00
jetstack-botandGitHub 3434c78188 Merge pull request #3960 from wallrj/538-lint-fixes-richardw
Fix some linting errors
2021-05-07 11:50:34 +01:00
Richard Wall fc1f6ffea9 ./hack/update-deps.sh
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2021-05-07 09:55:09 +01:00
Richard Wall 3811847872 Fail benchmark if scheduleN returns an error
pkg/controller/acmechallenges/scheduler/scheduler_test.go:84:16                          errcheck     Error return value of `s.scheduleN` is not checked
pkg/controller/acmechallenges/scheduler/scheduler_test.go:98:16                          errcheck     Error return value of `s.scheduleN` is not checked
pkg/controller/acmechallenges/scheduler/scheduler_test.go:112:16                         errcheck     Error return value of `s.scheduleN` is not checked
pkg/controller/acmechallenges/scheduler/scheduler_test.go:314:51                         errcheck     Error return value of `` is not checked

Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2021-05-07 09:55:09 +01:00
Richard Wall c9eb75c447 Remove unused test-case field
pkg/controller/certificaterequests/venafi/venafi_test.go:787:2                           structcheck  `issuer` is unused

Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2021-05-07 09:55:09 +01:00
Richard Wall b35ae551bf Fail test of Register returns an error
pkg/controller/issuers/sync_test.go:55:12                                                errcheck     Error return value of `c.Register` is not checked

Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2021-05-07 09:55:09 +01:00
Jake Sanders eab7c954a2 Use %v to log errors
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
2021-05-05 16:28:46 +01:00
Jake Sanders 196e42c221 Tidy godoc comments
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
2021-05-05 16:21:24 +01:00
Jake Sanders f194d9b732 Add godoc comments
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
2021-05-05 15:59:02 +01:00
Richard Wall f8b4934e7c Use consistent pointer receiver
pkg/controller/controller.go:135:1: receiver name b should be consistent with previous receiver name c for controller

Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2021-05-04 15:03:56 +01:00
Jake Sanders bab9efaa8f staticcheck: package imported more than once
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
2021-05-04 14:58:23 +01:00
Richard Wall 6c544dafa0 Simplify the return statement
pkg/controller/certificates/trigger/trigger_controller_test.go:257:12: if block ends with a return statement, so drop this else and outdent its block

Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2021-05-04 14:57:20 +01:00
Jake Sanders 62aa7aa33e staticcheck: error strings should not be capitalized (ST1005)
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
2021-05-04 14:54:05 +01:00
Richard Wall c15d30742d Remove duplicate import
pkg/controller/certificaterequests/venafi/venafi_test.go:43:2: package "github.com/jetstack/cert-manager/pkg/controller/test" is being imported more than once (ST1019)
pkg/controller/certificaterequests/venafi/venafi_test.go:44:2: other import of "github.com/jetstack/cert-manager/pkg/controller/test"

Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2021-05-04 14:50:37 +01:00
Richard Wall 1b6b66d9b8 Remove unused global variable
pkg/controller/certificates/revisionmanager/revisionmanager_controller.go:51:2: var certificateGvk is unused (U1000)

Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2021-05-04 14:44:43 +01:00
Jake Sanders 04ee9acd46 gosimple: S1019
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
2021-05-04 14:17:06 +01:00
Jake Sanders 77d8021d3b gosimple: S1011
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
2021-05-04 14:16:17 +01:00
Jake Sanders 0625249fc7 errcheck: Error return value of controller.Register is not checked
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
2021-05-04 14:14:48 +01:00
joshvanl c5e2184a4a Moves /pkg/internal/apis/istio to /pkg/internal/istio
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-04-29 12:31:57 +01:00
joshvanl 00ceff3421 Update bazel
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-04-29 11:36:49 +01:00
joshvanl 3af22cf6c6 Move istio util duncs to pkg/util/istio
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-04-29 11:35:41 +01:00
joshvanl b543d103d5 Change optimistic logging to be Info, rather than debug
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-04-28 14:19:15 +01:00
joshvanl 8da0e25ced Don't log on default log level when an error occurs in optimistic
locking

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-04-28 14:16:37 +01:00
Inteon 2d7dfcb462 start DynamicSharedInformerFactory unconditionally; only listen for VirtualServices conditionally
Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com>
2021-04-28 09:20:49 +02:00
Inteon 624e2b9e69 add ACME HTTP01 Istio support
Signed-off-by: Inteon <42113979+inteon@users.noreply.github.com>
2021-04-28 09:19:53 +02:00
jetstack-botandGitHub b95836421f Merge pull request #3878 from JoshVanL/certificate-request-controller-denied-ready-condition
Set the Ready condition to False when a CertificateRequest has been denied for all CertificateRequests that reference a cert-manager.io signer
2021-04-13 17:22:11 +01:00
jetstack-botandGitHub 06b68d35e0 Merge pull request #3835 from RinkiyaKeDad/3620_constants_in_eventf
chore: used constants for string literals when recording new events
2021-04-13 15:14:11 +01:00
RinkiyaKeDad 0b87eeae97 added reason prefix for all
Signed-off-by: RinkiyaKeDad <arshsharma461@gmail.com>
2021-04-13 16:40:56 +05:30
joshvanl e05adbf06b Remove expected events when Ready Denied condition set
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-04-09 18:20:07 +01:00
joshvanl ff3e4bb07d Don't fire an event when the Denied ready condition is set
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-04-09 18:19:44 +01:00
joshvanl 50a84eaf1d Sets the Ready condition to False when a request is Denied
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-04-09 15:34:32 +01:00
joshvanl 1d75fc480e Adds Denied to certificaterequests reporter
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-04-09 15:26:15 +01:00
Maël Valais 88a6fa1315 issuing-controller: explain why we do the Ready + Denied checks
Signed-off-by: Maël Valais <mael@vls.dev>
2021-04-08 15:16:36 +02:00
RinkiyaKeDad bba7c1011d added prefix and made constants public
Signed-off-by: RinkiyaKeDad <arshsharma461@gmail.com>
2021-04-08 12:17:15 +05:30
jetstack-botandGitHub 2dd6b6e224 Merge pull request #3795 from JoshVanL/certificates-issuing-retry-denied-requests
Adds Denied check to CertificateRequests in issuing controller to retry denied requests
2021-04-06 21:34:57 +01:00
jetstack-botandGitHub 10a871dc62 Merge pull request #3444 from maelvls/bug-certificaterequest-not-updated
Bug: certificaterequest not updated after its certificate is updated
2021-04-06 20:17:57 +01:00
jetstack-botandGitHub 6ad91e0700 Merge pull request #3833 from JoshVanL/controller-issuer-context
Pass context through to client calls in controllers and acme issuer
2021-04-06 18:53:57 +01:00
Maël ValaisandJosh Soref 8f5a094b0c trigger-controller: PR comment: failure mode -> failure state
Cf. https://github.com/jetstack/cert-manager/pull/3444#pullrequestreview-629189131

Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
2021-04-06 19:14:49 +02:00
Maël Valais 181d4ee281 DataForCertificate: typo certitificate -> certificate
Signed-off-by: Maël Valais <mael@vls.dev>
2021-04-06 19:06:21 +02:00