Commit Graph
29 Commits
Author SHA1 Message Date
Michael Tsang 7d67ae466e Remove metrics field from controllers
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-05-20 11:06:11 +01:00
Michael Tsang 455f6ebab4 Use ControllerName as label value
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-05-17 16:49:39 +01:00
Michael Tsang f2e57a1c95 Add ControllerSyncCallCount metric
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
2019-05-17 14:22:16 +01:00
James Munnelly bbf4012e12 Handle expired challenge responses in acmechallenges controller
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-04-30 18:57:26 +01:00
jetstack-botandGitHub 570751236d Merge pull request #1585 from munnerz/validate-caa-feature-gate
Add feature gate for ValidateCAA functionality and default it to off
2019-04-30 14:17:48 +01:00
James Munnelly 49f587c844 Set Reason field on ACME challenges during Present/CleanUp
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-04-30 10:25:33 +01:00
James Munnelly 9906c0d946 Add feature gate for ValidateCAA functionality and default it to off
To help avoid issues with the ValidateCAA functionality, this disables
the CAA check by default and adds a new --feature-gates=ValidateCAA=true
option to cert-manager-controller to allow enabling the previous
behaviour in v0.7.0 and v0.7.1.

Once issues with CNAMEd DNS names pointing to internal nameservers
are resolved, this option will be defaulted to on.

Signed-off-by: James Munnelly <james@munnelly.eu>
2019-04-25 15:10:05 +01:00
James Munnelly eaeefdf5b2 Update acmechallenges controller
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-03-12 14:24:51 +00:00
James Munnelly 2f30258f0e Switch to klog
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-02-22 12:34:02 +00:00
Daniel Morsing a01514ad63 use configured nameservers for CAA validation
Signed-off-by: Daniel Morsing <dmo@jetstack.io>
2019-02-11 12:05:18 +00:00
Daniel Morsing bb853e5e79 first draft CAA checking
Signed-off-by: Daniel Morsing <dmo@jetstack.io>
2019-02-05 14:25:10 +00:00
Daniel Morsing b0a9b8276c surface self-check errors in challenge resource
Signed-off-by: Daniel Morsing <dmo@jetstack.io>
2019-01-21 11:49:46 +00:00
Daniel Morsing 88d811b34c change Check function signature
This makes the check function into a simple precondition

Signed-off-by: Daniel Morsing <dmo@jetstack.io>
2019-01-17 16:45:03 +00:00
James Munnelly 21c7b2e13f Increase ACME control loop max back-off. Increase create order back-off to 1h. Fire Event when Order fails.
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-01-10 22:07:48 +00:00
Daniel Morsing cc946c0b45 Populate reason field regardless
If we have an error, then tell people about it.

Signed-off-by: Daniel Morsing <dmo@jetstack.io>
2019-01-10 14:54:43 +00:00
Daniel Morsing 1b921b1583 remove more strict validation
Turns out the ACME server can respond with different codes than the ones listed

Signed-off-by: Daniel Morsing <dmo@jetstack.io>
2019-01-10 14:35:30 +00:00
Daniel Morsing ba240bbe4e Add reason when an order/challenge gets marked invalid
When an ACME server tells us that a challenge or an order is invalid, it's helpful to get some information on why that's the case. Populate the reason field with the error information so that these issues can be more easily debugged.

Signed-off-by: Daniel Morsing <dmo@jetstack.io>
2019-01-10 14:05:15 +00:00
James Munnelly 0fcc0c666c Update copyright header year
Signed-off-by: James Munnelly <james@munnelly.eu>
2019-01-07 15:07:55 +00:00
James Munnelly e3ab52861a Only follow CNAMEs if the Issuer's cnameStrategy is 'Follow'
Signed-off-by: James Munnelly <james@munnelly.eu>
2018-12-04 13:57:13 +00:00
James Munnelly 93a7a89d4e Ensure finalizer is always removed after one sync
Signed-off-by: James Munnelly <james@munnelly.eu>
2018-11-28 23:19:52 +00:00
James Munnelly dd8f98768b CleanUp ACME challenges after issuing and on delete using finalizer
Signed-off-by: James Munnelly <james@munnelly.eu>
2018-11-28 22:05:47 +00:00
James Munnelly 73f65b9490 Retry after a fixed 5s if self check is failing
Signed-off-by: James Munnelly <james@munnelly.eu>
2018-11-21 20:29:02 +00:00
James Munnelly 5cc3240145 Fire Events when challenges succeed or fail
Signed-off-by: James Munnelly <james@munnelly.eu>
2018-11-07 20:38:22 +00:00
James Munnelly 85d433cff9 Add ACME challenge scheduler and process challenges for matching domains/types in serial
Signed-off-by: James Munnelly <james@munnelly.eu>
2018-11-06 12:31:16 +00:00
James Munnelly 6e32738f22 Handle WaitAuthorization failing properly
Signed-off-by: James Munnelly <james@munnelly.eu>
2018-10-15 14:15:21 +01:00
James Munnelly eadbbc85c5 Add missing boilerplate headers
Signed-off-by: James Munnelly <james@munnelly.eu>
2018-10-12 12:40:39 +01:00
James MunnellyandJames Munnelly d323a1df0d Add unit tests for acmeorders and acmechallenges
Signed-off-by: James Munnelly <james@munnelly.eu>
2018-10-12 12:40:39 +01:00
James MunnellyandJames Munnelly 9214615d6e Fix race issues in ACME issue function. Add extended unit tests.
Signed-off-by: James Munnelly <james@munnelly.eu>
2018-10-12 12:40:39 +01:00
James MunnellyandJames Munnelly 967a48e1dc Add ACME Order & Challenge controllers
Signed-off-by: James Munnelly <james@munnelly.eu>
2018-10-12 12:40:38 +01:00