Commit Graph
282 Commits
Author SHA1 Message Date
joshvanl f905f6a2aa Adds ObservedGeneration to issuer condition status
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-03-15 15:04:00 +00:00
jetstack-botandGitHub 70c66e02a0 Merge pull request #3641 from JoshVanL/certificate-request-identity
CertificateRequest UserInfo fields
2021-03-15 14:26:15 +00:00
joshvanl 4dd6d19011 Adds review comment suggestions/cleanup
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-03-11 19:12:02 +00:00
jetstack-botandGitHub c2634d3538 Merge pull request #3613 from JoshVanL/certificate-condition-observed-generation
Certificate condition observed generation
2021-03-08 09:47:45 +00:00
Josh Soref 3b957488c3 spelling: will
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
2021-03-04 13:04:38 -05:00
joshvanl 6b551b2add Updates generated conversion for OverservedGeneration
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-03-04 17:03:26 +00:00
joshvanl efdb73b446 Adds ObservedGeneration int64 field to Certificate Conditions
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-03-04 17:03:26 +00:00
joshvanl 25f2a0579f Make annotations only immutable when they belong to acme.cert-manager.io
and cert-manager.io

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-02-17 10:02:16 +00:00
joshvanl cdeca6a9f4 Updates testdata to use new validation function signature. Updates
registry and scheme install

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-02-08 19:14:35 +00:00
joshvanl 77d382c355 Updates validation functions to use new admission request signature.
Updates installs to include mutation and identity

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-02-08 19:09:58 +00:00
joshvanl d043a6ada6 Updates CertificateRequest validation to make the resource immutable
upon creation. The spec and metadata.annotation fields cannot be
changed after creation

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-02-08 19:08:54 +00:00
joshvanl 66276927f6 Adds internal identity validation and mutation functions, and registers
with registries

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-02-08 19:07:39 +00:00
joshvanl c09f47afed Updates internal validation function registry to include admission
request

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-02-08 19:06:37 +00:00
joshvanl 6e35e96058 Adds internal mutation function registry
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-02-08 19:06:18 +00:00
joshvanl e6bd2e3538 Updates client-gen for CR identity
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-02-05 16:49:55 +00:00
joshvanl 46999ff8f1 Adds identity fields to CertificateRequest types
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2021-02-05 14:23:40 +00:00
jetstack-botandGitHub 35febb1717 Merge pull request #3505 from hugoboos/ocsp-server
Add option to specify OCSP server #3497
2021-02-05 11:27:37 +00:00
Maël ValaisandJames Munnelly ba22785445 Rename ocspServer to oscpServers
Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: James Munnelly <james@munnelly.eu>
2021-02-03 11:13:32 +01:00
Maël Valais d5c485970d issuer's ocsp server: add an example URL to the API
Signed-off-by: Maël Valais <mael@vls.dev>
2021-02-03 09:42:34 +01:00
Maël Valais 9fb0876d21 issuer's ocsp server: add validation of the URL
Signed-off-by: Maël Valais <mael@vls.dev>
2021-02-03 09:42:01 +01:00
Hugo StijnsandMaël Valais 5f18cce622 add option to specify OCSP server
Signed-off-by: Hugo Stijns <hugo@boosboos.net>
Signed-off-by: Maël Valais <mael@vls.dev>
2021-02-03 09:09:03 +01:00
Chulki Lee e90b494da6 Fix go comments for API docs
- Use backticks, not single/double quotes for enum values
- Fix allowed values
- Remove unnecessary quote

Signed-off-by: Chulki Lee <chulki.lee@gmail.com>
2021-01-22 20:21:19 +09:00
Maartje Eyskens be205c04e6 Run a codegen update
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2021-01-08 15:05:32 +01:00
Maartje Eyskens ab0cd57dc5 Use The cert-manager Authors.
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-12-11 19:04:13 +01:00
Maartje Eyskens 1788a9d758 Update copyright to cert-manager project
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-12-08 19:04:49 +01:00
jetstack-botandGitHub 0bcf759a25 Merge pull request #3433 from sorah/vault-issuer-exclude-root
Handle Vault issuer working as intermediate correctly
2020-12-03 09:23:14 +01:00
Sorah Fukumori f768afd0a3 vault: change condition precise
Signed-off-by: Sorah Fukumori <her@sorah.jp>
2020-11-28 18:13:49 +09:00
Sorah FukumoriandMaartje Eyskens 90c4f9e561 Avoid named return variables
Co-authored-by: Maartje Eyskens <maartje@eyskens.me>
Signed-off-by: Sorah Fukumori <her@sorah.jp>
2020-11-28 18:06:49 +09:00
Maartje Eyskens a869c59cb7 Remove internal API tags and annotations
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-11-20 13:42:24 +01:00
Maartje Eyskens d705838e83 Implement feedback
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-11-20 09:46:49 +01:00
Maartje Eyskens b7014c3dbd Fix rename in json too
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-11-20 09:46:49 +01:00
Maartje Eyskens 59048fed64 Rename field
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-11-20 09:46:49 +01:00
Maartje Eyskens 04d88479e4 Pass duration on until ACME order creation
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-11-20 09:46:49 +01:00
Maartje Eyskens 7b6573aa35 Add duration into ACME
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-11-20 09:45:32 +01:00
Mateusz Gozdek 27fa2f1ec4 Fix various typos found by codespell
Found by running this command:

codespell -S .git,*.png,go.sum -L keypair,iam,ans,unknwon,tage,ths,creater

Signed-off-by: Mateusz Gozdek <mgozdekof@gmail.com>
2020-11-07 14:55:13 +01:00
Sorah Fukumori 25fc672b80 vault: use issuing_ca field when no ca_chain available
Signed-off-by: Sorah Fukumori <her@sorah.jp>
2020-11-06 05:12:04 +09:00
Sorah Fukumori 69a0816ca1 vault: Handle missing ca_chain just in case
certutil should ensure CAChain always set...
https://github.com/hashicorp/vault/blob/3298836f6a90d95ff97af33cb2abd1f7269847df/sdk/helper/certutil/types.go

Signed-off-by: Sorah Fukumori <her@sorah.jp>
2020-11-06 05:12:03 +09:00
Sorah Fukumori 2f70e9d4db vault: extract PEM extraction to a dedicated function
Signed-off-by: Sorah Fukumori <her@sorah.jp>
2020-11-06 05:12:03 +09:00
Sorah FukumoriandChris Randles 64a5aecfdd Handle Vault issuer working as intermediate correctly
This patch changes a certificate issued with Vault issuer as follows:

- `ca.crt`: a root certificate, returned in `ca_chain` from Vault
- `tls.crt`: a leaf certificate, plus intermediate certificates
  if available in `ca_chain`

  i.e. `tls.crt` won't include a root certificate

This is a breaking change; Vault issuer had included an issuing CA as
a chain in `tls.crt`, but after this change it will no longer include a root
certificate when the issuing CA is not an intermediate. For `ca.crt`, it
had included a issuing CA only, which can be an intermediate.

`tls.crt` is not expected to contain a root certificate, as generally
clients must trust root certificates in advance. It is considered
redundant transmitting a root certificate from servers to clients during TLS
handshake. Other issuers, e.g. ACME, behave the same.

This fixes https://github.com/jetstack/cert-manager/issues/2166

This patch is based on https://github.com/jetstack/cert-manager/pull/3340

Co-authored-by: Chris Randles <randles.chris@gmail.com>
Signed-off-by: Sorah Fukumori <her@sorah.jp>
2020-11-06 05:12:03 +09:00
Richard Wall 885755630c Add API validation for Venafi Issuer config
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
2020-10-22 15:04:11 +01:00
Raphaël Pinson e1c8d3ad71 Regenerate CRDs
Signed-off-by: Raphaël Pinson <raphael.pinson@camptocamp.com>
2020-10-16 15:40:34 +02:00
Raphaël Pinson b2d719d6c3 Add encode_usages_in_request to Certificate spec (fix #3301)
Signed-off-by: Raphaël Pinson <raphael.pinson@camptocamp.com>
2020-10-16 15:40:32 +02:00
Maartje Eyskens 542b329914 Implement feedback
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-10-08 15:24:56 +02:00
Maartje Eyskens 0dbf037312 remove json tags from internal type
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-10-08 15:24:56 +02:00
Maartje Eyskens ed9c2e4f45 Fix description
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-10-08 15:24:56 +02:00
Maartje Eyskens eb3c2f4b1b Fix unit test
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-10-08 15:24:56 +02:00
Maartje Eyskens 918e1e04f3 Add e2e tests + fix validation
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-10-08 15:24:56 +02:00
Maartje Eyskens 39de7f3b99 Fix IP type
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-10-08 15:24:56 +02:00
Maartje Eyskens 0cda5b3421 Fix conversion
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-10-08 15:24:56 +02:00
Maartje Eyskens b3e25815a5 Add support for IPs in ACME
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
2020-10-08 15:24:56 +02:00