cert-manager

mirror of https://github.com/wahyd4/cert-manager.git synced 2026-08-23 03:56:34 +10:00

Files

T

Maël Valais 5c1fba52a5 Mock lister: fix the wrong stack frames for certificaterequests

The stack frames displayed using assert.Fail was not very informative.
That is due to t.Cleanup being called "outside" of the test case
context. There was no mention of the test file itself, gatherer_test.go
in the following example:

 certificaterequest.go:205:
         Error Trace:    certificaterequest.go:205
                                                 testing.go:872
                                                 testing.go:866
                                                 testing.go:873
                                                 testing.go:949
                                                 testing.go:1121
         Error:          lister.CertificateRequests was expected to be called but was not called
         Test:           TestDataForCertificate/should_return_error_when_the_list_func_returns_an_error

With this patch that vendors a simple version of assert.Fail, we get the
correct stack frames that the user needs in order to locate where this
failure happened:

 certificaterequest.go:254:
         Error Trace:    gatherer_test.go:230
                         gatherer_test.go:240
         Error:          lister.CertificateRequests was expected to be called but was not called
         Test:           TestDataForCertificate/should_return_error_when_the_list_func_returns_an_error

Signed-off-by: Maël Valais <mael@vls.dev>

2021-03-04 17:16:16 +01:00

acmechallenges

Merge pull request #3500 from meyskens/update-copy

2020-12-15 10:12:31 +00:00

acmeorders

Use The cert-manager Authors.

2020-12-11 19:04:13 +01:00

cainjector

Minor log message clarification

2021-01-07 19:21:11 +00:00

certificaterequests

Merge pull request #3699 from maelvls/ocsp-unit-test