mirror of
https://github.com/wahyd4/cert-manager.git
synced 2026-08-18 01:26:48 +10:00
jetstack-botandGitHub
d5a5c63333
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Ensure ACME HTTP01 reachability test passes 5 times before issuing certificate **What this PR does / why we need it**: See #154 for details. Sometimes HTTP routes have not propagated yet when using a controller such as GCLB. This forces us to wait for 5 consecutive passes of the HTTP01 self-check before proceeding. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # Closes #154 **Special notes for your reviewer**: * This adds an extra 10s delay onto *any* HTTP01 validation * The '5 tries' number is hardcoded into the HTTP01 solver **Release note**: ```release-note Ensure 5 consecutive HTTP01 self-checks to pass before issuing ACME certificate ```