From 0bae2bbb9b42c5a8dd2b8a144ffa55ace1c8a936 Mon Sep 17 00:00:00 2001 From: Marcel Fest Date: Mon, 18 Jan 2021 10:09:26 +0100 Subject: [PATCH] =?UTF-8?q?[bitnami/common]=20same=20behavior=20with=20emp?= =?UTF-8?q?ty=20string=20when=20the=20secret=20obje=E2=80=A6=20(#5057)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * [bitnami/common] same behavior with empty string when the secret object is used. When you pass in an empty string as the existingSecret the with statement ensures that the default name is used. If you pass in the new existingSecret object which is a dict it uses the empty string and not use the emptyString as reference to use the default string. Implementing another with statement ensures that the variable is set. * {bitnami/common] Fix the documenation fo supportsHelmVersion * [bitnami/common] Bump version in Chart.yaml * [bitnami/common] Bump the Chart.yaml version * fix indentation and whitespace --- bitnami/common/Chart.yaml | 2 +- bitnami/common/templates/_secrets.tpl | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/bitnami/common/Chart.yaml b/bitnami/common/Chart.yaml index 8413d8c4e..8f58c5f95 100644 --- a/bitnami/common/Chart.yaml +++ b/bitnami/common/Chart.yaml @@ -20,4 +20,4 @@ sources: - https://github.com/bitnami/charts - http://www.bitnami.com/ type: library -version: 1.3.5 +version: 1.3.6 diff --git a/bitnami/common/templates/_secrets.tpl b/bitnami/common/templates/_secrets.tpl index 8144a242d..673d5d2f2 100644 --- a/bitnami/common/templates/_secrets.tpl +++ b/bitnami/common/templates/_secrets.tpl @@ -21,7 +21,9 @@ Params: {{- with .existingSecret -}} {{- if not (typeIs "string" .) -}} -{{- $name = .name -}} +{{- with .name -}} +{{- $name = . -}} +{{- end -}} {{- else -}} {{- $name = . -}} {{- end -}}