From 9bcf10973f146af5fdfdffb74bc3a138251cf6bd Mon Sep 17 00:00:00 2001 From: Jorge Bianquetti Date: Thu, 1 Dec 2016 11:10:01 +0100 Subject: [PATCH] typo error and fixes proposed by Sameer --- incubator/node/Chart.yaml | 2 +- incubator/node/README.md | 2 +- incubator/node/templates/NOTES.txt | 2 +- incubator/node/templates/deployment.yaml | 2 +- incubator/node/values.yaml | 10 ++++++++-- 5 files changed, 12 insertions(+), 6 deletions(-) diff --git a/incubator/node/Chart.yaml b/incubator/node/Chart.yaml index fc465bdb3..5a1fbdee3 100644 --- a/incubator/node/Chart.yaml +++ b/incubator/node/Chart.yaml @@ -1,5 +1,5 @@ name: node -version: 0.0.1 +version: 0.1.0 description: NodeJs Event-driven I/O server-side JavaScript environment based on V8 keywords: - node diff --git a/incubator/node/README.md b/incubator/node/README.md index 823536d4b..d1390e2ca 100644 --- a/incubator/node/README.md +++ b/incubator/node/README.md @@ -51,7 +51,7 @@ The following tables lists the configurable parameters of the node chart and the | `imageTag` | node image Tag | `` | | `imagePullPolicy` | Image pull policy | `Always` if `imageTag` is `latest`, else `IfNotPresent` | | `repository` | Repo of the application | `git@github.com:jbianquetti-nami/simple-node-app.git` | -| `revison` | Revision to checkout | `master` | +| `revision` | Revision to checkout | `master` | | `mariadb.mariadbRootPassword` | MariaDB admin password | `nil` | | `serviceType` | Kubernetes Service type | `LoadBalancer` | | `persistence.enabled` | Enable persistence using PVC | `true` | diff --git a/incubator/node/templates/NOTES.txt b/incubator/node/templates/NOTES.txt index deccf0a13..9c5ecc40f 100644 --- a/incubator/node/templates/NOTES.txt +++ b/incubator/node/templates/NOTES.txt @@ -10,7 +10,7 @@ {{- else if contains "LoadBalancer" .Values.serviceType }} NOTE: It may take a few minutes for the LoadBalancer IP to be available. - Watch the status with: 'kubectl get svc -w {{ template "fullname" . }}' + Watch the status with: 'kubectl get svc -w {{ template "fullname" . }} --namespace {{ .Release.Namespace }}' export SERVICE_IP=$(kubectl get svc --namespace {{ .Release.Namespace }} {{ template "fullname" . }} -o jsonpath='{.status.loadBalancer.ingress[0].ip}') echo http://$SERVICE_IP/ diff --git a/incubator/node/templates/deployment.yaml b/incubator/node/templates/deployment.yaml index 9844705b5..4625948ce 100644 --- a/incubator/node/templates/deployment.yaml +++ b/incubator/node/templates/deployment.yaml @@ -43,7 +43,7 @@ spec: httpGet: path: / port: http - initialDelaySeconds: 60 + initialDelaySeconds: 5 timeoutSeconds: 1 resources: {{ toYaml .Values.resources | indent 10 }} diff --git a/incubator/node/values.yaml b/incubator/node/values.yaml index d85f30be2..57ee0707e 100644 --- a/incubator/node/values.yaml +++ b/incubator/node/values.yaml @@ -2,11 +2,17 @@ ## ref: https://hub.docker.com/r/bitnami/node/tags/ ## image: bitnami/node + +## Bitnami image Tag +## imageTag: 7.0.0-r1 -# Git repository http/https +## Git repository http/https +## repository: https://github.com/jbianquetti-nami/simple-node-app.git -# Git repository revision to checkout + +## Git repository revision to checkout +## revision: master ## Specify a imagePullPolicy