From 59d9dc44088b7d4cd75c57b89a24497335c20895 Mon Sep 17 00:00:00 2001 From: Dmitriy Zaporozhets Date: Thu, 3 Sep 2015 10:24:10 +0200 Subject: [PATCH 01/11] Reduce margin under projects filter Signed-off-by: Dmitriy Zaporozhets --- app/assets/stylesheets/pages/projects.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/assets/stylesheets/pages/projects.scss b/app/assets/stylesheets/pages/projects.scss index 0887837b86..e0f9b8cd19 100644 --- a/app/assets/stylesheets/pages/projects.scss +++ b/app/assets/stylesheets/pages/projects.scss @@ -256,7 +256,7 @@ pre.light-well { margin: -15px; background-color: #f8fafc; padding: 18px; - margin-bottom: 10px; + margin-bottom: 0px; border-top: 1px solid #e7e9ed; border-bottom: 1px solid #e7e9ed; From 63ba17c4db4984bb3d060fdf33d25b7038aa1856 Mon Sep 17 00:00:00 2001 From: Dmitriy Zaporozhets Date: Thu, 3 Sep 2015 13:44:54 +0200 Subject: [PATCH 02/11] Redesign activity feed on dashboard and project pages Signed-off-by: Dmitriy Zaporozhets --- app/assets/javascripts/activities.js.coffee | 2 +- app/assets/stylesheets/base/gl_variables.scss | 12 ++- app/assets/stylesheets/base/variables.scss | 2 +- app/assets/stylesheets/generic/blocks.scss | 9 +++ app/assets/stylesheets/generic/buttons.scss | 16 ++++ app/assets/stylesheets/pages/events.scss | 74 ++++++------------- app/helpers/events_helper.rb | 10 +-- app/views/dashboard/_activities.html.haml | 4 +- app/views/events/_event.html.haml | 4 +- app/views/projects/_activity.html.haml | 3 +- app/views/shared/_event_filter.html.haml | 2 +- 11 files changed, 70 insertions(+), 68 deletions(-) diff --git a/app/assets/javascripts/activities.js.coffee b/app/assets/javascripts/activities.js.coffee index 777c62dc1b..f1afa62f94 100644 --- a/app/assets/javascripts/activities.js.coffee +++ b/app/assets/javascripts/activities.js.coffee @@ -1,7 +1,7 @@ class @Activities constructor: -> Pager.init 20, true - $(".event_filter_link").bind "click", (event) => + $(".event-filter .btn").bind "click", (event) => event.preventDefault() @toggleFilter($(event.currentTarget)) @reloadActivities() diff --git a/app/assets/stylesheets/base/gl_variables.scss b/app/assets/stylesheets/base/gl_variables.scss index 56f4c794e1..bb49ed16c8 100644 --- a/app/assets/stylesheets/base/gl_variables.scss +++ b/app/assets/stylesheets/base/gl_variables.scss @@ -43,8 +43,9 @@ $font-size-base: $gl-font-size; //## Define common padding and border radius sizes and more. Values based on 14px text and 1.428 line-height (~20px to start). $padding-base-vertical: 6px; -$padding-base-horizontal: 14px; - +$padding-base-horizontal: 18px; +$component-active-color: #fff; +$component-active-bg: $brand-info; //== Forms // @@ -131,3 +132,10 @@ $code-bg: #f9f2f4; $kbd-color: #fff; $kbd-bg: #333; + +//== Buttons +// +//## +$btn-default-color: #7f8fa4; +$btn-default-bg: #fff; +$btn-default-border: #e7e9ed; diff --git a/app/assets/stylesheets/base/variables.scss b/app/assets/stylesheets/base/variables.scss index 81c1ab1c38..8c257c5453 100644 --- a/app/assets/stylesheets/base/variables.scss +++ b/app/assets/stylesheets/base/variables.scss @@ -21,7 +21,7 @@ $fixed-layout-width: 1200px; */ $gl-primary: #446e9b; $gl-success: #44c679; -$gl-info: #029ACF; +$gl-info: #00aaff; $gl-warning: #EB9532; $gl-danger: #d9534f; diff --git a/app/assets/stylesheets/generic/blocks.scss b/app/assets/stylesheets/generic/blocks.scss index 3536a68f41..1080bc1baa 100644 --- a/app/assets/stylesheets/generic/blocks.scss +++ b/app/assets/stylesheets/generic/blocks.scss @@ -17,3 +17,12 @@ font-size: 16px; line-height: 36px; } + +.gray-content-block { + margin: -15px; + background-color: #f8fafc; + padding: 18px; + margin-bottom: 0px; + border-top: 1px solid #e7e9ed; + border-bottom: 1px solid #e7e9ed; +} diff --git a/app/assets/stylesheets/generic/buttons.scss b/app/assets/stylesheets/generic/buttons.scss index cd6bf64c0a..e823750909 100644 --- a/app/assets/stylesheets/generic/buttons.scss +++ b/app/assets/stylesheets/generic/buttons.scss @@ -72,3 +72,19 @@ } } } + +.btn-group-next { + .btn { + padding: 9px 0px; + font-size: 15px; + color: #7f8fa4; + border-color: #e7e9ed; + width: 140px; + + &.active { + border-color: $gl-info; + background: $gl-info; + color: #fff; + } + } +} diff --git a/app/assets/stylesheets/pages/events.scss b/app/assets/stylesheets/pages/events.scss index d4af7506d5..c570bb1e43 100644 --- a/app/assets/stylesheets/pages/events.scss +++ b/app/assets/stylesheets/pages/events.scss @@ -1,39 +1,13 @@ -/** - * Events labels - * - */ -.event_label { - &.pushed { - padding: 0 2px; - } - - &.opened { - padding: 0 2px; - } - - &.closed { - padding: 0 2px; - } - - &.merged { - padding: 0 2px; - } - - &.left, - &.joined { - padding: 0 2px; - float: none; - } -} - /** * Dashboard events feed * */ .event-item { - &:first-child { - padding-top: 0; - } + font-size: 16px; + padding: 18px; + margin: 0 -15px; + border-bottom: 1px solid #f1f2f4; + color: #7f8fa4; &.event-inline { .avatar { @@ -42,29 +16,35 @@ } } - padding: 12px 0px; - border-bottom: 1px solid #eee; + a { + color: #4c4e54; + } + + .avatar { + margin-right: 15px; + } + .event-title { - max-width: 70%; @include str-truncated(calc(100% - 174px)); + + max-width: 70%; font-weight: 500; - font-size: 14px; + .author_name { color: #333; } } + .event-body { - font-size: 13px; - margin-left: 35px; + margin-left: 60px; margin-right: 80px; - color: #777; .event-note { margin-top: 5px; word-wrap: break-word; .md { - font-size: 13px; + font-size: 16px; iframe.twitter-share-button { vertical-align: bottom; @@ -116,7 +96,7 @@ &:last-child { border:none } .event_commits { - margin-top: 5px; + margin-top: 9px; li { &.commit { @@ -125,10 +105,12 @@ padding-left: 0; border: none; .commit-row-title { - font-size: 12px; + font-size: 16px; } } + &.commits-stat { + margin-top: 3px; display: block; padding: 3px; padding-left: 0; @@ -142,7 +124,6 @@ .event-item-timestamp { float: right; - color: #999; line-height: 22px; } } @@ -186,12 +167,3 @@ } } } - -.event_filter { - li a { - font-size: 13px; - padding: 5px 10px; - background: $background-color; - margin-left: 4px; - } -} diff --git a/app/helpers/events_helper.rb b/app/helpers/events_helper.rb index 8428281f8f..13347b6eec 100644 --- a/app/helpers/events_helper.rb +++ b/app/helpers/events_helper.rb @@ -27,16 +27,14 @@ module EventsHelper key = key.to_s active = 'active' if @event_filter.active?(key) link_opts = { - class: 'event_filter_link', + class: "event-filter-link btn btn-default #{active}", id: "#{key}_event_filter", title: "Filter by #{tooltip.downcase}", data: { toggle: 'tooltip', placement: 'top' } } - content_tag :li, class: "filter_icon #{active}" do - link_to request.path, link_opts do - icon(icon_for_event[key]) + content_tag(:span, ' ' + tooltip) - end + link_to request.path, link_opts do + content_tag(:span, ' ' + tooltip) end end @@ -66,7 +64,7 @@ module EventsHelper end words << "at" elsif event.target - words << "##{event.target_iid}:" + words << "##{event.target_iid}:" words << event.target.title if event.target.respond_to?(:title) words << "at" end diff --git a/app/views/dashboard/_activities.html.haml b/app/views/dashboard/_activities.html.haml index 213b5d65b3..1db56542af 100644 --- a/app/views/dashboard/_activities.html.haml +++ b/app/views/dashboard/_activities.html.haml @@ -1,13 +1,13 @@ .hidden-xs = render "events/event_last_push", event: @last_push +.gray-content-block - if current_user %ul.nav.nav-pills.event_filter.pull-right %li.pull-right = link_to dashboard_path(:atom, { private_token: current_user.private_token }), class: 'rss-btn' do %i.fa.fa-rss - = render 'shared/event_filter' - %hr + .content_list = spinner diff --git a/app/views/events/_event.html.haml b/app/views/events/_event.html.haml index 0faab4458e..3cd65edacb 100644 --- a/app/views/events/_event.html.haml +++ b/app/views/events/_event.html.haml @@ -3,8 +3,8 @@ .event-item-timestamp #{time_ago_with_tooltip(event.created_at)} - = cache [event, "v1"] do - = image_tag avatar_icon(event.author_email, 24), class: "avatar s24", alt:'' + = cache [event, "v2"] do + = image_tag avatar_icon(event.author_email, 48), class: "avatar s48", alt:'' - if event.created_project? = render "events/event/created_project", event: event - elsif event.push? diff --git a/app/views/projects/_activity.html.haml b/app/views/projects/_activity.html.haml index ee02b7f6a6..86133768d7 100644 --- a/app/views/projects/_activity.html.haml +++ b/app/views/projects/_activity.html.haml @@ -1,5 +1,5 @@ = render 'projects/last_push' -.hidden-xs +.gray-content-block - if current_user %ul.nav.nav-pills.event_filter.pull-right %li @@ -7,7 +7,6 @@ %i.fa.fa-rss = render 'shared/event_filter' - %hr .content_list{:"data-href" => activity_project_path(@project)} = spinner diff --git a/app/views/shared/_event_filter.html.haml b/app/views/shared/_event_filter.html.haml index 334db60690..8495774acc 100644 --- a/app/views/shared/_event_filter.html.haml +++ b/app/views/shared/_event_filter.html.haml @@ -1,4 +1,4 @@ -%ul.nav.nav-pills.event_filter +.btn-group.btn-group-next.event-filter = event_filter_link EventFilter.push, 'Push events' = event_filter_link EventFilter.merged, 'Merge events' = event_filter_link EventFilter.comments, 'Comments' From 7f045a6b4a2fadce8aa6bf6d1b1378519fc4000f Mon Sep 17 00:00:00 2001 From: Dmitriy Zaporozhets Date: Thu, 3 Sep 2015 14:24:27 +0200 Subject: [PATCH 03/11] Apply new font size and padding Signed-off-by: Dmitriy Zaporozhets --- app/assets/stylesheets/base/gl_variables.scss | 11 ++++++++--- app/assets/stylesheets/base/mixins.scss | 3 --- app/assets/stylesheets/base/variables.scss | 4 ++-- 3 files changed, 10 insertions(+), 8 deletions(-) diff --git a/app/assets/stylesheets/base/gl_variables.scss b/app/assets/stylesheets/base/gl_variables.scss index bb49ed16c8..23aa8029fb 100644 --- a/app/assets/stylesheets/base/gl_variables.scss +++ b/app/assets/stylesheets/base/gl_variables.scss @@ -42,7 +42,7 @@ $font-size-base: $gl-font-size; // //## Define common padding and border radius sizes and more. Values based on 14px text and 1.428 line-height (~20px to start). -$padding-base-vertical: 6px; +$padding-base-vertical: 9px; $padding-base-horizontal: 18px; $component-active-color: #fff; $component-active-bg: $brand-info; @@ -52,8 +52,8 @@ $component-active-bg: $brand-info; //## $input-color: $text-color; -$input-border: #DDD; -$input-border-focus: $brand-info; +$input-border: #e7e9ed; +$input-border-focus: #7F8FA4; $legend-color: $text-color; @@ -139,3 +139,8 @@ $kbd-bg: #333; $btn-default-color: #7f8fa4; $btn-default-bg: #fff; $btn-default-border: #e7e9ed; + +//== Nav +// +//## +$nav-link-padding: 13px 18px; diff --git a/app/assets/stylesheets/base/mixins.scss b/app/assets/stylesheets/base/mixins.scss index bf251d896e..66417c2bdf 100644 --- a/app/assets/stylesheets/base/mixins.scss +++ b/app/assets/stylesheets/base/mixins.scss @@ -55,9 +55,6 @@ } @mixin md-typography { - font-size: 15px; - line-height: 1.5; - img { max-width: 100%; } diff --git a/app/assets/stylesheets/base/variables.scss b/app/assets/stylesheets/base/variables.scss index 8c257c5453..5471a93dad 100644 --- a/app/assets/stylesheets/base/variables.scss +++ b/app/assets/stylesheets/base/variables.scss @@ -3,8 +3,8 @@ $hover: #FFFAF1; $gl-text-color: #222222; $gl-link-color: #446e9b; $nprogress-color: #c0392b; -$gl-font-size: 14px; -$list-font-size: 15px; +$gl-font-size: 16px; +$list-font-size: 16px; $sidebar_collapsed_width: 62px; $sidebar_width: 230px; $avatar_radius: 50%; From 1d6a65a2aba6382564f761ec7881e582fc6d055f Mon Sep 17 00:00:00 2001 From: Dmitriy Zaporozhets Date: Thu, 3 Sep 2015 14:43:31 +0200 Subject: [PATCH 04/11] Improve paddings and set new colors for links Signed-off-by: Dmitriy Zaporozhets --- app/assets/stylesheets/base/layout.scss | 1 - app/assets/stylesheets/base/variables.scss | 3 ++- app/assets/stylesheets/generic/blocks.scss | 2 +- app/assets/stylesheets/generic/common.scss | 10 +++++----- app/assets/stylesheets/generic/selects.scss | 8 ++++---- app/assets/stylesheets/generic/sidebar.scss | 3 +-- app/assets/stylesheets/pages/events.scss | 4 ++-- app/assets/stylesheets/pages/projects.scss | 4 ++-- app/assets/stylesheets/pages/tree.scss | 6 +++--- app/views/events/_commit.html.haml | 2 +- 10 files changed, 21 insertions(+), 22 deletions(-) diff --git a/app/assets/stylesheets/base/layout.scss b/app/assets/stylesheets/base/layout.scss index 734b95e26c..b91c15d891 100644 --- a/app/assets/stylesheets/base/layout.scss +++ b/app/assets/stylesheets/base/layout.scss @@ -21,7 +21,6 @@ html { margin-top: 30px; } - .container-limited { max-width: $fixed-layout-width; } diff --git a/app/assets/stylesheets/base/variables.scss b/app/assets/stylesheets/base/variables.scss index 5471a93dad..7d7f481cc4 100644 --- a/app/assets/stylesheets/base/variables.scss +++ b/app/assets/stylesheets/base/variables.scss @@ -1,7 +1,7 @@ $style_color: #474D57; $hover: #FFFAF1; $gl-text-color: #222222; -$gl-link-color: #446e9b; +$gl-link-color: #4c4e54; $nprogress-color: #c0392b; $gl-font-size: 16px; $list-font-size: 16px; @@ -14,6 +14,7 @@ $border-color: #E5E5E5; $background-color: #f5f5f5; $header-height: 73px; $fixed-layout-width: 1200px; +$gl-gray: #7f8fa4; /* diff --git a/app/assets/stylesheets/generic/blocks.scss b/app/assets/stylesheets/generic/blocks.scss index 1080bc1baa..16619502a5 100644 --- a/app/assets/stylesheets/generic/blocks.scss +++ b/app/assets/stylesheets/generic/blocks.scss @@ -19,7 +19,7 @@ } .gray-content-block { - margin: -15px; + margin: -18px; background-color: #f8fafc; padding: 18px; margin-bottom: 0px; diff --git a/app/assets/stylesheets/generic/common.scss b/app/assets/stylesheets/generic/common.scss index eaa1fe07b0..17dec22861 100644 --- a/app/assets/stylesheets/generic/common.scss +++ b/app/assets/stylesheets/generic/common.scss @@ -1,5 +1,5 @@ /** COLORS **/ -.cgray { color: gray } +.cgray { color: $gl-gray; } .clgray { color: #BBB } .cred { color: #D12F19 } .cgreen { color: #4a2 } @@ -20,7 +20,7 @@ .underlined-link { text-decoration: underline; } .hint { font-style: italic; color: #999; } -.light { color: #888 } +.light { color: $gl-gray; } .slead { color: #666; @@ -376,10 +376,10 @@ table { list-style: none; text-align: center; margin-top: 5px; - margin-bottom: 12px; + margin-bottom: 19px; height: 60px; - margin-top: -15px; - padding-top: 15px; + margin-top: -18px; + padding-top: 18px; li { display: inline-block; diff --git a/app/assets/stylesheets/generic/selects.scss b/app/assets/stylesheets/generic/selects.scss index d8e0dc028d..c6a1047e01 100644 --- a/app/assets/stylesheets/generic/selects.scss +++ b/app/assets/stylesheets/generic/selects.scss @@ -3,9 +3,9 @@ .select2-choice { background: #FFF; border-color: #DDD; - height: 34px; - padding: 6px 14px; - font-size: 14px; + height: 42px; + padding: 8px 18px; + font-size: $gl-font-size; line-height: 1.42857143; @include border-radius(4px); @@ -13,7 +13,7 @@ .select2-arrow { background: #FFF; border-left: none; - padding-top: 3px; + padding-top: 5px; } } } diff --git a/app/assets/stylesheets/generic/sidebar.scss b/app/assets/stylesheets/generic/sidebar.scss index 88d6c7ca6d..7f3688801a 100644 --- a/app/assets/stylesheets/generic/sidebar.scss +++ b/app/assets/stylesheets/generic/sidebar.scss @@ -25,8 +25,7 @@ .container-fluid { background: #FFF; - padding-top: 15px; - padding-bottom: 15px; + padding: 18px; border: 1px solid #e7e9ed; min-height: 90vh; } diff --git a/app/assets/stylesheets/pages/events.scss b/app/assets/stylesheets/pages/events.scss index c570bb1e43..a90b05da29 100644 --- a/app/assets/stylesheets/pages/events.scss +++ b/app/assets/stylesheets/pages/events.scss @@ -5,7 +5,7 @@ .event-item { font-size: 16px; padding: 18px; - margin: 0 -15px; + margin: 0 -18px; border-bottom: 1px solid #f1f2f4; color: #7f8fa4; @@ -36,7 +36,7 @@ } .event-body { - margin-left: 60px; + margin-left: 63px; margin-right: 80px; .event-note { diff --git a/app/assets/stylesheets/pages/projects.scss b/app/assets/stylesheets/pages/projects.scss index e0f9b8cd19..f8e3d861c0 100644 --- a/app/assets/stylesheets/pages/projects.scss +++ b/app/assets/stylesheets/pages/projects.scss @@ -253,7 +253,7 @@ pre.light-well { } .projects-search-form { - margin: -15px; + margin: -18px; background-color: #f8fafc; padding: 18px; margin-bottom: 0px; @@ -281,7 +281,7 @@ pre.light-well { .project-row { padding: 18px; border-color: #f1f2f4; - margin: 0 -15px; + margin: 0 -18px; &.no-description { .project { diff --git a/app/assets/stylesheets/pages/tree.scss b/app/assets/stylesheets/pages/tree.scss index 81e2aa7bb9..587d09a04a 100644 --- a/app/assets/stylesheets/pages/tree.scss +++ b/app/assets/stylesheets/pages/tree.scss @@ -63,15 +63,15 @@ padding-right: 8px; .commit-author-name { - color: gray; + color: $gl-gray; } } .tree_commit { - color: gray; + color: $gl-gray; .tree-commit-link { - color: gray; + color: $gl-gray; &:hover { text-decoration: underline; diff --git a/app/views/events/_commit.html.haml b/app/views/events/_commit.html.haml index 742b74a67c..ad63841ccf 100644 --- a/app/views/events/_commit.html.haml +++ b/app/views/events/_commit.html.haml @@ -1,5 +1,5 @@ %li.commit .commit-row-title = link_to truncate_sha(commit[:id]), namespace_project_commit_path(project.namespace, project, commit[:id]), class: "commit_short_id", alt: '' -   + · = gfm event_commit_title(commit[:message]), project: project From 6d651a0260066185fe39b1381d54a5281d13a7f8 Mon Sep 17 00:00:00 2001 From: Dmitriy Zaporozhets Date: Thu, 3 Sep 2015 15:09:55 +0200 Subject: [PATCH 05/11] Increase use of variables in css Signed-off-by: Dmitriy Zaporozhets --- app/assets/stylesheets/base/mixins.scss | 2 +- app/assets/stylesheets/generic/common.scss | 2 +- app/assets/stylesheets/generic/lists.scss | 14 ++++++++++++++ app/assets/stylesheets/pages/commits.scss | 6 +++--- app/assets/stylesheets/pages/events.scss | 8 ++++++++ app/assets/stylesheets/pages/projects.scss | 2 +- 6 files changed, 28 insertions(+), 6 deletions(-) diff --git a/app/assets/stylesheets/base/mixins.scss b/app/assets/stylesheets/base/mixins.scss index 66417c2bdf..2fd6c192e3 100644 --- a/app/assets/stylesheets/base/mixins.scss +++ b/app/assets/stylesheets/base/mixins.scss @@ -187,7 +187,7 @@ &.light { a { - color: #777; + color: $gl-gray; } } } diff --git a/app/assets/stylesheets/generic/common.scss b/app/assets/stylesheets/generic/common.scss index 17dec22861..7dfb19e907 100644 --- a/app/assets/stylesheets/generic/common.scss +++ b/app/assets/stylesheets/generic/common.scss @@ -376,7 +376,7 @@ table { list-style: none; text-align: center; margin-top: 5px; - margin-bottom: 19px; + margin-bottom: 18px; height: 60px; margin-top: -18px; padding-top: 18px; diff --git a/app/assets/stylesheets/generic/lists.scss b/app/assets/stylesheets/generic/lists.scss index 4b7ff84de2..26c2234c8d 100644 --- a/app/assets/stylesheets/generic/lists.scss +++ b/app/assets/stylesheets/generic/lists.scss @@ -109,3 +109,17 @@ ul.bordered-list { li.task-list-item { list-style-type: none; } + +ul.content-list { + @include basic-list; + + margin: 0; + padding: 0; + + li { + padding: 18px; + border-color: #f1f2f4; + margin: 0 -18px; + } +} + diff --git a/app/assets/stylesheets/pages/commits.scss b/app/assets/stylesheets/pages/commits.scss index 359f4073e8..de2ae93df3 100644 --- a/app/assets/stylesheets/pages/commits.scss +++ b/app/assets/stylesheets/pages/commits.scss @@ -52,7 +52,7 @@ li.commit { } .commit-row-message { - color: #444; + color: $gl-link-color; &:hover { text-decoration: underline; @@ -88,12 +88,12 @@ li.commit { } .commit-row-info { - color: #777; + color: $gl-gray; line-height: 24px; font-size: 13px; a { - color: #777; + color: $gl-gray; } .committed_ago { diff --git a/app/assets/stylesheets/pages/events.scss b/app/assets/stylesheets/pages/events.scss index a90b05da29..1d71a542f8 100644 --- a/app/assets/stylesheets/pages/events.scss +++ b/app/assets/stylesheets/pages/events.scss @@ -14,6 +14,14 @@ position: relative; top: -2px; } + + .event-title { + line-height: 44px; + } + + .event-item-timestamp { + line-height: 44px; + } } a { diff --git a/app/assets/stylesheets/pages/projects.scss b/app/assets/stylesheets/pages/projects.scss index f8e3d861c0..2095e73f55 100644 --- a/app/assets/stylesheets/pages/projects.scss +++ b/app/assets/stylesheets/pages/projects.scss @@ -184,7 +184,7 @@ ul.nav.nav-projects-tabs { .breadcrumb.repo-breadcrumb { padding: 0; - line-height: 34px; + line-height: 42px; background: white; border: none; font-size: 16px; From aeeb31d6b7073921603fefd9118a50f28742009f Mon Sep 17 00:00:00 2001 From: Dmitriy Zaporozhets Date: Thu, 3 Sep 2015 15:46:13 +0200 Subject: [PATCH 06/11] Change some base colors in UI Signed-off-by: Dmitriy Zaporozhets --- app/assets/stylesheets/base/gl_variables.scss | 4 ++-- app/assets/stylesheets/base/mixins.scss | 6 ++++++ app/assets/stylesheets/base/variables.scss | 9 +++++---- app/assets/stylesheets/generic/common.scss | 2 +- app/assets/stylesheets/generic/lists.scss | 11 ----------- app/assets/stylesheets/generic/typography.scss | 5 +++++ app/assets/stylesheets/pages/dashboard.scss | 2 +- app/assets/stylesheets/pages/issues.scss | 2 +- app/assets/stylesheets/pages/merge_requests.scss | 2 +- app/assets/stylesheets/themes/gitlab-theme.scss | 4 ++++ app/views/groups/_projects.html.haml | 2 +- app/views/shared/_clone_panel.html.haml | 6 +++--- 12 files changed, 30 insertions(+), 25 deletions(-) diff --git a/app/assets/stylesheets/base/gl_variables.scss b/app/assets/stylesheets/base/gl_variables.scss index 23aa8029fb..1f71b0a52b 100644 --- a/app/assets/stylesheets/base/gl_variables.scss +++ b/app/assets/stylesheets/base/gl_variables.scss @@ -112,8 +112,8 @@ $alert-border-radius: 0; $panel-border-radius: 0; $panel-default-text: $text-color; -$panel-default-border: $border-color; -$panel-default-heading-bg: $background-color; +$panel-default-border: #E7E9ED; +$panel-default-heading-bg: #F8FAFC; //== Wells diff --git a/app/assets/stylesheets/base/mixins.scss b/app/assets/stylesheets/base/mixins.scss index 2fd6c192e3..2d2e8b3ded 100644 --- a/app/assets/stylesheets/base/mixins.scss +++ b/app/assets/stylesheets/base/mixins.scss @@ -55,6 +55,12 @@ } @mixin md-typography { + color: #444; + + a { + color: #3084bb; + } + img { max-width: 100%; } diff --git a/app/assets/stylesheets/base/variables.scss b/app/assets/stylesheets/base/variables.scss index 7d7f481cc4..b0cf1cb6f0 100644 --- a/app/assets/stylesheets/base/variables.scss +++ b/app/assets/stylesheets/base/variables.scss @@ -1,7 +1,8 @@ $style_color: #474D57; $hover: #FFFAF1; -$gl-text-color: #222222; -$gl-link-color: #4c4e54; +$gl-text-color: #7f8fa4; +$gl-header-color: #4c4e54; +$gl-link-color: #333c48; $nprogress-color: #c0392b; $gl-font-size: 16px; $list-font-size: 16px; @@ -10,8 +11,8 @@ $sidebar_width: 230px; $avatar_radius: 50%; $code_font_size: 13px; $code_line_height: 1.5; -$border-color: #E5E5E5; -$background-color: #f5f5f5; +$border-color: #E7E9ED; +$background-color: #F8FAFC; $header-height: 73px; $fixed-layout-width: 1200px; $gl-gray: #7f8fa4; diff --git a/app/assets/stylesheets/generic/common.scss b/app/assets/stylesheets/generic/common.scss index 7dfb19e907..55569bebfa 100644 --- a/app/assets/stylesheets/generic/common.scss +++ b/app/assets/stylesheets/generic/common.scss @@ -23,7 +23,7 @@ .light { color: $gl-gray; } .slead { - color: #666; + color: $gl-gray; font-size: 15px; margin-bottom: 12px; font-weight: normal; diff --git a/app/assets/stylesheets/generic/lists.scss b/app/assets/stylesheets/generic/lists.scss index 26c2234c8d..766992d7af 100644 --- a/app/assets/stylesheets/generic/lists.scss +++ b/app/assets/stylesheets/generic/lists.scss @@ -49,8 +49,6 @@ } } - .author { color: #999; } - .list-item-name { float: left; position: relative; @@ -71,15 +69,6 @@ font-size: $list-font-size; line-height: 18px; } - - .row_title { - color: $gray-dark; - - &:hover { - color: $text-color; - text-decoration: underline; - } - } } } diff --git a/app/assets/stylesheets/generic/typography.scss b/app/assets/stylesheets/generic/typography.scss index 34b4ee3e17..73034c84f9 100644 --- a/app/assets/stylesheets/generic/typography.scss +++ b/app/assets/stylesheets/generic/typography.scss @@ -9,6 +9,11 @@ margin-bottom: 5px; } +h1, h2, h3, h4, h5, h6 { + color: $gl-header-color; + font-weight: 500; +} + /** CODE **/ pre { font-family: $monospace_font; diff --git a/app/assets/stylesheets/pages/dashboard.scss b/app/assets/stylesheets/pages/dashboard.scss index 01ee41d0fa..008c6419f0 100644 --- a/app/assets/stylesheets/pages/dashboard.scss +++ b/app/assets/stylesheets/pages/dashboard.scss @@ -2,7 +2,7 @@ .side { .panel { .panel-heading { - background: #EEE; + background: $background-color; border-top-left-radius: 0; } border-top-left-radius: 0; diff --git a/app/assets/stylesheets/pages/issues.scss b/app/assets/stylesheets/pages/issues.scss index 3572f33e91..7928b6220f 100644 --- a/app/assets/stylesheets/pages/issues.scss +++ b/app/assets/stylesheets/pages/issues.scss @@ -10,7 +10,7 @@ } .issue-info { - color: #999; + color: $gl-gray; font-size: 13px; } diff --git a/app/assets/stylesheets/pages/merge_requests.scss b/app/assets/stylesheets/pages/merge_requests.scss index 10fce5b3da..f0fb68d342 100644 --- a/app/assets/stylesheets/pages/merge_requests.scss +++ b/app/assets/stylesheets/pages/merge_requests.scss @@ -136,7 +136,7 @@ } .merge-request-info { - color: #999; + color: $gl-gray; font-size: 13px; } diff --git a/app/assets/stylesheets/themes/gitlab-theme.scss b/app/assets/stylesheets/themes/gitlab-theme.scss index d523bb8952..8d9a0aae56 100644 --- a/app/assets/stylesheets/themes/gitlab-theme.scss +++ b/app/assets/stylesheets/themes/gitlab-theme.scss @@ -14,6 +14,10 @@ a { color: $color-light; + + h3 { + color: $color-light; + } } &:hover { diff --git a/app/views/groups/_projects.html.haml b/app/views/groups/_projects.html.haml index b2e32ced5e..9ac56b1e5f 100644 --- a/app/views/groups/_projects.html.haml +++ b/app/views/groups/_projects.html.haml @@ -7,4 +7,4 @@ = link_to new_project_path(namespace_id: @group.id), class: 'btn btn-success' do New project - = render 'shared/projects/list', projects: @projects, projects_limit: 20 + = render 'shared/projects/list', projects: @projects, projects_limit: 20, stars: false diff --git a/app/views/shared/_clone_panel.html.haml b/app/views/shared/_clone_panel.html.haml index 07672359db..2cd422e772 100644 --- a/app/views/shared/_clone_panel.html.haml +++ b/app/views/shared/_clone_panel.html.haml @@ -4,7 +4,7 @@ .input-group-btn %button{ | type: 'button', | - class: "btn btn-sm #{ 'active' if default_clone_protocol == 'ssh' }#{ ' has_tooltip' if current_user && current_user.require_ssh_key? }", | + class: "btn #{ 'active' if default_clone_protocol == 'ssh' }#{ ' has_tooltip' if current_user && current_user.require_ssh_key? }", | :"data-clone" => project.ssh_url_to_repo, | :"data-title" => "Add an SSH key to your profile
to pull or push via SSH", :"data-html" => "true", @@ -13,13 +13,13 @@ .input-group-btn %button{ | type: 'button', | - class: "btn btn-sm #{ 'active' if default_clone_protocol == 'http' }#{ ' has_tooltip' if current_user && current_user.require_password? }", | + class: "btn #{ 'active' if default_clone_protocol == 'http' }#{ ' has_tooltip' if current_user && current_user.require_password? }", | :"data-clone" => project.http_url_to_repo, | :"data-title" => "Set a password on your account
to pull or push via #{gitlab_config.protocol.upcase}", :"data-html" => "true", :"data-container" => "body"} = gitlab_config.protocol.upcase - = text_field_tag :project_clone, default_url_to_repo(project), class: "js-select-on-focus form-control input-sm", readonly: true + = text_field_tag :project_clone, default_url_to_repo(project), class: "js-select-on-focus form-control", readonly: true - if project.kind_of?(Project) .input-group-addon .visibility-level-label.has_tooltip{'data-title' => "#{visibility_level_label(project.visibility_level)} project" } From 0195b085a191dfa07799dcc0f232f76954910124 Mon Sep 17 00:00:00 2001 From: Dmitriy Zaporozhets Date: Thu, 3 Sep 2015 17:21:48 +0200 Subject: [PATCH 07/11] Style groups page Signed-off-by: Dmitriy Zaporozhets --- app/assets/stylesheets/generic/lists.scss | 4 ++++ app/views/dashboard/groups/index.html.haml | 11 +++++++---- app/views/shared/groups/_group.html.haml | 2 +- 3 files changed, 12 insertions(+), 5 deletions(-) diff --git a/app/assets/stylesheets/generic/lists.scss b/app/assets/stylesheets/generic/lists.scss index 766992d7af..04a98fc695 100644 --- a/app/assets/stylesheets/generic/lists.scss +++ b/app/assets/stylesheets/generic/lists.scss @@ -109,6 +109,10 @@ ul.content-list { padding: 18px; border-color: #f1f2f4; margin: 0 -18px; + + .avatar { + margin-right: 15px; + } } } diff --git a/app/views/dashboard/groups/index.html.haml b/app/views/dashboard/groups/index.html.haml index fbe523b4b6..0c7f8a6f2f 100644 --- a/app/views/dashboard/groups/index.html.haml +++ b/app/views/dashboard/groups/index.html.haml @@ -1,14 +1,17 @@ - page_title "Groups" = render 'dashboard/groups_head' -.slead - Group members have access to all group projects. +.gray-content-block - if current_user.can_create_group? %span.pull-right.hidden-xs - = link_to new_group_path, class: "btn btn-new btn-sm" do + = link_to new_group_path, class: "btn btn-new" do %i.fa.fa-plus New Group -%ul.bordered-list + Welcome to the groups! + %br + Group members have access to all group projects. + +%ul.content-list - @group_members.each do |group_member| - group = group_member.group = render 'shared/groups/group', group: group, group_member: group_member diff --git a/app/views/shared/groups/_group.html.haml b/app/views/shared/groups/_group.html.haml index 229ae359bc..2d7f911e35 100644 --- a/app/views/shared/groups/_group.html.haml +++ b/app/views/shared/groups/_group.html.haml @@ -11,7 +11,7 @@ %i.fa.fa-sign-out Leave - = image_tag group_icon(group), class: "avatar s40 avatar-tile hidden-xs" + = image_tag group_icon(group), class: "avatar s48 hidden-xs" = link_to group, class: 'group-name' do %strong= group.name From 89df4a7922431b59c65c91199a93639663da667d Mon Sep 17 00:00:00 2001 From: Dmitriy Zaporozhets Date: Thu, 3 Sep 2015 18:19:31 +0200 Subject: [PATCH 08/11] New UI for explore groups and trending pages Signed-off-by: Dmitriy Zaporozhets --- app/views/explore/groups/index.html.haml | 6 +++--- app/views/explore/projects/trending.html.haml | 4 ++-- app/views/shared/groups/_group.html.haml | 4 +--- 3 files changed, 6 insertions(+), 8 deletions(-) diff --git a/app/views/explore/groups/index.html.haml b/app/views/explore/groups/index.html.haml index 80acb91436..86410db2b2 100644 --- a/app/views/explore/groups/index.html.haml +++ b/app/views/explore/groups/index.html.haml @@ -1,14 +1,14 @@ - page_title "Groups" - if current_user = render 'dashboard/groups_head' -.clearfix.append-bottom-10 +.gray-content-block.clearfix .pull-left = form_tag explore_groups_path, method: :get, class: 'form-inline form-tiny' do |f| = hidden_field_tag :sort, @sort .form-group = search_field_tag :search, params[:search], placeholder: "Filter by name", class: "form-control search-text-input", id: "groups_search" .form-group - = button_tag 'Search', class: "btn btn-primary wide" + = button_tag 'Search', class: "btn btn-default" .pull-right .dropdown.inline @@ -30,7 +30,7 @@ = link_to explore_groups_path(sort: sort_value_oldest_updated) do = sort_title_oldest_updated -%ul.bordered-list +%ul.content-list - @groups.each do |group| = render 'shared/groups/group', group: group - unless @groups.present? diff --git a/app/views/explore/projects/trending.html.haml b/app/views/explore/projects/trending.html.haml index 4c7e7d4473..1590bb9fc6 100644 --- a/app/views/explore/projects/trending.html.haml +++ b/app/views/explore/projects/trending.html.haml @@ -1,12 +1,12 @@ - page_title "Trending Projects" - if current_user = render 'dashboard/projects_head' -.explore-title + +.gray-content-block.explore-title %h3 Explore GitLab %p.lead Discover projects and groups. Share your projects with others -%hr .explore-trending-block .lead %i.fa.fa-comments-o diff --git a/app/views/shared/groups/_group.html.haml b/app/views/shared/groups/_group.html.haml index 2d7f911e35..444410b258 100644 --- a/app/views/shared/groups/_group.html.haml +++ b/app/views/shared/groups/_group.html.haml @@ -5,11 +5,9 @@ - if can?(current_user, :admin_group, group) = link_to edit_group_path(group), class: "btn-sm btn btn-grouped" do %i.fa.fa-cogs - Settings = link_to leave_group_group_members_path(group), data: { confirm: leave_group_message(group.name) }, method: :delete, class: "btn-sm btn btn-grouped", title: 'Leave this group' do %i.fa.fa-sign-out - Leave = image_tag group_icon(group), class: "avatar s48 hidden-xs" = link_to group, class: 'group-name' do @@ -17,7 +15,7 @@ - if group_member as - %strong #{group_member.human_access} + %span #{group_member.human_access} %div.light #{pluralize(group.projects.count, "project")}, #{pluralize(group.users.count, "user")} From 1c8ec154a90d45171b23a22a6b6eaaec7caadb2f Mon Sep 17 00:00:00 2001 From: Dmitriy Zaporozhets Date: Thu, 3 Sep 2015 18:48:35 +0200 Subject: [PATCH 09/11] Refactor colors Signed-off-by: Dmitriy Zaporozhets --- app/assets/stylesheets/base/variables.scss | 3 +-- app/assets/stylesheets/generic/blocks.scss | 11 ++++++++--- app/assets/stylesheets/generic/common.scss | 2 -- app/assets/stylesheets/generic/lists.scss | 6 ++++++ app/assets/stylesheets/pages/commit.scss | 4 ---- app/views/dashboard/groups/index.html.haml | 3 +-- app/views/shared/groups/_group.html.haml | 2 +- 7 files changed, 17 insertions(+), 14 deletions(-) diff --git a/app/assets/stylesheets/base/variables.scss b/app/assets/stylesheets/base/variables.scss index b0cf1cb6f0..b87f16eed0 100644 --- a/app/assets/stylesheets/base/variables.scss +++ b/app/assets/stylesheets/base/variables.scss @@ -1,6 +1,5 @@ -$style_color: #474D57; $hover: #FFFAF1; -$gl-text-color: #7f8fa4; +$gl-text-color: #54565b; $gl-header-color: #4c4e54; $gl-link-color: #333c48; $nprogress-color: #c0392b; diff --git a/app/assets/stylesheets/generic/blocks.scss b/app/assets/stylesheets/generic/blocks.scss index 16619502a5..01dec66e3d 100644 --- a/app/assets/stylesheets/generic/blocks.scss +++ b/app/assets/stylesheets/generic/blocks.scss @@ -1,18 +1,18 @@ .light-well { - background: #f9f9f9; + background-color: #f8fafc; padding: 15px; } .centered-light-block { text-align: center; - color: #888; + color: $gl-gray; margin: 20px; } .nothing-here-block { text-align: center; padding: 20px; - color: #666; + color: $gl-gray; font-weight: normal; font-size: 16px; line-height: 36px; @@ -25,4 +25,9 @@ margin-bottom: 0px; border-top: 1px solid #e7e9ed; border-bottom: 1px solid #e7e9ed; + color: $gl-gray; + + .title { + color: $gl-text-color; + } } diff --git a/app/assets/stylesheets/generic/common.scss b/app/assets/stylesheets/generic/common.scss index 55569bebfa..1f5e972eed 100644 --- a/app/assets/stylesheets/generic/common.scss +++ b/app/assets/stylesheets/generic/common.scss @@ -74,8 +74,6 @@ pre { color: $gl-link-color; } -.help li { color:$style_color; } - .back-link { font-size: 14px; } diff --git a/app/assets/stylesheets/generic/lists.scss b/app/assets/stylesheets/generic/lists.scss index 04a98fc695..7302f84c3a 100644 --- a/app/assets/stylesheets/generic/lists.scss +++ b/app/assets/stylesheets/generic/lists.scss @@ -109,10 +109,16 @@ ul.content-list { padding: 18px; border-color: #f1f2f4; margin: 0 -18px; + color: $gl-gray; .avatar { margin-right: 15px; } + + .controls { + padding-top: 10px; + float: right; + } } } diff --git a/app/assets/stylesheets/pages/commit.scss b/app/assets/stylesheets/pages/commit.scss index e7125c0399..5436c6dad9 100644 --- a/app/assets/stylesheets/pages/commit.scss +++ b/app/assets/stylesheets/pages/commit.scss @@ -61,10 +61,6 @@ } } -.file-stats a { - color: $style_color; -} - .file-stats { .new-file { a { diff --git a/app/views/dashboard/groups/index.html.haml b/app/views/dashboard/groups/index.html.haml index 0c7f8a6f2f..9307812d49 100644 --- a/app/views/dashboard/groups/index.html.haml +++ b/app/views/dashboard/groups/index.html.haml @@ -7,8 +7,7 @@ = link_to new_group_path, class: "btn btn-new" do %i.fa.fa-plus New Group - Welcome to the groups! - %br + .title Welcome to the groups! Group members have access to all group projects. %ul.content-list diff --git a/app/views/shared/groups/_group.html.haml b/app/views/shared/groups/_group.html.haml index 444410b258..55e6370811 100644 --- a/app/views/shared/groups/_group.html.haml +++ b/app/views/shared/groups/_group.html.haml @@ -1,7 +1,7 @@ - group_member = local_assigns[:group_member] %li - if group_member - .pull-right.hidden-xs + .controls.hidden-xs - if can?(current_user, :admin_group, group) = link_to edit_group_path(group), class: "btn-sm btn btn-grouped" do %i.fa.fa-cogs From b7427faa49752f97019d450980c53b8e2339f062 Mon Sep 17 00:00:00 2001 From: Dmitriy Zaporozhets Date: Thu, 3 Sep 2015 19:07:23 +0200 Subject: [PATCH 10/11] Improve starred and trending pages Signed-off-by: Dmitriy Zaporozhets --- app/assets/stylesheets/generic/blocks.scss | 4 ++++ app/assets/stylesheets/generic/common.scss | 2 +- app/assets/stylesheets/pages/projects.scss | 11 ---------- app/views/explore/projects/starred.html.haml | 8 +++++--- app/views/explore/projects/trending.html.haml | 20 ++++++++++--------- app/views/layouts/header/_public.html.haml | 2 +- 6 files changed, 22 insertions(+), 25 deletions(-) diff --git a/app/assets/stylesheets/generic/blocks.scss b/app/assets/stylesheets/generic/blocks.scss index 01dec66e3d..e012ef2f06 100644 --- a/app/assets/stylesheets/generic/blocks.scss +++ b/app/assets/stylesheets/generic/blocks.scss @@ -30,4 +30,8 @@ .title { color: $gl-text-color; } + + .oneline { + line-height: 44px; + } } diff --git a/app/assets/stylesheets/generic/common.scss b/app/assets/stylesheets/generic/common.scss index 1f5e972eed..11519268fe 100644 --- a/app/assets/stylesheets/generic/common.scss +++ b/app/assets/stylesheets/generic/common.scss @@ -301,7 +301,7 @@ table { } .btn-sign-in { - margin-top: 7px; + margin-top: 15px; text-shadow: none; } diff --git a/app/assets/stylesheets/pages/projects.scss b/app/assets/stylesheets/pages/projects.scss index 2095e73f55..24fc54ab30 100644 --- a/app/assets/stylesheets/pages/projects.scss +++ b/app/assets/stylesheets/pages/projects.scss @@ -259,17 +259,6 @@ pre.light-well { margin-bottom: 0px; border-top: 1px solid #e7e9ed; border-bottom: 1px solid #e7e9ed; - - - .projects-list-filter { - @include input-big; - padding: 5px 18px; - } - - .btn { - @include btn-big; - padding: 5px 18px; - } } /* diff --git a/app/views/explore/projects/starred.html.haml b/app/views/explore/projects/starred.html.haml index 4a9fcae4be..a9df32f3d7 100644 --- a/app/views/explore/projects/starred.html.haml +++ b/app/views/explore/projects/starred.html.haml @@ -1,11 +1,13 @@ - page_title "Starred Projects" - if current_user = render 'dashboard/projects_head' + .explore-trending-block - .lead - %i.fa.fa-star - See most starred projects + .gray-content-block .pull-right = render 'explore/projects/dropdown' + .oneline + %i.fa.fa-star + See most starred projects = render 'projects', projects: @starred_projects = paginate @starred_projects, theme: 'gitlab' diff --git a/app/views/explore/projects/trending.html.haml b/app/views/explore/projects/trending.html.haml index 1590bb9fc6..c1ef06f6cd 100644 --- a/app/views/explore/projects/trending.html.haml +++ b/app/views/explore/projects/trending.html.haml @@ -1,16 +1,18 @@ - page_title "Trending Projects" - if current_user = render 'dashboard/projects_head' - -.gray-content-block.explore-title - %h3 - Explore GitLab - %p.lead - Discover projects and groups. Share your projects with others +- else + .explore-title + %h3 + Explore GitLab + %p.lead + Discover projects and groups. Share your projects with others + %br .explore-trending-block - .lead - %i.fa.fa-comments-o - See most discussed projects for last month + .gray-content-block .pull-right = render 'explore/projects/dropdown' + .oneline + %i.fa.fa-comments-o + See most discussed projects for last month = render 'projects', projects: @trending_projects diff --git a/app/views/layouts/header/_public.html.haml b/app/views/layouts/header/_public.html.haml index 265937c7f4..a6a26518a0 100644 --- a/app/views/layouts/header/_public.html.haml +++ b/app/views/layouts/header/_public.html.haml @@ -3,7 +3,7 @@ .header-content - unless current_controller?('sessions') .pull-right - = link_to "Sign in", new_session_path(:user, redirect_to_referer: 'yes'), class: 'btn btn-sign-in btn-success btn-sm' + = link_to "Sign in", new_session_path(:user, redirect_to_referer: 'yes'), class: 'btn btn-sign-in btn-success' %h1.title= title From 211e775039487552033f27f6e4b6588cd99e206c Mon Sep 17 00:00:00 2001 From: Dmitriy Zaporozhets Date: Thu, 3 Sep 2015 19:08:43 +0200 Subject: [PATCH 11/11] Improve explore proojects page Signed-off-by: Dmitriy Zaporozhets --- app/views/explore/projects/_filter.html.haml | 2 +- app/views/explore/projects/index.html.haml | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/app/views/explore/projects/_filter.html.haml b/app/views/explore/projects/_filter.html.haml index 4b91291caf..5a3d689d1e 100644 --- a/app/views/explore/projects/_filter.html.haml +++ b/app/views/explore/projects/_filter.html.haml @@ -3,7 +3,7 @@ .form-group = search_field_tag :search, params[:search], placeholder: "Filter by name", class: "form-control search-text-input", id: "projects_search" .form-group - = button_tag 'Search', class: "btn btn-primary wide" + = button_tag 'Search', class: "btn btn-success" .pull-right.hidden-sm.hidden-xs - if current_user diff --git a/app/views/explore/projects/index.html.haml b/app/views/explore/projects/index.html.haml index 0cfdf5cfd1..9df5b3830a 100644 --- a/app/views/explore/projects/index.html.haml +++ b/app/views/explore/projects/index.html.haml @@ -1,8 +1,7 @@ - page_title "Projects" - if current_user = render 'dashboard/projects_head' -.clearfix +.gray-content-block.clearfix = render 'filter' -%br = render 'projects', projects: @projects = paginate @projects, theme: "gitlab"