From 8353cc6111e12fa819debe188776d7b6195ffaad Mon Sep 17 00:00:00 2001 From: Douglas Barbosa Alexandre Date: Fri, 1 Jul 2016 16:04:24 -0300 Subject: [PATCH 1/3] Fix import button when import fail due the namespace already been taken --- app/assets/javascripts/importer_status.js.coffee | 2 +- app/views/import/base/create.js.haml | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/app/assets/javascripts/importer_status.js.coffee b/app/assets/javascripts/importer_status.js.coffee index b0edc89564..ec42c992e9 100644 --- a/app/assets/javascripts/importer_status.js.coffee +++ b/app/assets/javascripts/importer_status.js.coffee @@ -13,7 +13,7 @@ class @ImporterStatus id = $tr.attr('id').replace('repo_', '') if $tr.find('.import-target input').length > 0 new_namespace = $tr.find('.import-target input').prop('value') - $tr.find('.import-target').empty().append("#{new_namespace} / #{$tr.find('.import-target').data('project_name')}") + $tr.find('.import-target').empty().append("#{new_namespace}/#{$tr.find('.import-target').data('project_name')}") $btn .disable() diff --git a/app/views/import/base/create.js.haml b/app/views/import/base/create.js.haml index dfebf7768d..804ad88468 100644 --- a/app/views/import/base/create.js.haml +++ b/app/views/import/base/create.js.haml @@ -1,6 +1,8 @@ - if @already_been_taken :plain - target_field = $("tr#repo_#{@repo_id} .import-target") + tr = $("tr#repo_#{@repo_id}") + target_field = tr.find(".import-target") + import_button = tr.find(".btn-import") origin_target = target_field.text() project_name = "#{@project_name}" origin_namespace = "#{@target_namespace}" @@ -10,6 +12,7 @@ target_field.append("/" + project_name) target_field.data("project_name", project_name) target_field.find('input').prop("value", origin_namespace) + import_button.enable().removeClass('is-loading') - elsif @access_denied :plain job = $("tr#repo_#{@repo_id}") From 3d69d01e1fe78427f00e3e89e94975819c764806 Mon Sep 17 00:00:00 2001 From: Douglas Barbosa Alexandre Date: Fri, 1 Jul 2016 16:43:02 -0300 Subject: [PATCH 2/3] Cache results from jQuery selectors to retrieve namespace name --- app/assets/javascripts/importer_status.js.coffee | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/app/assets/javascripts/importer_status.js.coffee b/app/assets/javascripts/importer_status.js.coffee index ec42c992e9..eb046eb2ef 100644 --- a/app/assets/javascripts/importer_status.js.coffee +++ b/app/assets/javascripts/importer_status.js.coffee @@ -7,13 +7,16 @@ class @ImporterStatus $('.js-add-to-import') .off 'click' .on 'click', (e) => - new_namespace = null $btn = $(e.currentTarget) $tr = $btn.closest('tr') + $target_field = $tr.find('.import-target') + $namespace_input = $target_field.find('input') id = $tr.attr('id').replace('repo_', '') - if $tr.find('.import-target input').length > 0 - new_namespace = $tr.find('.import-target input').prop('value') - $tr.find('.import-target').empty().append("#{new_namespace}/#{$tr.find('.import-target').data('project_name')}") + new_namespace = null + + if $namespace_input.length > 0 + new_namespace = $namespace_input.prop('value') + $target_field.empty().append("#{new_namespace}/#{$target_field.data('project_name')}") $btn .disable() From 9dab692a2be2624ee2dddd6ae54accb2c28e4f93 Mon Sep 17 00:00:00 2001 From: Douglas Barbosa Alexandre Date: Fri, 1 Jul 2016 16:05:39 -0300 Subject: [PATCH 3/3] Update CHANGELOG --- CHANGELOG | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG b/CHANGELOG index ac14af9d2d..2f93fcdbaa 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -37,6 +37,7 @@ v 8.9.5 (unreleased) - Fix assigning shared runners as admins. !4961 - Show "locked" label for locked runners on runners admin. !4961 - Fixes issues importing events in Import/Export. Import/Export version bumped to 0.1.1 + - Fix import button disabled when import process fail due to the namespace already been taken. v 8.9.4 - Fix privilege escalation issue with OAuth external users.