From df25c19699ba35682fd92da2b9c451bb4ba1c775 Mon Sep 17 00:00:00 2001
From: Grzegorz Bizon <grzesiek.bizon@gmail.com>
Date: Tue, 7 Jun 2016 12:58:32 +0200
Subject: [PATCH] Use Ci config validation helpers only where needed

---
 lib/ci/gitlab_ci_yaml_processor.rb            |  2 +-
 lib/gitlab/ci/config/node/before_script.rb    |  2 ++
 lib/gitlab/ci/config/node/entry.rb            |  2 --
 .../ci/config/node/validation_helpers.rb      | 28 +++++++++++++++++++
 lib/gitlab/ci/config/validation_helpers.rb    | 26 -----------------
 5 files changed, 31 insertions(+), 29 deletions(-)
 create mode 100644 lib/gitlab/ci/config/node/validation_helpers.rb
 delete mode 100644 lib/gitlab/ci/config/validation_helpers.rb

diff --git a/lib/ci/gitlab_ci_yaml_processor.rb b/lib/ci/gitlab_ci_yaml_processor.rb
index 4bd2ac4f2d..c2b941a270 100644
--- a/lib/ci/gitlab_ci_yaml_processor.rb
+++ b/lib/ci/gitlab_ci_yaml_processor.rb
@@ -2,7 +2,7 @@ module Ci
   class GitlabCiYamlProcessor
     class ValidationError < StandardError; end
 
-    include Gitlab::Ci::Config::ValidationHelpers
+    include Gitlab::Ci::Config::Node::ValidationHelpers
 
     DEFAULT_STAGES = %w(build test deploy)
     DEFAULT_STAGE = 'test'
diff --git a/lib/gitlab/ci/config/node/before_script.rb b/lib/gitlab/ci/config/node/before_script.rb
index 204e0970a9..586eab12a0 100644
--- a/lib/gitlab/ci/config/node/before_script.rb
+++ b/lib/gitlab/ci/config/node/before_script.rb
@@ -3,6 +3,8 @@ module Gitlab
     class Config
       module Node
         class BeforeScript < Entry
+          include ValidationHelpers
+
           def keys
             {}
           end
diff --git a/lib/gitlab/ci/config/node/entry.rb b/lib/gitlab/ci/config/node/entry.rb
index c07e7cf652..e95bc7bad4 100644
--- a/lib/gitlab/ci/config/node/entry.rb
+++ b/lib/gitlab/ci/config/node/entry.rb
@@ -3,8 +3,6 @@ module Gitlab
     class Config
       module Node
         class Entry
-          include Config::ValidationHelpers
-
           attr_reader :value, :nodes, :parent
 
           def initialize(value, root = nil, parent = nil)
diff --git a/lib/gitlab/ci/config/node/validation_helpers.rb b/lib/gitlab/ci/config/node/validation_helpers.rb
new file mode 100644
index 0000000000..4ea26492b6
--- /dev/null
+++ b/lib/gitlab/ci/config/node/validation_helpers.rb
@@ -0,0 +1,28 @@
+module Gitlab
+  module Ci
+    class Config
+      module Node
+        module ValidationHelpers
+          private
+
+          def validate_array_of_strings(values)
+            values.is_a?(Array) && values.all? { |value| validate_string(value) }
+          end
+
+          def validate_variables(variables)
+            variables.is_a?(Hash) &&
+              variables.all? { |key, value| validate_string(key) && validate_string(value) }
+          end
+
+          def validate_string(value)
+            value.is_a?(String) || value.is_a?(Symbol)
+          end
+
+          def validate_boolean(value)
+            value.in?([true, false])
+          end
+        end
+      end
+    end
+  end
+end
diff --git a/lib/gitlab/ci/config/validation_helpers.rb b/lib/gitlab/ci/config/validation_helpers.rb
deleted file mode 100644
index 9e4e9a8332..0000000000
--- a/lib/gitlab/ci/config/validation_helpers.rb
+++ /dev/null
@@ -1,26 +0,0 @@
-module Gitlab
-  module Ci
-    class Config
-      module ValidationHelpers
-        private
-
-        def validate_array_of_strings(values)
-          values.is_a?(Array) && values.all? { |value| validate_string(value) }
-        end
-
-        def validate_variables(variables)
-          variables.is_a?(Hash) &&
-            variables.all? { |key, value| validate_string(key) && validate_string(value) }
-        end
-
-        def validate_string(value)
-          value.is_a?(String) || value.is_a?(Symbol)
-        end
-
-        def validate_boolean(value)
-          value.in?([true, false])
-        end
-      end
-    end
-  end
-end