From ac906b427ade64e19e34951c49c0be3143252abd Mon Sep 17 00:00:00 2001 From: dosire Date: Mon, 7 Apr 2014 15:08:46 +0200 Subject: [PATCH 1/4] Simplify the contributing process and introduce MRO's. --- PROCESS.md | 29 ++++++++++++++--------------- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/PROCESS.md b/PROCESS.md index 2266d50b23..95e76ff63a 100644 --- a/PROCESS.md +++ b/PROCESS.md @@ -7,24 +7,19 @@ Below we describe the contributing process to GitLab for two reasons. So that co ## Common actions ### Issue team -- Looks for issues without workflow labels and triages issue -- Monitors merge requests -- Closes invalid issues and merge requests with a comment (duplicates, [feature requests](#feature-requests), [fixed in newer version](#issue-fixed-in-newer-version), [issue report for old version](#issue-report-for-old-version), not a problem in GitLab, etc.) -- Assigns appropriate [labels](#how-we-handle-issues) -- Asks for feedback from issue reporter/merge request initiator ([invalid issue reports](#improperly-formatted-issue), [format code](#code-format), etc.) -- Asks for feedback from the relevant developer(s) based on the [list of members and their specialities](https://www.gitlab.com/core-team/) -- Monitors all issues/merge requests for feedback (but especially ones commented on since automatically watching them): +- Looks for issues without [workflow labels](#how-we-handle-issues) and triages issue +- Closes invalid issues with a comment (duplicates, [feature requests](#feature-requests), [fixed in newer version](#issue-fixed-in-newer-version), [issue report for old version](#issue-report-for-old-version), not a problem in GitLab, etc.) +- Asks for feedback from issue reporter ([invalid issue reports](#improperly-formatted-issue), [format code](#code-format), etc.) +- Monitors all issues for feedback (but especially ones commented on since automatically watching them) - Closes issues with no feedback from the reporter for two weeks -- Closes stale merge requests -### Development team +### Merge request officers -- Responds to issues and merge requests the issue team mentions them in -- Monitors for new issues in _Awaiting developer action/feedback_ with no developer activity (once a week) -- Monitors for new merge requests (at least once a week) -- Manages their work queue by looking at issues and merge requests assigned to them -- Close fixed issues (via commit messages or manually) -- Be kind to people trying to contribute. Be aware that people can be a non-native or a native English speaker, they might not understand thing or they might be very sensitive to how your word things. Use emoji to express your feelings (heart, star, smile, etc.). Some good tips about giving feedback to merge requests is in the [Thoughtbot code review guide](https://github.com/thoughtbot/guides/tree/master/code-review). +- Responds to merge requests the issue team mentions them in and monitors for new merge requests +- Provides feedback to the merge request submitter to improve the merge request (style, tests, etc.) +- Marks merge requests 'ready-for-merge' when they meet the contribution guidelines +- Mention developer(s) based on the [list of members and their specialities](https://www.gitlab.com/core-team/) +- Closes merge requests with no feedback from the reporter for two weeks ## Priorities of the issue team @@ -63,6 +58,10 @@ If an issue is complex and needs the attention of a specific person, assignment - Feature request (see copy & paste response: [Feature requests](#feature-requests)) - Support (see copy & paste response: [Support requests and configuration questions](#support-requests-and-configuration-questions) +## Be kind + +Be kind to people trying to contribute. Be aware that people can be a non-native or a native English speaker, they might not understand thing or they might be very sensitive to how your word things. Use emoji to express your feelings (heart, star, smile, etc.). Some good tips about giving feedback to merge requests is in the [Thoughtbot code review guide](https://github.com/thoughtbot/guides/tree/master/code-review). + ## Copy & paste responses ### Improperly formatted issue From 43ecf68af00c18cfddbe155eea49427d896910b2 Mon Sep 17 00:00:00 2001 From: dosire Date: Mon, 7 Apr 2014 15:11:57 +0200 Subject: [PATCH 2/4] Small edit. --- PROCESS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PROCESS.md b/PROCESS.md index 95e76ff63a..7623b26c51 100644 --- a/PROCESS.md +++ b/PROCESS.md @@ -17,7 +17,7 @@ Below we describe the contributing process to GitLab for two reasons. So that co - Responds to merge requests the issue team mentions them in and monitors for new merge requests - Provides feedback to the merge request submitter to improve the merge request (style, tests, etc.) -- Marks merge requests 'ready-for-merge' when they meet the contribution guidelines +- Mark merge requests 'ready-for-merge' when they meet the contribution guidelines - Mention developer(s) based on the [list of members and their specialities](https://www.gitlab.com/core-team/) - Closes merge requests with no feedback from the reporter for two weeks From f64ccc3f5be1f64155ecd3da18a1b549ec66c7c9 Mon Sep 17 00:00:00 2001 From: Drew Blessing Date: Mon, 7 Apr 2014 21:59:13 -0500 Subject: [PATCH 3/4] Change IRC to official --- PROCESS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PROCESS.md b/PROCESS.md index 2266d50b23..f04b5b39a1 100644 --- a/PROCESS.md +++ b/PROCESS.md @@ -79,7 +79,7 @@ Thanks for the issue report but we only support issues for the latest stable ver ### Support requests and configuration questions -Thanks for your interest in GitLab. We don't use the issue tracker for support requests and configuration questions. Please use the \[support forum\]\(https://groups.google.com/forum/#!forum/gitlabhq), \[Stack Overflow\]\(http://stackoverflow.com/questions/tagged/gitlab), the unofficial #gitlab IRC channel on Freenode or the http://www.gitlab.com paid services for this purpose. Have a look at the \[contribution guidelines\]\(https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md) for more information. +Thanks for your interest in GitLab. We don't use the issue tracker for support requests and configuration questions. Please use the \[support forum\]\(https://groups.google.com/forum/#!forum/gitlabhq), \[Stack Overflow\]\(http://stackoverflow.com/questions/tagged/gitlab), the official #gitlab IRC channel on Freenode or the http://www.gitlab.com paid services for this purpose. Have a look at the \[contribution guidelines\]\(https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md) for more information. ### Code format From 688e429094e2ae06d87918f67ced6e0b3303bfbb Mon Sep 17 00:00:00 2001 From: dosire Date: Tue, 8 Apr 2014 09:26:26 +0200 Subject: [PATCH 4/4] Officially supported irc might cause people to expect too much. --- PROCESS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PROCESS.md b/PROCESS.md index 47fd18887d..faa1027a50 100644 --- a/PROCESS.md +++ b/PROCESS.md @@ -78,7 +78,7 @@ Thanks for the issue report but we only support issues for the latest stable ver ### Support requests and configuration questions -Thanks for your interest in GitLab. We don't use the issue tracker for support requests and configuration questions. Please use the \[support forum\]\(https://groups.google.com/forum/#!forum/gitlabhq), \[Stack Overflow\]\(http://stackoverflow.com/questions/tagged/gitlab), the official #gitlab IRC channel on Freenode or the http://www.gitlab.com paid services for this purpose. Have a look at the \[contribution guidelines\]\(https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md) for more information. +Thanks for your interest in GitLab. We don't use the issue tracker for support requests and configuration questions. Please use the \[support forum\]\(https://groups.google.com/forum/#!forum/gitlabhq), \[Stack Overflow\]\(http://stackoverflow.com/questions/tagged/gitlab), the #gitlab IRC channel on Freenode or the http://www.gitlab.com paid services for this purpose. Have a look at the \[contribution guidelines\]\(https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md) for more information. ### Code format