From cee69f8968dd4d6cd3009541ad244b928a24f8d7 Mon Sep 17 00:00:00 2001 From: Stan Hu Date: Wed, 29 Jun 2016 11:22:18 -0700 Subject: [PATCH 1/2] Fix broken migration in MySQL Closes #19344 --- db/migrate/20160616102642_remove_duplicated_keys.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/db/migrate/20160616102642_remove_duplicated_keys.rb b/db/migrate/20160616102642_remove_duplicated_keys.rb index 00a45d7fe7..c66da4e65d 100644 --- a/db/migrate/20160616102642_remove_duplicated_keys.rb +++ b/db/migrate/20160616102642_remove_duplicated_keys.rb @@ -9,7 +9,7 @@ class RemoveDuplicatedKeys < ActiveRecord::Migration AND id != ( SELECT id FROM ( SELECT max(id) AS id - FROM keys + FROM #{quote_table_name(:keys)} WHERE fingerprint = #{fingerprint} ) max_ids ) From 094cd21c30513346379fc6e0668f203548b05a92 Mon Sep 17 00:00:00 2001 From: Stan Hu Date: Wed, 29 Jun 2016 13:09:27 -0700 Subject: [PATCH 2/2] Fix missing quote_table_name --- db/migrate/20160616102642_remove_duplicated_keys.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/db/migrate/20160616102642_remove_duplicated_keys.rb b/db/migrate/20160616102642_remove_duplicated_keys.rb index c66da4e65d..180a75e099 100644 --- a/db/migrate/20160616102642_remove_duplicated_keys.rb +++ b/db/migrate/20160616102642_remove_duplicated_keys.rb @@ -4,7 +4,7 @@ class RemoveDuplicatedKeys < ActiveRecord::Migration select_all("SELECT fingerprint FROM #{quote_table_name(:keys)} GROUP BY fingerprint HAVING COUNT(*) > 1").each do |row| fingerprint = connection.quote(row['fingerprint']) execute(%Q{ - DELETE FROM keys + DELETE FROM #{quote_table_name(:keys)} WHERE fingerprint = #{fingerprint} AND id != ( SELECT id FROM (