diff --git a/lib/gitlab/markdown.rb b/lib/gitlab/markdown.rb
index f230201543..37b250d353 100644
--- a/lib/gitlab/markdown.rb
+++ b/lib/gitlab/markdown.rb
@@ -1,5 +1,4 @@
require 'html/pipeline'
-require 'html/pipeline/gitlab'
module Gitlab
# Custom parser for GitLab-flavored Markdown
@@ -61,19 +60,24 @@ module Gitlab
reference_only_path: true
)
- markdown_context = {
+ pipeline = HTML::Pipeline.new(filters)
+
+ context = {
+ # SanitizationFilter
+ whitelist: sanitization_whitelist,
+
+ # EmojiFilter
asset_root: Gitlab.config.gitlab.url,
asset_host: Gitlab::Application.config.asset_host,
- whitelist: sanitization_whitelist,
- reference_class: html_options[:class],
- only_path: options[:reference_only_path],
+
+ # ReferenceFilter
current_user: current_user,
- project: project
+ only_path: options[:reference_only_path],
+ project: project,
+ reference_class: html_options[:class]
}
- markdown_pipeline = HTML::Pipeline::Gitlab.new(filters).pipeline
-
- result = markdown_pipeline.call(text, markdown_context)
+ result = pipeline.call(text, context)
save_options = 0
if options[:xhtml]
@@ -91,7 +95,7 @@ module Gitlab
private
- # Custom filters for html-pipeline:
+ # Filters used in our pipeline
#
# SanitizationFilter should come first so that all generated reference HTML
# goes through untouched.
@@ -101,6 +105,8 @@ module Gitlab
[
HTML::Pipeline::SanitizationFilter,
+ Gitlab::Markdown::EmojiFilter,
+
Gitlab::Markdown::UserReferenceFilter,
Gitlab::Markdown::IssueReferenceFilter,
Gitlab::Markdown::ExternalIssueReferenceFilter,
@@ -109,8 +115,6 @@ module Gitlab
Gitlab::Markdown::CommitRangeReferenceFilter,
Gitlab::Markdown::CommitReferenceFilter,
Gitlab::Markdown::LabelReferenceFilter,
-
- HTML::Pipeline::Gitlab::GitlabEmojiFilter
]
end
diff --git a/spec/helpers/gitlab_markdown_helper_spec.rb b/spec/helpers/gitlab_markdown_helper_spec.rb
index 315e91d4f3..60e000b4dd 100644
--- a/spec/helpers/gitlab_markdown_helper_spec.rb
+++ b/spec/helpers/gitlab_markdown_helper_spec.rb
@@ -10,15 +10,12 @@ describe GitlabMarkdownHelper do
end
let!(:project) { create(:project) }
- let(:empty_project) { create(:empty_project) }
let(:user) { create(:user, username: 'gfm') }
let(:commit) { project.repository.commit }
- let(:earlier_commit){ project.repository.commit("HEAD~2") }
let(:issue) { create(:issue, project: project) }
let(:merge_request) { create(:merge_request, source_project: project, target_project: project) }
let(:snippet) { create(:project_snippet, project: project) }
- let(:member) { project.project_members.where(user_id: user).first }
# Helper expects a current_user method.
let(:current_user) { user }
@@ -60,53 +57,6 @@ describe GitlabMarkdownHelper do
end
end
- # TODO (rspeicher): These tests belong in the emoji filter spec
- describe "emoji" do
- it "matches at the start of a string" do
- expect(gfm(":+1:")).to match(/
big time/)
- end
-
- it "ignores invalid emoji" do
- expect(gfm(":invalid-emoji:")).not_to match(/![]()