Timothy Andrew
d8d5424d25
Use the GLDropdown component to select protected branches.
...
1. Modify the component to support a callback for every key press in the
filter. We need this so we can update the "Create: <branch_name"
label.
2. Modify the component to use `$(<selector>).first().click()` instead
of `$(selector)[0].click()`, because the latter is non-standard, and
doesn't work in PhantomJS.
2016-07-07 10:07:05 +05:30
Jacob Schatz
c051630aa8
Merge branch 'search-input-blur' into 'master'
...
Fixed search field blur not removing focus
## What does this MR do?
Adds a blur event to remove focus styling from the search input.
Any particular reason we were looking for clicks on the document? I can't see why we would be.
## What are the relevant issue numbers?
Closes #18670
## Screenshots (if relevant)
See merge request !4704
2016-06-29 19:22:08 +00:00
Jacob Schatz
bcebdee751
Merge branch '18942-dropdowns-should-apply-any-present-filter-once-data-is-loaded' into 'master'
...
Fixed dropdown not filtering queries entered before data is loaded
## What does this MR do?
Triggers a 'keyup' event on a filters input to force it to process any text that was added before the data was retrieved and rendered.
## Are there points in the code the reviewer needs to double check?
😕
## Why was this MR needed?
UX
## What are the relevant issue numbers?
Closes #18942 .
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG ) entry added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md )
- [ ] API support added
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides )
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits )
See merge request !4846
2016-06-28 20:02:52 +00:00
Jacob Schatz
d61c69f450
Merge branch '18536_status_dropdown_label' into 'master'
...
Set button label when picking an option from status dropdown
## What does this MR do?
Fixes an issue with the status dropdown. It was not setting up the correct label after picking an option
## What are the relevant issue numbers?
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/18536
## Screenshots (if relevant)
**Previous**
**After**
## Does this MR meet the acceptance criteria?
- [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG ) entry added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md )
- [ ] API support added
- [ ] Tests
- [ ] Added for this feature/bug
- [x] All builds are passing
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides )
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits )
See merge request !4771
2016-06-23 21:42:04 +00:00
Phil Hughes
92c71a426c
Updated to add parentheses
2016-06-22 17:32:06 +01:00
Phil Hughes
363f7a5794
Empty the content before append anything to the dropdown
2016-06-22 08:59:03 +01:00
Phil Hughes
5a09745534
Use jQuery objects in ref dropdown
2016-06-22 08:43:54 +01:00
Luke "Jared" Bennett
0b33f90b8c
forced filter input to process inputs after data has loaded
2016-06-22 02:41:38 +01:00
Phil Hughes
1ba09307ab
Checks for relatedTarget
...
If related target is undefined then we can't complete the below code
2016-06-20 11:55:59 +01:00
Phil Hughes
c9cc64f565
Fixed issue with focusing out of dropdown not hiding menu
2016-06-20 11:55:59 +01:00
Phil Hughes
f112e2a1da
Fixed issue with returning ref in commits JSON
...
Added tests to project controller
2016-06-20 11:37:27 +01:00
Phil Hughes
deca5ef200
Refs dropdown is now loaded async
2016-06-18 21:49:20 +01:00
Alfredo Sumaran
9b777f4187
Pass dropdown instance to toggleLabel callback
2016-06-17 19:09:14 -05:00
Alfredo Sumaran
9d96b9eb27
Fixes icon state when selecting issues that have the same labels assigned
2016-06-16 16:56:58 -05:00
Phil Hughes
d3ff691d76
Fixed issue with dropdown toggle not updating
...
Added tests
2016-06-08 11:45:17 +01:00
Alfredo Sumaran
22b8b9a7f3
Address feedback
2016-06-03 17:14:23 -05:00
Alfredo Sumaran
5ea0165175
Enhancements
2016-06-03 17:14:23 -05:00
Alfredo Sumaran
0be26a47f2
Do not trigger keyup event if we are persisting state
...
Triggering keyup will re-render the dropdown which is not needed when option persistWhenHide is true
2016-06-03 17:14:23 -05:00
Alfredo Sumaran
9df4da4bc0
Remove unneeded call to keyup event
...
This was re-rendering the dropdown unnecessarily
2016-06-03 17:14:23 -05:00
Alfredo Sumaran
5d7445198f
Only filter asynchronously if option remote is true.
...
We need to update the results right away when we do bulk assignment.
2016-06-03 17:14:23 -05:00
Alfredo Sumaran
d8aaf018ac
Handle unchecking of indeterminate items
2016-06-03 17:11:41 -05:00
Alfredo Sumaran
6974d970b4
typo
2016-06-03 17:10:20 -05:00
Alfredo Sumaran
4ab6bfcef5
Set indeterminated items
2016-06-03 17:10:20 -05:00
Phil Hughes and Jacob Schatz
317cfcbd4d
Fixed issue with search autocomplete not allow arrow key navigation
...
Closes #15649
2016-06-03 12:48:49 -04:00
Jacob Schatz
98b1daf32d
Merge branch 'dropdown-enter-select' into 'master'
...
Fixed issue with enter key selecting wrong option in dropdown
If you search for a label and press enter the dropdown will select the last element rather than the first. This is because the currentIndex is -1 rather than 0
Closes #17630
See merge request !4210
2016-05-21 00:11:18 +00:00
Alfredo Sumaran
ab96ca2bf1
Dropdown implementation
2016-05-20 15:58:36 -05:00
Alfredo Sumaran
1f5fcb638d
Dropdown implementation
2016-05-20 15:58:36 -05:00
Phil Hughes
9f60a2eda2
Fixed issue with enter key selecting wrong option in dropdown
...
If you search for a label and press enter the dropdown will select the last element rather than the first. This is because the currentIndex is -1 rather than 0
Closes #17630
2016-05-20 08:50:42 +01:00
Phil Hughes
df0cdc8cb4
Escape key closes the dropdown
...
Fixes #15432
2016-04-26 09:06:22 +01:00
Alfredo Sumaran
7e0ef892f4
Merge remote-tracking branch 'origin/master' into label-dropdown-fix
2016-04-20 17:10:10 -05:00
Jacob Schatz
692c35e6f4
Merge branch 'multi-filter-labels' into 'master'
...
Mutliple label filter
Fixes #989
See merge request !3438
2016-04-20 19:18:32 +00:00
Alfredo Sumaran
7b6fe0e259
Merge remote-tracking branch 'origin/master' into label-dropdown-fix
...
# Conflicts:
# app/views/shared/issuable/_sidebar.html.haml
2016-04-20 11:40:55 -05:00
Phil Hughes
439a72803b
Any label & no label out weigh other labels - these two will clear previously selected labels
...
Fixed issue with no label not working correctly
2016-04-20 17:23:10 +01:00
Phil Hughes
d1b2e7b440
Trigger filtering after ajax is complete in dropdown
...
Closes #15186
2016-04-19 10:26:07 +01:00
Alfredo Sumaran
5c7181b514
Add is-link attribute to know if a menu item should not be stopped
2016-04-18 14:37:18 -05:00
Phil Hughes
ea71145418
Fixed issue with multi select not working with arrow keys
2016-04-18 16:45:49 +01:00
Alfredo Sumaran
0556d661e0
Fix Label dropdown and organize code
...
# Conflicts:
# app/assets/javascripts/labels_select.js.coffee
2016-04-15 12:24:15 -05:00
Phil Hughes and Jacob Schatz
dca50ac1d4
Project dropdown in header uses new dropdown
2016-04-12 13:10:43 -04:00
Jacob Schatz
69a8bf367c
Merge branch 'mr-ui-update' into 'master'
...
Updated UI for new merge request
Closes #2540
See merge request !3228
2016-04-11 11:25:40 +00:00
Phil Hughes
643fe43d78
Addressed feedback
...
Removed important from css
2016-04-11 09:43:59 +01:00
Jacob Schatz
b6d5fcd477
Merge branch 'issue_14800' into 'master'
...
Search Design fixes
Closes #14800
- Use colors according to design
- Fix width of search input
See merge request !3475
2016-04-06 21:26:56 +00:00
Phil Hughes
beab104da8
Filters by text on element
2016-04-06 11:08:40 +01:00
Phil Hughes
b310058998
Use new dropdowns for MR compare
2016-04-06 11:08:40 +01:00
Phil Hughes
d6f276eacf
Fixed issue with enter key not selecting correct value in dropdown
2016-04-06 10:05:39 +01:00
Alfredo Sumaran
7baebd3220
Do not create input if fieldName is not defined
2016-04-05 19:18:34 -05:00
Jacob Schatz
a1c794c591
Merge branch 'dropdown-arrow-support' into 'master'
...
Dropdown arrow support
When the dropdown is open, you can scroll through the list of items with the up & down arrow keys. When an item is focused, the enter triggers the click event for that row.
Closes #14455
See merge request !3385
2016-04-05 19:41:22 +00:00
Phil Hughes
8e3f5ebaa0
CS multiline
2016-04-05 09:07:40 +01:00
Alfredo Sumaran
51b8b8711b
Merge branch 'master' into issue_14800
...
# Conflicts:
# app/assets/stylesheets/framework/variables.scss
2016-04-04 20:06:29 -05:00
Rémy Coutable
de1c81645c
Merge branch 'filter-dropdown-bug' into 'master'
...
Fixes issue with dropdowns not selecting values
Fixes issue with dropdowns not selecting when navigating between tabs
Closes #14813
See merge request !3478
2016-04-01 08:49:27 +00:00
Alfredo Sumaran
ab42560ea6
Return selected object if toggleLabel option is not defined
2016-03-31 19:28:41 -05:00
Timothy Andrew
Jacob Schatz
Phil Hughes
Luke "Jared" Bennett
Alfredo Sumaran
Rémy Coutable