Rémy Coutable
bd78f5733c
Exclude requesters from Project#members, Group#members and User#members
...
And create new Project#requesters, Group#requesters scopes.
Signed-off-by: Rémy Coutable <remy@rymai.me >
2016-07-01 17:44:46 +02:00
Rémy Coutable
654565c9dc
Raise a new Gitlab::Access::AccessDeniedError when permission is not enough to destroy a member
...
This is a try for a new approach to put the access checks at the service level.
Signed-off-by: Rémy Coutable <remy@rymai.me >
2016-06-18 06:06:34 +02:00
Rémy Coutable
724f986fb2
Redirect to the member's source on request withdrawal
...
Signed-off-by: Rémy Coutable <remy@rymai.me >
2016-06-18 05:46:45 +02:00
Rémy Coutable
4652489f40
New Members::DestroyService
...
This is to ensure we don't send unwanted notifications when deleting a
project. In other words, stop abusing AR callbacks and use services.
Signed-off-by: Rémy Coutable <remy@rymai.me >
2016-06-18 05:46:45 +02:00
Rémy Coutable
515205d3c1
UI and copywriting improvements
...
+ Move 'Edit Project/Group' out of membership-related partial
+ Show the access request buttons only to logged-in users
+ Put the request access buttons out of in a more visible button
+ Improve the copy in the #remove_member_message helper
Signed-off-by: Rémy Coutable <remy@rymai.me >
2016-06-14 13:18:14 +02:00
Rémy Coutable
d75edf1a98
Factorize access request routes into a new :access_requestable route concern
...
Signed-off-by: Rémy Coutable <remy@rymai.me >
2016-06-14 13:07:26 +02:00
Rémy Coutable
d71fbe0dbd
Factorize #request_access and #approve_access_request into a new AccessRequestActions controller concern
...
Signed-off-by: Rémy Coutable <remy@rymai.me >
2016-06-14 13:07:26 +02:00
Douwe Maan
4d4a9b7c8a
Merge branch 'notes-are-awardables' into 'master'
...
Notes are awardables
## What does this MR do?
Makes sure we can :thunder_cloud_rain: comments/notes.
## What are the relevant issue numbers?
Follows up upon !2901 , depends on !3785
Closes #3655
## Screenshots (if relevant)
TODO
See merge request !4291
2016-06-06 16:48:35 +00:00
ZJ van de Weg
2f9c2149a3
Backend awardables on comments
2016-06-06 11:03:39 +02:00
Timothy Andrew
86b07caa59
Implement authentication (login) using a U2F device.
...
- Move the `authenticate_with_two_factor` method from
`ApplicationController` to the `AuthenticatesWithTwoFactor` module,
where it should be.
2016-06-06 12:50:31 +05:30
Fatih Acet
6c89e2fd41
Merge branch 'awardables' of gitlab.com:gitlab-org/gitlab-ce into awardables
2016-05-18 13:23:40 -05:00
Fatih Acet
bb883387f9
Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ce into awardables
...
# Conflicts:
# app/controllers/projects/merge_requests_controller.rb
# app/models/note.rb
# db/schema.rb
# spec/models/note_spec.rb
2016-05-18 13:05:53 -05:00
Dmitriy Zaporozhets
253a017b01
Merge branch 'meinac/gitlab-ce-change_deprecated_render_usage'
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2016-05-18 12:48:23 -05:00
ZJ van de Weg
e0cabb67d0
Fix latests concerns
2016-05-18 08:47:15 -05:00
Gabriel Mazetto
f5a0ac0fc1
Codestyle: make sure we have space around operators
2016-05-13 04:46:56 -03:00
Zeger-Jan van de Weg
7e6dcf9cd0
Merge branch 'master' into awardables
2016-05-11 08:47:04 +02:00
Zeger-Jan van de Weg
3bdc57f0a7
Create table for award emoji
2016-05-06 10:47:11 +02:00
Alfredo Sumaran
3f574c4db9
Use compact syntax
2016-04-21 16:02:00 -05:00
Alfredo Sumaran
ded5efad1f
Allow filtering by Owned projects
2016-04-18 17:32:47 -05:00
Rémy Coutable
e989d12b07
Use respond_to instead of a conditional to paginate milestones
2016-03-23 12:02:15 +01:00
Rémy Coutable
7dc16346bb
Fix an issue causing the Dashboard/Milestones page to be blank
2016-03-23 12:02:15 +01:00
Zeger-Jan van de Weg
6e5461c6ee
Merge branch 'master' into 2489-soft-delete-issues
2016-03-21 19:32:37 +01:00
Zeger-Jan van de Weg
3b088fc5b5
Minor improvements on IssuableActions
2016-03-21 16:59:35 +01:00
Robert Speicher
085538c2bd
Use the configured Kaminari "per page" default
2016-03-19 17:37:54 -04:00
Zeger-Jan van de Weg
98fd60f50b
Satisfy rubocop
2016-03-19 22:05:45 +01:00
Zeger-Jan van de Weg
7342a4566c
Dry destroy action on issuables
2016-03-19 21:24:05 +01:00
Mehmet Emin İNAÇ
6a0ea605e8
Change deprecated usage of rendering without response body
...
`render nothing: true` has been deprecated.
For more information see [pr](https://github.com/rails/rails/pull/20336 )
2016-03-16 03:16:25 +02:00
Rémy Coutable
e90d6ec1d8
Create a SentNotification record for #relabeled_issue_email / #relabeled_merge_request_email
2016-03-15 18:36:54 +01:00
Zeger-Jan van de Weg
5352ec2e21
Fix denting and spec
2016-03-13 13:44:31 +01:00
Zeger-Jan van de Weg
dfb96ed84b
ContinueToParams -> ContinueParams
2016-03-13 13:13:19 +01:00
Zeger-Jan van de Weg
1cefb73a9c
Check redirect path in the continue_params
...
Fixes
https://dev.gitlab.org/gitlab/gitlabhq/issues/2649
https://gitlab.com/gitlab-org/gitlab-ce/issues/13956
2016-03-13 13:13:19 +01:00
Dmitriy Zaporozhets
acb211215c
Add option to show archived projects on dahsboard
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2016-03-04 19:25:28 +01:00
Rubén Dávila
b41a274b62
Don't list merge requests from archived projects in Group view.
2016-03-02 12:51:29 -05:00
Rubén Dávila
0b86b46a2c
Don't list issues from archived projects in Group view.
2016-03-02 12:51:29 -05:00
Douwe Maan
31682eb987
Merge branch 'visibletrap/gitlab-ce-label'
2016-02-19 17:54:13 -08:00
Rubén Dávila and Robert Speicher
cc5ff3b5a4
Use the adequate success path on the JSON endpoint.
...
I forgot to update this and some spinach specs were failing.
2016-02-19 13:15:43 -05:00
Rubén Dávila and Robert Speicher
b8295fc323
Fix build and add specs
2016-02-19 13:14:53 -05:00
Rubén Dávila and Robert Speicher
328b52d58a
Some updates after last code review.
2016-02-19 13:14:52 -05:00
Rubén Dávila and Robert Speicher
38e708f0ce
Add link to fork if user can't revert MR.
2016-02-19 13:14:52 -05:00
Rubén Dávila and Robert Speicher
b36319a17c
Make MRs with revert commit work.
2016-02-19 13:14:50 -05:00
Tap
44a9e26049
Find label in issues_finder
2016-02-19 13:50:47 +08:00
Tap
2e81b1558b
Label description and Label row
...
- Add label description
- Show label row when filtering issues or merge requests by label
2016-02-17 21:52:12 +08:00
Douwe Maan
9369b7ec1f
Fix MR diff 'Edit' button
2016-01-21 22:46:49 +01:00
Douwe Maan
d9c82d679f
Automatically fork a project when not allowed to edit a file.
2015-12-18 10:03:34 +01:00
Greg Smethells
dbbd2b863b
sort milestones by due_date
2015-12-03 08:53:34 -06:00
Douwe Maan
e86d53b27f
Merge branch 'master' into dirceu/gitlab-ce-new-merge-request-from-file-edit
2015-11-18 11:17:20 +01:00
Douwe Maan
e945ec0280
Add "Start a new merge request" option to every commit form
2015-11-17 18:53:56 +01:00
Dmitriy Zaporozhets
3cebe9e780
Refactor duplciate code for groups_controller.rb and slack_service/note_message.rb
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-11-17 11:03:18 +01:00
Dmitriy Zaporozhets
986695e136
Refactor global and group milestones logic
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-11-16 14:07:38 +01:00
Robert Speicher
c802d8eee1
Refactor SessionsController to use a controller concern
2015-05-14 14:24:05 -04:00