Valery Sizov
3baed8cb6d
Services: code style fixes, minor refactoring
2016-07-06 20:58:43 +03:00
Grzegorz Bizon
9e211091a8
Enable Style/EmptyLines cop, remove redundant ones
2016-07-01 21:56:17 +02:00
Sean McGivern and Alfredo Sumaran
165d799fb3
Allow bulk-updating to remove all labels
...
Instead of passing `remove_label_ids`, just pass an empty array for
`label_ids` (and don't pass `add_label_ids` or `remove_label_ids`).
2016-06-03 17:14:23 -05:00
Sean McGivern and Alfredo Sumaran
81a21c945e
WIP: allow adding and removing labels in bulk
2016-06-03 17:11:41 -05:00
Z.J. van de Weg
77d4d5e3a6
🚓
2016-06-03 16:35:56 +02:00
Z.J. van de Weg
fab695461a
Move awardables too when issue is moved
2016-06-01 18:33:49 +02:00
Rémy Coutable
0698113cab
Move #create_confidentiality_note to Issues::UpdateService
...
Signed-off-by: Rémy Coutable <remy@rymai.me >
2016-05-18 17:43:40 -05:00
Alex Moore-Niemi and Rémy Coutable
483c034b86
Changing the confidentiality of an issue now creates a new system note
...
Signed-off-by: Rémy Coutable <remy@rymai.me >
2016-05-18 00:27:31 -05:00
Long Nguyen
91f693c0c4
Update changelog, improve specs
2016-05-05 13:59:09 +07:00
Long Nguyen
f7844a11be
Code refactor and fix broken spec
2016-04-28 15:52:23 +07:00
Long Nguyen
247ae96055
Allow to assign labels and milestone to target project when moving issue
2016-04-26 23:20:19 +07:00
Rémy Coutable
02cfbf0db5
Refactor and expose only Gitlab::UrlBuilder.build(record)
...
Signed-off-by: Rémy Coutable <remy@rymai.me >
2016-04-13 16:07:04 +02:00
Grzegorz Bizon
e64b1e52a2
Check if GFM rewriters need rewrite internally
2016-03-30 10:44:18 +02:00
Grzegorz Bizon
f2674c7b98
Refactor uploads rewriter used when moving issue
2016-03-30 10:44:18 +02:00
Grzegorz Bizon
701976e081
Add uploads rewriter and use it when moving issue
2016-03-30 10:44:18 +02:00
Grzegorz Bizon
bab50e0133
Preserve time notes has been updated at when moving issue
2016-03-23 13:22:27 +01:00
Grzegorz Bizon
915bfedfa7
Do not allow to move issue if it has not been persisted
2016-03-23 09:41:39 +01:00
Grzegorz Bizon
d6474f22d2
Preserve created at time of notes when moving issue
2016-03-20 17:05:21 +01:00
Grzegorz Bizon
323d328c86
Rename reference unfolder to rewriter, minor refactorings
2016-03-20 10:14:25 +01:00
Grzegorz Bizon
18f25bc942
Update reference unfolder according to recent ability changes
...
Commit 43d8bdb4f0 introduced additional
checks for permissions to read issue in references extractor.
2016-03-19 18:58:52 +01:00
Grzegorz Bizon
9b13ce0b7a
Improvements in issue move feaure (refactoring)
...
According to endbosses' suggestions.
2016-03-19 18:46:01 +01:00
Grzegorz Bizon
b9036ba610
Prevent issue move if issue has been already moved
2016-03-17 11:48:51 +01:00
Grzegorz Bizon
5e405bfea9
Update methods that use issue close service
...
`Issues::CloseService#execute` signature has changed, because of using
keyword parameter for commmit.
2016-03-17 09:54:16 +01:00
Grzegorz Bizon
5e3c9475a9
Add minor improvements in code related to issue move
2016-03-17 07:39:16 +01:00
Grzegorz Bizon
15d32b6a11
Add new notifications for issue move action
...
[ci skip]
2016-03-17 07:39:16 +01:00
Grzegorz Bizon
a23f0e8c9e
Reuse existing issue services when moving issue
2016-03-17 07:39:16 +01:00
Grzegorz Bizon
93812f2594
Add initial notifications and hooks for issue move
2016-03-17 07:39:16 +01:00
Grzegorz Bizon
bcd5806960
Add access-level filter support for projects select
...
This also refactores ProjectSelect adding some decorator-like functions.
2016-03-17 07:39:16 +01:00
Grzegorz Bizon
a91101b19a
Make it possible to move issue if user is a reporter
...
Discussed it here:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/2831#note_4190228
2016-03-17 07:39:16 +01:00
Grzegorz Bizon
310b417b0f
Preserve original author when moving issue
...
This also wrapps entire process into transation, as rewriting references
may have large memory footprint.
2016-03-17 07:39:16 +01:00
Grzegorz Bizon
fd8394faae
Move reference unfolder for GFM to separate class
2016-03-17 07:39:15 +01:00
Grzegorz Bizon
9124ebce98
Use internal reference extractor in banzai unfold pipeline
2016-03-17 07:39:15 +01:00
Grzegorz Bizon
3c493c24c7
Add reference unfold pipeline used when moving issue
2016-03-17 07:39:15 +01:00
Grzegorz Bizon
efd8251751
Minor refactoring of issue move service and specs
2016-03-17 07:39:15 +01:00
Grzegorz Bizon
c2d4060f26
Rewrite references in notes when moving issue
2016-03-17 07:39:15 +01:00
Grzegorz Bizon
8d3f072ec4
Take care about data being rewritten when moving issue
2016-03-17 07:39:15 +01:00
Grzegorz Bizon
fbb5a8b089
Use a new issue create service when moving an issue
2016-03-17 07:39:15 +01:00
Grzegorz Bizon
57eb395488
Do not pass unsanitized params to issue move service
2016-03-17 07:39:15 +01:00
Grzegorz Bizon
4cbe87d50e
Rewrite references in issue description when moving it
2016-03-17 07:39:15 +01:00
Grzegorz Bizon
5ed8a1e107
Silently close old issue when it has been moved
2016-03-17 07:39:15 +01:00
Grzegorz Bizon
8d1b7f9507
Add issue move ability and use it in move service
2016-03-17 07:39:15 +01:00
Grzegorz Bizon
14c983fb69
Add implementation that rewrites issue notes when moving
2016-03-17 07:39:15 +01:00
Grzegorz Bizon
c8e7d1ed8e
Add issue move implementation to controller
2016-03-17 07:39:15 +01:00
Grzegorz Bizon
9882802a8b
Improve system notes that are added when issue is moved
2016-03-17 07:39:15 +01:00
Grzegorz Bizon
69b89d4ec8
Add new system note used when issue has been moved
2016-03-17 07:39:15 +01:00
Grzegorz Bizon
b53d9f8a0e
Add scaffold of service that moves issue to another project
2016-03-17 07:39:15 +01:00
Rémy Coutable
54ec7e9599
Improving the original label-subscribing implementation
...
1. Make the "subscribed" text in Issuable sidebar reflect the labels
subscription status
2. Current user mut be logged-in to toggle issue/MR/label subscription
2016-03-15 18:22:02 +01:00
Timothy Andrew and Rémy Coutable
0444fa560a
Original implementation to allow users to subscribe to labels
...
1. Allow subscribing (the current user) to a label
- Refactor the `Subscription` coffeescript class
- The main change is that it accepts a container, and conducts all
DOM queries within its scope. We need this because the labels
page has multiple instances of `Subscription` on the same page.
2. Creating an issue or MR with labels notifies users subscribed to those labels
- Label `has_many` subscribers through subscriptions.
3. Adding a label to an issue or MR notifies users subscribed to those labels
- This only applies to subscribers of the label that has just been
added, not all labels for the issue.
2016-03-15 17:25:37 +01:00
Douglas Barbosa Alexandre
3d52e139b1
Rename Tasks to Todos
2016-02-20 12:39:27 -02:00
Douglas Barbosa Alexandre
408e010d65
Rename IssuableBaseService#have_changes? to has_changes?
2016-02-20 12:12:05 -02:00