Emphasize the meaningful informations, and remove the less needed ones:
* Use "!" to identify a merge request
* Write the name of the commented file for diff notes
* Don't show the assignee in the "merged merge request" email
* Less margin: the content appears as the text of the message.
* Streamlined footer: everything on one line, with a small separator.
* Zimbra (www.zimbra.com) chokes on HTML tables, and doesn't display
the content of the message. Switching to a simpler layout fixes the
issue.
Rationale:
* In this notification email, the message is the most important content.
It should not be dimmed or smaller than the rest of the text.
* Now that all UI elements are removed, the message *is* the email. It
should be written as a standard email message, without styling.
Rationale:
* Consistency: the link is always at the same place.
* Streamlining: it allows to remove the header banner, now that the
project url can be accessed from another place.
Every email has a different way of showing a link to the discussion on
the website. We don't need this anymore, as we now have a standard
"View in GitLab" link in the footer of every email.
When an email notification concerns a specific object (issue, note,
merge request, etc.), add a link to the footer of the email that opens
the item's page in a web browser.
Rationale:
* The link is predictable: always the same text, always at the same
location, like any reliable tool.
* It allows to remove the inline-title in many emails, and leave only
the actual content of the message.
If you cancel edit you will be redirected back to merge request
If you submit changes you will be redirected back to merge request
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
Public Groups
This is the initial work (meaning no tests) for making groups public if they have a public project (or internal for logged in users). This allows issues and merge requests to be viewed, but _not_ group membership. As part of this I have also added back the link in the public project title section (it was removed as it didn't make sense before).
This addesses the following suggestions/issues:
http://feedback.gitlab.com/forums/176466-general/suggestions/5314461-groups-containing-one-or-more-public-projects-shou
Issue #32https://github.com/gitlabhq/gitlabhq/issues/5203
as well as a few closed issues.
This also changes the public user page to only show groups that are accessible to the user in some manner.
It will redirect you to file edit page.
After submit changes you will be redirected back to merge request.
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
Ryan Mendivil
Jeroen van Baarsen
Tyler Sommer
Javier Castro
Dmitriy Zaporozhets
Pierre de La Morinerie
dosire
skv-headless
Jacob CarlborgandJacob Carlborg
David Pursehouse
Sebastian Winkler
Jason Hollingsworth