Commit Graph
8955 Commits
Author SHA1 Message Date
Dmitriy Zaporozhets c378d20c84 Cache lookup results into hash to prevent repeating same requests to git repo 2015-03-21 13:44:51 -07:00
Dmitriy Zaporozhets 2c796a1785 Cache project branches and tags into variables 2015-03-21 13:44:11 -07:00
Dmitriy Zaporozhets b624b775aa Hide UI elements when print md files or wiki pages 2015-03-21 12:13:47 -07:00
Sander Boom 8ec075f97b When we want to see the fullsize avatar of a user we can click the avatar on the profile page and the fullsize version will be opened in a new window/tab. 2015-03-21 16:15:14 +01:00
Vinnie Okada f5e65e2e50 Merge branch 'master' into markdown-tags
Merge updated CHANGELOG entries
2015-03-21 09:03:35 -06:00
Vinnie Okada 1dc90fc455 Fix nested task lists
When nesting task list items, the parent item is wrapped in a `<p>` tag.
Update the task list parser to handle these paragraph wrappers.
2015-03-21 08:45:28 -06:00
Kamil Trzcinski 5b432e7671 Extend push_tag event to include tag message and last commit 2015-03-21 11:25:27 +01:00
Dmitriy Zaporozhets 6cf189f0a9 Merge branch 'improve-avatar-header' into 'master'
Improve header with avatar for group and user pages

Nice looking and aligned headers for user and group pages

See merge request !412
2015-03-21 04:30:57 +00:00
Dmitriy Zaporozhets 222e53a026 Prevent diff header overflow 2015-03-20 20:46:04 -07:00
Dmitriy Zaporozhets beece83af1 Improve header with avatar for group and user pages 2015-03-20 20:15:13 -07:00
Dmitriy Zaporozhets f0d052b6e7 Merge branch 'user-location' into 'master'
Location field in user profile

Twitter allows you to set string with location information.
I find it very useful in work to know where user from. It allows to communicate with knowing time difference and cultural things.

See merge request !411
2015-03-21 00:54:03 +00:00
Dmitriy Zaporozhets d85f396fe5 Add location to user page 2015-03-20 16:55:20 -07:00
Dmitriy Zaporozhets 6ef20926ee Add location to user profile 2015-03-20 16:52:23 -07:00
Dmitriy Zaporozhets 5738afdb12 Merge branch 'link_to_ci_with_ref' into 'master'
Link to CI with ref

gitlab/gitlab-ci#162

!!! Should be merged simultaneously with https://dev.gitlab.org/gitlab/gitlab-ci/merge_requests/129

See merge request !1638
2015-03-20 22:42:32 +00:00
Dmitriy Zaporozhets 9f9fed4fa2 Fix votes inline rendering 2015-03-20 15:34:29 -07:00
Dmitriy Zaporozhets b0e2441330 Improve issue sidebar position 2015-03-20 15:33:13 -07:00
Dmitriy Zaporozhets efb8783c4a Merge branch 'upvotes-refactoring' into 'master'
Make issue and merge request sidebar more compact

* move votes block to participants
* make smaller font in sidebar
* remove js for upvoting since it differs from logic on backend and does not work correctly

Fixes #1253

Tested on different screens: HD, 1366x768, 1024x600

See merge request !410
2015-03-20 20:17:51 +00:00
Dmitriy Zaporozhets baaa560290 Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ce 2015-03-20 13:16:51 -07:00
Dmitriy Zaporozhets 65b392c394 Merge branch 'merge-status-transition' into 'master'
Update merge_status state to allow more transitions

Previously you could only transition from the unchecked state to one of the others. This meant that the mark_as_unmerged call in AutoMergeService would rarily be able to actually transition the state. As it would usually have already been set to can_be_merged before it hit that service.

Spec and Spinach tests have been run locally and all pass.

See merge request !405
2015-03-20 20:11:04 +00:00
Dmitriy Zaporozhets 085e5084a8 Make issue and merge request sidebar more compact
* move votes block to participants
* make smaller font in sidebar
2015-03-20 12:50:45 -07:00
Dmitriy Zaporozhets 1f711fd93d Remove upvotes js logic since it does not work as expected anyway 2015-03-20 12:34:21 -07:00
Dmitriy Zaporozhets d735321ebd Improve project name truncation on dashboard to work well with sm screen 2015-03-20 11:32:44 -07:00
Valery Sizov e5fe14b2fb Link to CI with ref 2015-03-20 19:19:29 +02:00
Vinnie Okada 52bf95ae38 Change HTML sanitization
Use the `SanitizationFilter` class from the html-pipeline gem for inline
HTML instead of calling the Rails `sanitize` method.
2015-03-19 21:24:07 -06:00
Carlos Ribeiro 2435476167 Add error message when have error on profile screen 2015-03-19 23:31:25 -03:00
Dmitriy Zaporozhets 915c7b9455 Merge branch 'update_ui' into 'master'
Remove mention of branch to commit to when new file is added through UI

See merge request !1731
2015-03-20 01:28:47 +00:00
Dmitriy Zaporozhets 479020ec6b Fix project issues and merge requests pages 2015-03-19 18:27:26 -07:00
Dmitriy Zaporozhets 0ec1c8eea9 Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ce 2015-03-19 17:54:10 -07:00
Dmitriy Zaporozhets ad2720aea8 Merge branch 'master' of github.com:gitlabhq/gitlabhq 2015-03-19 17:53:48 -07:00
Marin Jankovski a879d93378 Remove mention of branch to commit to. 2015-03-19 17:43:21 -07:00
Dmitriy Zaporozhets 00c042ea7c Merge pull request #8772 from awiddersheim/fix/grammar_projects_show
Fix small grammar issue on projects show page
2015-03-19 16:17:37 -07:00
Dmitriy Zaporozhets df8b4ab459 Merge pull request #8662 from yglukhov/mr-and-issue-links
Make MR and issue numbers clickable links in MR and issue lists.
2015-03-19 15:17:07 -07:00
Hannes Rosenögger 623f6c5f09 Merge branch 'fix-underscore-notes' into 'master'
Fix cross-references that contain underscores

### What does this MR do?

Cross-references that contain underscores confuse the Markdown renderer and don't work properly. For example:

1. In  `myacct/project_one#456`, add a comment that includes a reference to `myacct/project_two#123`.
2. The comment in `myacct/project_one#456` links correctly.
3. The system note in `myacct/project_two#123` is incorrectly linked as:

`mentioned in issue myacct/projectone#456_`

This MR removes the use of the `_` character in the system notes to prevent Markdown confusion.

See a full discussion in #1160.

### Are there points in the code the reviewer needs to double check?

To preserve backwards compatibility with existing system notes, there is a SQL wildcard match for notes having underscores. This seemed safer than migrating all notes.

### Why was this MR needed?

In an ideal world, the Markdown parser would be able to handle references containing underscores with or without escape sequences. However, there are a number of issues:

1. RedCarpet's parser for emphasis block is pretty dumb: it treats `#` as a word break and thus even the `intra_word_emphasis` flag has no effect.
2. The parser is in C and can't be changed easily.
3. There is no way to insert an escape sequence for emphasis blocks.

The only way around this is to switch to something like CommonMark, which does support escape sequences.

### What are the relevant issue numbers / [Feature requests](http://feedback.gitlab.com/)?

Issue #1160

### Screenshots

Before:

![Screen_Shot_2015-03-19_at_1.39.29_AM](https://gitlab.com/gitlab-org/gitlab-ce/uploads/a1db4b96c0df2f10d9855ed5abe976ca/Screen_Shot_2015-03-19_at_1.39.29_AM.png)

After:

![Screen_Shot_2015-03-19_at_1.39.35_AM](https://gitlab.com/gitlab-org/gitlab-ce/uploads/189a062c2d19645eec1782ac1f0d4f2f/Screen_Shot_2015-03-19_at_1.39.35_AM.png)

See merge request !385
2015-03-19 21:20:45 +00:00
DJ Mountney 415517918e Update merge_status state to allow more transitions
Previously you could only transition from the unchecked state to one of the others. This meant that the mark_as_unmerged call in AutoMergeService would rarily be able to actually transition the state. As it would usually have already been set to can_be_merged before it hit that service.
2015-03-19 13:51:16 -07:00
Dmitriy Zaporozhets 82d4760d0d Merge branch 'import-button' into 'master'
Move "Import existing repository by URL" option to button.

The "Import existing repository URL" (with or without form visible) looked out place with the new import buttons. I moved it to a button, and moved the form to below the buttons.

@dzaporozhets Would be nice to have in 7.9 since the moved buttons are in there as well.

Before:

![Screen_Shot_2015-03-19_at_15.08.04](https://dev.gitlab.org/gitlab/gitlabhq/uploads/6ac26467ede65a4f31d004c227fdbc3e/Screen_Shot_2015-03-19_at_15.08.04.png)

After:

![Screen_Shot_2015-03-19_at_15.42.56](https://dev.gitlab.org/gitlab/gitlabhq/uploads/a73bd7d09b7a33f58067a3bd0d7f604a/Screen_Shot_2015-03-19_at_15.42.56.png)

("publically" typo has been fixed to "publicly")

See merge request !1728
2015-03-19 19:03:43 +00:00
Dmitriy Zaporozhets 476199e069 Merge branch 'add_canceled_ci_status' into 'master'
Add canceled CI status

Fixes https://github.com/gitlabhq/gitlab-ci/issues/564

https://dev.gitlab.org/gitlab/gitlab-ci/issues/169

![Screen_Shot_2015-03-19_at_17.10.08](https://dev.gitlab.org/gitlab/gitlabhq/uploads/87f47d9fd1b1a60e0c5402eedd1a1566/Screen_Shot_2015-03-19_at_17.10.08.png)

See merge request !1729
2015-03-19 17:21:20 +00:00
Valery Sizov 19032c0319 add canceled CI status 2015-03-19 18:27:24 +02:00
Dmitriy Zaporozhets 1fdf4508d4 Use same font for project description and star links 2015-03-19 09:12:11 -07:00
Dmitriy Zaporozhets 83982e9329 Merge branch 'fix/navbar-toggle-margin' into 'master'
fix(style): align navbar-toggle

Changes:
- change `.navbar-toggle` from `margin: 0 -15px 0 0;` to `margin: 0;`

## Before:
- 320x480 ![Screen_Shot_2015-03-19_at_03.43.53](https://gitlab.com/kingcody/gitlab-ce/uploads/376727af07cf62eec5609c01bbbdaacf/Screen_Shot_2015-03-19_at_03.43.53.png)

- 360x640 ![Screen_Shot_2015-03-19_at_03.44.04](https://gitlab.com/kingcody/gitlab-ce/uploads/d5318de4f45687154d90c54f0bece2aa/Screen_Shot_2015-03-19_at_03.44.04.png)

## After:
- 320x480 ![Screen_Shot_2015-03-19_at_03.45.21](https://gitlab.com/kingcody/gitlab-ce/uploads/20f526c9ef19c2c30add001b15c06358/Screen_Shot_2015-03-19_at_03.45.21.png)

- 360x640
![Screen_Shot_2015-03-19_at_03.45.27](https://gitlab.com/kingcody/gitlab-ce/uploads/e60e9dde1f86d89adf36480e7fcc611d/Screen_Shot_2015-03-19_at_03.45.27.png)

See merge request !402
2015-03-19 16:04:12 +00:00
Dmitriy Zaporozhets 8b723776ac Merge branch 'fix_trigger_search' into 'master'
Only trigger search if search string is present

This is a follow up for !296 to prevent the search function from being executed while the query is nil.

Problem was this:
When the search is called, the search controller gets 2 requests.
```
{"action"=>"show", "controller"=>"search"}
```
and
```
{"utf8"=>"✓",
 "search"=>"proj",
 "project_id"=>"",
 "group_id"=>"",
 "snippets"=>"",
 "scope"=>"",
 "button"=>"",
 "action"=>"show",
 "controller"=>"search"}
```

Obviously it doesn't make sense to execute the search for the first request, since that one doesn't have a scope or a search string.

Please review this carefully since this modifies the search and may break things i can't think of.

@dzaporozhets While this fixes the root cause for the failing test, I think we should keep your fix in as a failsafe. What do you think of this?

See merge request !302
2015-03-19 16:00:55 +00:00
Dmitriy Zaporozhets c8a7e4c6c1 Merge branch 'fewer-constants-more-helpres' into 'master'
Fewer Git constants, more Git helpers.

See merge request !1727
2015-03-19 15:53:43 +00:00
Douwe Maan e23a1e448b Clear up import help. 2015-03-19 16:14:37 +01:00
Stan Hu fad71576f9 Fix cross references when usernames, milestones, or project names contain underscores.
Remove emphasis from system notes to avoid Markdown conflicts in names.
2015-03-19 07:07:30 -07:00
Douwe Maan b298758b44 Move "Import existing repository by URL" option to button. 2015-03-19 15:06:05 +01:00
Hannes Rosenögger 9487c37037 Only trigger actual search if a search string is present 2015-03-19 10:50:34 +01:00
Douwe Maan a5a5ec970e Fewer constants, more helpers. 2015-03-19 10:34:04 +01:00
kingcody 575ae80647 fix(style): align navbar-toggle
Changes:
- change `.navbar-toggle` from `margin: 0 -15px 0 0;` to `margin: 0;`
2015-03-19 05:14:50 -04:00
Dmitriy Zaporozhets 4595d5bf4a Merge branch 'show_test_settings_button' into 'master'
Show test settings as disabled when service cannot be tested.

See merge request !1725
2015-03-19 05:24:40 +00:00
Marin Jankovski 5aa97ce91b Show test settings as disabled when service cannot be tested. 2015-03-18 21:47:17 -07:00
Dmitriy Zaporozhets f3d5046196 Return compare code button to top of sidebar 2015-03-18 21:32:23 -07:00