Dmitriy Zaporozhets
2d85458ac7
Merge branch 'fix-zero-sha-lookup' into 'master'
...
Repository#blob_at should return nil for 00000000... sha
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
See merge request !916
2015-07-01 09:30:43 +00:00
Dmitriy Zaporozhets
87df927f20
Merge branch 'reporter-manage-issues' into 'master'
...
Reporter role can manage issue tracker now
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
See merge request !908
2015-07-01 09:19:56 +00:00
Dmitriy Zaporozhets
d75f16c2ec
Fix commits feed button
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-07-01 11:19:07 +02:00
Dmitriy Zaporozhets
baf12f45d8
Repository#blob_at should return nil for 00000000... sha
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-07-01 11:02:37 +02:00
Dmitriy Zaporozhets
70666a52b4
Use to_reference menthod when render issue id in list
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-07-01 09:46:37 +02:00
Dmitriy Zaporozhets
4d80360bed
Cache markdown of comments
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-06-30 15:54:20 +02:00
Dmitriy Zaporozhets
40e31e1db3
Cache issue in the list
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-06-30 15:48:19 +02:00
Dmitriy Zaporozhets
496f94de4a
Cache commits list
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-06-30 15:41:25 +02:00
Dmitriy Zaporozhets
b76659c537
Re-use event cache with other users unless its personal
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-06-30 15:34:16 +02:00
Dmitriy Zaporozhets
f9261e6596
Open big avatar when click on user image
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-06-30 15:23:32 +02:00
Dmitriy Zaporozhets
b42c40bff3
Make commits atom feed button smaller
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-06-30 15:13:18 +02:00
Dmitriy Zaporozhets
a5b54f919a
Reporter role can manage issue tracker now
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-06-30 13:33:02 +02:00
Dmitriy Zaporozhets
88162f6970
Merge branch 'fix-relative-submodule-namespace-path' into 'master'
...
Fix Error 500 when relative submodule resolves to a namespace that has a different name from its path
### What does this MR do?
This MR fixes a bug in resolving a namespace when the `name` differed from `path`.
### Why was this MR needed?
The original code was using `name`, when the proper input to `namespace_project_path` was `path`.
### What are the relevant issue numbers?
Closes #1849
See merge request !864
2015-06-29 14:04:04 +00:00
Robert Speicher
ae75b2ee40
Remove requires-input from the Network Graph form
...
The "Begin with the selected commit" checkbox requires the submit button
to be enabled, even if the extended SHA1 input field is blank.
2015-06-26 22:49:32 -04:00
Robert Speicher
8384b577ef
Remove duplicate 'required: true' attribute
2015-06-26 22:08:34 -04:00
Robert Speicher
f6503f71f9
Remove disableButtonIf[Any]EmptyField calls from forms
...
These have been replaced by the "requiresInput" behavior.
2015-06-26 22:07:59 -04:00
Robert Speicher
e4472cee78
Add "Requires Input" JS behavior
2015-06-26 22:06:42 -04:00
Dmitriy Zaporozhets
9f166a8649
Merge branch 'rename-abilities' into 'master'
...
Rename abilities to correspond contoller/model action names
write_ was renamed to create_
modify_ was renamed to update_
So now in update action we have next code
```
def create
can?(current_user, :create_issue, @issue)
end
def update
can?(current_user, :update_issue, @issue)
end
```
See merge request !896
2015-06-26 16:39:17 +00:00
Dmitriy Zaporozhets
06ab7d89f9
Merge branch 'rs-issue-1887' into 'master'
...
Reorder MergeRequestTabs constructor
The tab was being activated before we set the `[commits|diffs]Loaded`
variable, so even when the `/diffs` route is accessed directly, like
from the "Side-by-side" link, the tab was being loaded from its default
source.
Fixes #1887
See merge request !892
2015-06-26 16:17:07 +00:00
Dmitriy Zaporozhets
7ca017b513
Refactor issue, mr, note abilities to include project abilities too
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-06-26 18:15:36 +02:00
Dmitriy Zaporozhets
083d4604c4
Change dynamic abilities to new format
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-06-26 17:18:40 +02:00
Dmitriy Zaporozhets
d63371ad78
Update controller filters
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-06-26 16:44:21 +02:00
Dmitriy Zaporozhets
05ef7ba105
Merge branch 'permission-improvements' into 'master'
...
Update permissions for issue tracker management
Don't allow guest or reporter to set assignee, milestone and label when create or update new issue and merge request.
After this change `Guest` and `Reporter` rule is used to report issues but only `Developer` and higher roles can manage issues (schedule milestone, assign to user or close any issue)
Also I removed some duplication code between issues and merge requests and put all issuable partials in one directory
See merge request !890
2015-06-26 14:37:45 +00:00
Dmitriy Zaporozhets
342d553709
Rename abilities to correspond contoller/model action names
...
write_ was renamed to create_
modify_ was renamed to update_
So now in update action we have next code
def create
can?(current_user, :create_issue, @issue)
end
def update
can?(current_user, :update_issue, @issue)
end
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-06-26 15:55:56 +02:00
Dmitriy Zaporozhets
d5947ada44
Simplify set of assignee, milestone and label to admin_issue rule
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-06-26 15:45:45 +02:00
Dmitriy Zaporozhets
b9fa82daee
Update tests and use js-issuable class for context form
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-06-26 15:05:30 +02:00
Robert Speicher
d2b5c3f6ce
Trigger sticky_kit:recalc when diffs are pre-loaded
2015-06-25 21:26:20 -04:00
Robert Speicher
4e7f23fe0b
Reorder MergeRequestTabs constructor
...
The tab was being activated before we set the `[commits|diffs]Loaded`
variable, so even when the `/diffs` route is accessed directly, like
from the "Side-by-side" link, the tab was being loaded from its default
source.
Fixes #1887
2015-06-25 18:33:24 -04:00
Dmitriy Zaporozhets
a9095280c7
UsersSelect is part of filter so I rather keep js executed in partial
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-06-25 16:54:35 +02:00
Dmitriy Zaporozhets
cbb64a4f63
Fix js error on merge request page
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-06-25 16:37:52 +02:00
Dmitriy Zaporozhets
0bcfe9a0dc
Dont allow set assignee, milestone or labels if user is guest
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-06-25 16:17:48 +02:00
Dmitriy Zaporozhets
5ff870a044
Move duplicate js functionality into IssuableForm
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-06-25 16:17:06 +02:00
Dmitriy Zaporozhets
2d31568b27
Refactor issue and merge request sidebar
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-06-25 16:04:50 +02:00
Matthew Firtion
024e854eca
Add SAML to list of social_provider
2015-06-25 09:58:55 -04:00
Dmitriy Zaporozhets
d315d1eba4
Dont allow guest to set assigne, milestone and label when create new issue or merge request
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-06-25 15:38:04 +02:00
Dmitriy Zaporozhets
60baa1e866
Move issuable partials in common directory
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-06-25 15:11:22 +02:00
Dmitriy Zaporozhets
6288677134
Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ce
2015-06-25 13:33:50 +02:00
Douwe Maan
7b804e231a
Have sidebar labels disappear behind content instead of hide immediately.
2015-06-25 11:42:15 +02:00
Job van der Voort
0429a24066
prettier highlighting of active link in the sidebar
2015-06-25 11:19:56 +02:00
Dmitriy Zaporozhets
9c0229732a
Merge branch 'rs-random-placeholder-tip' into 'master'
...
Show a random Markdown tip in the textarea placeholder
cc @darby
See merge request !879
2015-06-25 08:59:54 +00:00
Dmitriy Zaporozhets
87fa392d7f
Merge branch 'project_icon_removal' into 'master'
...
Removed the icons from the New Issue and New Project buttons
Fixes #1869
No more icons!
See merge request !885
2015-06-25 08:38:30 +00:00
Dmitriy Zaporozhets
0c8b96bdbc
Merge branch 'performance-improvements' into 'master'
...
Performance improvements
* store @participants in variable
* store result of subscribed? call into variable
In total it reduce amount of SQL queries for issue or merge_request with 10 comments/participants almost twice.
See merge request !883
2015-06-25 08:14:03 +00:00
Darby
5571b73563
Changed the color of admin/application_settings buttons
2015-06-24 16:16:24 -07:00
Robert Speicher
09f2bec64c
Prefix random Markdown tips with "Tip:"
2015-06-24 18:43:57 -04:00
Darby
e94e23617a
Removed the icons from the New Issue and New Project buttons
2015-06-24 11:48:04 -07:00
Nicolas
a521e88fc0
Fix consistency issue in sidebars of Project and Group Settings.
...
Fixes #2277 .
2015-06-24 18:05:16 +02:00
Adam Meily
0cf2e62fb2
Updated merge request merged web hook to correctly fire action=merged.
...
Fixes #879
Fixes #498
2015-06-24 10:15:18 -04:00
Dmitriy Zaporozhets
7aa8e12c54
Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ce
2015-06-24 13:59:01 +02:00
Dmitriy Zaporozhets
c7a7341b5b
Merge branch 'explicit_error_ci' into 'master'
...
Explicit error when commit not found in the GitLab CI
!!! SHOULD BE MERGED WITH https://gitlab.com/gitlab-org/gitlab-ci/merge_requests/159
https://dev.gitlab.org/gitlab/gitlab-ci/issues/280
See merge request !871
2015-06-24 11:32:47 +00:00
Dmitriy Zaporozhets
9da229adc6
Merge branch 'stop-jumping' into 'master'
...
stop jumping all content on collapsing and expanding the sidebar
When you collapse or expand the sidebar, all content shifts with 5px.
This merge request solves that.
cc @darby
See merge request !1877
2015-06-24 11:13:49 +00:00