Dmitriy Zaporozhets
69c193e78a
Merge branch 'master' into remove-satellites
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-08-11 22:48:55 +02:00
Dmitriy Zaporozhets
cb6ad67f52
Merge branch 'check-out-branch-button' into 'master'
...
Add "Check out branch" button to the MR page.
I appreciated the thought behind adding the "Fetch this branch using ..." line, but not so much the implementation. I think a "Check out branch" button alongside the existing "Download as" makes more sense to get instructions on how to get the changes on your local machine, since that's pretty much what "Download as" does as well.
Like the "command line", the button opens the command line merge instructions modal. I've improved the text of that modal in !1120 .

It looks even better in combination with !1121 , which gets rid of the "If you want to ..." line:

cc @dzaporozhets @rspeicher
See merge request !1116
2015-08-11 17:49:06 +00:00
Dmitriy Zaporozhets
3e259ea8bc
Revert "Merge branch 'revert-satellites' into 'master'
"
...
This reverts commit 5daf44b7c8 , reversing
changes made to 2f706fbd23 .
2015-08-11 14:33:31 +02:00
Dmitriy Zaporozhets
9f10943c1a
Revert "Merge branch 'drop-satellites'"
...
This reverts commit 957e849f41 , reversing
changes made to 6b9dbe9f5a .
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-08-11 10:28:42 +02:00
Douwe Maan
b716e45de1
Fix spec
2015-08-10 14:15:27 +02:00
Dmitriy Zaporozhets
a87989fb7d
Remove satellites
2015-07-15 15:45:57 +02:00
Dmitriy Zaporozhets
32330e8c28
Merge branch 'rs-fix-subscription-feature' into 'master'
...
Attempt to fix the "I should see that I am [un]subscribed" steps
Makes use of Capybara methods that wait. Hopefully this will fix the
random timing-related failures of this step.
See merge request !853
2015-06-29 08:57:32 +00:00
Robert Speicher
d92bb3cfe0
Attempt to fix the "I should see that I am [un]subscribed" steps
...
Makes use of Capybara methods that wait. Hopefully this will fix the
random timing-related failures of this step.
2015-06-25 21:37:16 -04:00
Robert Speicher
e14d517b61
Fix merge request diff features
2015-06-25 21:30:18 -04:00
Stan Hu
555fd0cf4a
Fix downloading of patches on public merge requests when user logged out
...
Closes #1225
Closes #1854
Closes #1858
2015-06-23 05:34:21 -07:00
Dmitriy Zaporozhets
cc9b5c49d1
Merge branch 'revert-mr-state-names'
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
Conflicts:
features/steps/project/merge_requests.rb
2015-06-22 15:43:09 +02:00
Robert Speicher and Dmitriy Zaporozhets
afec5efc7d
Fix features syntax
2015-06-22 12:13:45 +02:00
Dmitriy Zaporozhets
7524d7c082
Revert merge request states renaming
...
Replaced:
* "Accepted" with "Merged"
* "Rejected" with "Closed"
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-06-19 17:09:50 +02:00
Robert Speicher
4c42fc7c4c
Call page.all instead of all in feature steps
...
There's a naming conflict between Capybara and rspec-matchers which both
define the `all` method.
See https://github.com/jnicklas/capybara/issues/1396
2015-06-12 05:12:42 -04:00
Robert Speicher
584f8601ef
Change within to page.within in feature steps
2015-06-12 05:12:42 -04:00
Robert Speicher
69bbc413fe
Update all should-style syntax to expect in features
2015-06-12 05:12:09 -04:00
Dmitriy Zaporozhets
11bf5b693b
Fix test for accept merge request
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-06-12 09:29:27 +02:00
Dmitriy Zaporozhets
a35aec7adb
Fix merge request test
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-06-11 22:27:26 +02:00
Stan Hu
5e4384ec9b
Support editing target branch of merge request
...
Closes https://github.com/gitlabhq/gitlabhq/issues/7105
See: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/130
2015-05-29 04:08:08 -07:00
Robert Speicher
5c52eaa9d2
Persist current merge request tab selection via URL
...
Closes internal https://dev.gitlab.org/gitlab/gitlabhq/issues/2350
2015-05-27 22:39:11 -04:00
Douwe Maan
7df45882a9
Update specs.
2015-05-25 18:37:38 +02:00
Robert Speicher
f3d63eeb18
Remove feature tests for old task lists
2015-05-06 13:00:14 -04:00
Dmitriy Zaporozhets
c66e575179
Fix tests
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-05-06 17:00:19 +03:00
Stan Hu
48efd65ff6
Remove timing dependency on test
...
See: http://www.elabs.se/blog/53-why-wait_until-was-removed-from-capybara
2015-04-14 10:34:48 -07:00
Stan Hu
546dab6da9
Fix broken side-by-side diff view on merge request page
...
Closes #1294
2015-03-25 23:39:34 -07:00
Dmitriy Zaporozhets
1cf138170c
Add tooltip for comment toggle in diff. Add changelog item and fix tests
2015-03-18 20:12:19 -07:00
Valery Sizov
22fcb2f418
improve UI
2015-03-17 17:11:57 +02:00
Valery Sizov
1b437ec349
tests
2015-03-16 21:38:41 +02:00
Dmitriy Zaporozhets
80b2f3fb86
Implement merge requests search
...
It is same search like we have at issues page. It allows to quickly
filter merge requests based on title or desription. I copy-pasted some
js code from Issues.js. In future search (filtering) logic should be
refactoed into one class for merge requests and issues
2015-03-12 16:20:58 -07:00
Douwe Maan
9b8d5c4ab4
Make test element selection more specific.
2015-02-25 11:01:50 +01:00
Vinnie Okada
9e9ce95d62
Merge branch 'master' into rails-4.1.9
...
Conflicts:
app/views/dashboard/_project.html.haml
app/views/events/event/_common.html.haml
app/views/explore/projects/_project.html.haml
app/views/groups/_projects.html.haml
app/views/projects/_home_panel.html.haml
app/views/projects/_issues_nav.html.haml
app/views/projects/issues/_discussion.html.haml
app/views/projects/issues/_issues.html.haml
app/views/projects/issues/show.html.haml
app/views/projects/merge_requests/_discussion.html.haml
app/views/projects/merge_requests/_show.html.haml
app/views/projects/milestones/index.html.haml
app/views/projects/notes/_edit_form.html.haml
app/views/shared/_issuable_filter.html.haml
2015-02-19 20:53:05 -07:00
Douwe Maan
080449f8af
Make sure Markdown previews always use the same styling as the eventual destination.
2015-02-17 17:58:08 +01:00
Vinnie Okada
76aad9b76e
Upgrade to Rails 4.1.9
...
Make the following changes to deal with new behavior in Rails 4.1.2:
* Use nested resources to avoid slashes in arguments to path helpers.
2015-02-14 11:09:23 -07:00
Dmitriy Zaporozhets
b076d8cddb
Fix test for merge request
2015-01-28 15:36:12 -08:00
Dmitriy Zaporozhets
9c0d241e27
Fix tests
2015-01-16 08:47:58 -08:00
Dmitriy Zaporozhets
f891ababeb
Fix randomly failing test
2015-01-10 21:42:16 -08:00
Dmitriy Zaporozhets
884352294d
Fix tests
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-12-30 20:10:46 +02:00
Dmitriy Zaporozhets
0930086bea
Fix tests
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-12-30 16:38:27 +02:00
Dmitriy Zaporozhets
3d2f123081
Fix tests
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-12-29 13:31:30 +02:00
Dmitriy Zaporozhets
fca161f5c5
Fix tests
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-12-25 15:55:12 +02:00
Dmitriy Zaporozhets
5b49bb208a
Fix issueable context update and fix tests
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-12-22 16:42:26 +02:00
Vinnie Okada
e1491465de
Refactor Markdown preview tests
...
Create a new shared module for common issue/merge request behavior,
use `expect` syntax instead of `should`, and avoid `visible: false` in
the `have_css` matcher.
2014-10-18 17:58:34 -05:00
Vinnie Okada
5700842ba8
Add Markdown preview to more forms
...
Enable Markdown previews when creating and editing issues, merge
requests, and milestones, and when editing notes.
2014-10-15 23:52:33 -05:00
Dmitriy Zaporozhets
b2d1e97df9
Fix spinach tests
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-10-10 18:42:05 +03:00
Dmitriy Zaporozhets
cf1aa36a21
Merge pull request #7979 from mr-vinn/refactor-tasks
...
Refactor task list tests and coffeescript
2014-10-08 11:37:21 +03:00
Vinnie Okada
40263a06c1
Refactor task list tests and coffeescript
2014-10-06 19:19:12 -05:00
Marin Jankovski
0fed1b5876
Merge pull request #7964 from mr-vinn/task-lists
...
Add task lists to issues and merge requests
2014-10-06 17:29:06 +02:00
Marin Jankovski
9535ce2caa
Preventing some duplication in MR feature tests by adding a different comment.
2014-10-06 16:09:22 +02:00
Vinnie Okada
31bc42de57
Add Spinach tests for task lists
2014-10-06 02:07:03 -05:00
Ciro Santilli
3098e7a453
Factor commit message textareas.
2014-10-02 12:03:30 +02:00