Dmitriy Zaporozhets
674cbe1534
Fix diff comments toggle button
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-06-25 11:40:33 +03:00
Dmitriy Zaporozhets
9a3cab6bf6
Cleanup
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-06-24 22:23:32 +03:00
Dmitriy Zaporozhets
e93f6b030a
Improve discussions
...
* check for outdated discussions by comparing diff
* improve discussion UI
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-06-24 22:19:35 +03:00
Dmitriy Zaporozhets
a49d45db41
Move reply button to helper from view
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-06-24 13:34:46 +03:00
Marin Jankovski
8301557966
Add tabindex -1 to skip on tabbing.
2014-06-18 14:21:24 +02:00
Dmitriy Zaporozhets
3398e0a3d7
Revert "Implements and refactors clipboard feature for markdown."
...
This reverts commit 2273234653 .
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
Conflicts:
app/views/projects/issues/_form.html.haml
app/views/projects/merge_requests/_form.html.haml
app/views/projects/merge_requests/_new_submit.html.haml
app/views/projects/milestones/_form.html.haml
app/views/projects/notes/_form.html.haml
app/views/projects/wikis/_form.html.haml
2014-06-03 10:56:40 +03:00
Marin Jankovski
f79a300417
Replace existing links to help pages with the new ones.
2014-05-29 08:58:15 +02:00
erbunao
2273234653
Implements and refactors clipboard feature for markdown.
2014-05-28 22:51:47 +08:00
Dmitriy Zaporozhets
5cfaf945cd
Improve notes form UI/UX
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-05-24 13:06:44 +03:00
Earle Bunao & Neil Calabroso and erbunao
6a85cdf162
Implements drag and drop upload in creating issues
2014-05-23 16:22:42 +08:00
Dmitriy Zaporozhets
3ea4bf4891
Merge pull request #6045 from jacargentina/fix-4305
...
Temporary fix for #4305 : Cant preview attached png images on notes; attachment.secure_url returns an url which is accessible
2014-05-13 12:29:54 +03:00
Dmitriy Zaporozhets
aa5f306d11
Merge pull request #6860 from hszcg/dev
...
Add support for side-by-side inline comments
2014-05-08 21:23:44 +03:00
Jacob Vosmaer
285926918b
Serialize last_fetched_at as a string with seconds
2014-04-28 12:42:01 +02:00
Jacob Vosmaer
7ec5ff4dba
Pass last_fetched_at for notes to javascript
2014-04-28 12:21:49 +02:00
Chenguang Zhang
84870438f9
Add support for side-by-side inline comments
2014-04-24 21:18:10 +08:00
Dmitriy Zaporozhets
3befe6ec33
Fix show/hide discussion link
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-04-07 18:57:57 +03:00
Marin Jankovski
17bb700712
Only show diff it exists.
2014-04-04 19:12:23 +02:00
Marin Jankovski
5f595be4b8
Use new gems methods.
2014-03-20 13:33:16 +01:00
Dmitriy Zaporozhets
2a7da96a0d
Merge branch 'toggle_diff_comments' of https://github.com/jacob-carlborg/gitlabhq into jacob-carlborg-toggle_diff_comments
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
Conflicts:
app/assets/stylesheets/sections/commits.scss
app/assets/stylesheets/sections/notes.scss
app/views/projects/commits/_diffs.html.haml
features/steps/project/merge_requests.rb
2014-03-13 23:11:16 +02:00
Javier Castro
b61f80babb
Merge remote-tracking branch 'upstream/master' into fix-4305
2014-03-04 15:09:33 -03:00
Dmitriy Zaporozhets
8290c9a67f
Use proper classes for sdiff content
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-02-24 09:51:50 +02:00
Jacob Carlborg and Jacob Carlborg
2d554f42f0
Add button for toggling inline comments in diff view.
...
This is useful when there are many comments and they're becoming a distraction when trying to read the diff.
2014-02-22 21:21:12 +01:00
Dmitriy Zaporozhets
f92b1f3d01
Use more specific class names: grouped -> btn-grouped
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-02-20 13:05:33 +02:00
Ciro Santillli
61748c993d
Headers have ids and link to their own id.
2014-02-11 16:23:33 +01:00
Javier Castro
556ae5ae81
Temporary fix for #4305 : Cant preview attached png images on notes; attachment.secure_url returns an url which is accessible
2014-01-14 12:06:53 -03:00
Dmitriy Zaporozhets
8c1d414674
Include tw bootstrap manually. Fix hide class
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-01-01 21:42:42 +02:00
Dmitriy Zaporozhets
6cbadc953f
css class .hide has \!important so use gl-hide instead
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2013-12-31 00:38:53 +02:00
Dmitriy Zaporozhets
9a31844e2a
Remove unnecessary ago keyword
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2013-12-30 14:49:22 +02:00
Dmitriy Zaporozhets
5f7db3e94b
Fix file upload for edit note. Better style for discussion form
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2013-12-26 09:44:18 +02:00
Dmitriy Zaporozhets
48c682b52f
Switch Notes controller to use json
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2013-12-25 22:32:23 +02:00
Dmitriy Zaporozhets
f7e7dc7ebb
Make note anchors actually work
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2013-12-25 13:32:43 +02:00
Dmitriy Zaporozhets
4efaa51bbe
Make comment preview button white
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2013-12-18 16:07:49 +02:00
Drew Blessing
fa817dffea
Add time ago tooltips to show actual date/time
...
Clean up admin dashboad tooltips
Clean up admin dashboad tooltips
Clean up admin dashboad tooltips
Add helper method
change to use app helper
Modify tooltips to use new helper
Convert remaining times
Adjust one tooltip
2013-12-14 15:24:12 -06:00
Dmitriy Zaporozhets
9b7b27ce72
Add authenticity_token: true to multipart forms
...
Rails 4 does not generate token by default
It fixes bug when you get to sign-in page after trying to upload image
with comment
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2013-12-12 19:05:21 +02:00
Dmitriy Zaporozhets
d75eb24378
Fix more confirm deprecations
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2013-12-10 13:20:54 +02:00
Dmitriy Zaporozhets
ed82ab4117
Remove some deprecations and fir project helper specs
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2013-12-10 12:11:29 +02:00
Dmitriy Zaporozhets
596e64e5d7
Drop rjs from Notes#index
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2013-11-29 14:46:40 +02:00
Dmitriy Zaporozhets
c2f6eb0ffe
Rollback preview button href
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2013-11-27 11:18:33 +02:00
Dmitriy Zaporozhets
b34378c4d7
Improve preview/edit links for comment form
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2013-11-27 11:14:42 +02:00
Steven Thonus and Steven Thonus
856d4088fb
diff view on commit with parallel diff view
...
TODO: fix comment forms to respect left and right columns
2013-11-17 16:35:34 +01:00
Steven Thonus
65cad57a35
avatar upload on profile page
2013-10-09 09:05:09 +02:00
Dmitriy Zaporozhets
2f6342978b
Public projects feature - step2
...
* Render right layout depends on current_user
* show sample git username/email when repo is empty
* Show extra info when browsing public area
* Fixed some tests related to public projects
* show comments in read-only for public projects
* Remove old public routing
2013-09-24 22:14:28 +03:00
Dmitriy Zaporozhets
4537623d12
Merge branch 'master' into karlhungus-mr-on-fork
...
Conflicts:
app/contexts/filter_context.rb
app/contexts/search_context.rb
app/models/merge_request.rb
app/models/note.rb
app/views/shared/_merge_requests.html.haml
spec/controllers/commit_controller_spec.rb
spec/services/notification_service_spec.rb
2013-08-08 12:22:09 +03:00
Dmitriy Zaporozhets
af5faaf0e1
Move diff parsing to own class. Correctly identify note diff line
2013-08-04 20:43:49 +03:00
Dmitriy Zaporozhets
8f05fbbab5
Dont show comment on diff if diff line was changed after comment left
2013-08-04 19:35:47 +03:00
Dmitriy Zaporozhets
0675552463
It was hard to click on small edit icon for comment
2013-08-04 16:46:46 +03:00
Izaak Alpert
532809a173
Revert note.project references back to @project
...
-removed extranious space from new_merge_request_email.text.erb
Change-Id: I65314b3fe8f8442b4c30d311b96fbceddf240f42
2013-07-17 22:48:03 -04:00
Izaak Alpert
489fa5d726
MR on Fork multiple fixes
...
-Disable observers post test run
-Allow db:seed_fu RAILS_ENV=test to be run more than once without error
-fix diffs_in_between, was passing in the default_options for grit, but grit in this case doesn't take options, fixed the test to actually fail if the incorrect diffs are returned
-make notes/commits render against proper project
-MR discussion file links should reference note's project
-Added tests for commit links on edit merge request
-fixes edit issues (canceling an edited mr, updating an edited mr)
-updates tests with checks for source code updates
-still forked_merge_requests.feature (project_forked_merge_requests) test not passing (commented out -- "stable" not being set)
MR API: error on bad target_project
-If the target project id is specified and it is not the same as the project the request is being made on (the source), and the it isn't a fork of that project, error out, otherwise use it as the target
-Fixes some busted (but hidden) test cases
Conflicts:
app/views/merge_requests/show/_diffs.html.haml
spec/features/notes_on_merge_requests_spec.rb
Change-Id: I20e595c156d0e8a63048baaead7be6330c738a05
2013-07-17 22:42:51 -04:00
Dmitriy Zaporozhets
e49ec46461
Open note image attachment in new tab
2013-07-11 09:19:19 +03:00
Dmitriy Zaporozhets
5067e9dc88
Minor UI improve for dashboard events
2013-07-04 17:10:34 +03:00