Dmitriy Zaporozhets
ccdf08d80a
Refactor merge request merge service
...
* Add system note when user merges MR in same way as it closes it
* Remove duplicating code
2015-01-06 16:24:47 -08:00
Dmitriy Zaporozhets
6487419364
Automatically close merge requests that were locker for 1 day
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-12-05 16:02:08 +02:00
Dmitriy Zaporozhets
b23f71ec4d
Set/unset merge request locked_at timestamp after transition
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-12-05 15:49:25 +02:00
Vinnie Okada
9f0083a96c
Add task lists to issues and merge requests
...
Make the Markdown parser recognize "[x]" or "[ ]" at the beginning of a
list item and turn it into a checkbox input. Users who can modify the
issue or MR can toggle the checkboxes directly or edit the Markdown to
manage the tasks. Task status is also displayed in the MR and issue
lists.
2014-10-05 22:15:27 -05:00
Kirill Zaitsev
1c9d2e39c1
Hook attributes
2014-10-02 12:58:02 +04:00
jubianchi
998cd3cb63
Improve error reporting on users API
...
* users (#6878 , #3526 , #4209 ): Validation error messages are now exposed through 400 responses, 409 response are sent in case of duplicate email or username
* MRs (#5335 ): 409 responses are sent in case of duplicate merge request (source/target branches), 422 responses are sent when submiting MR fo/from unrelated forks
* issues
* labels
* projects
2014-09-16 01:25:24 +02:00
Dmitriy Zaporozhets
92deb451da
Annotate models
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-08-25 12:25:02 +03:00
Dmitriy Zaporozhets
d45a6b2941
Migrate issue/mr labels from act_as_taggable to own labels
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-07-29 19:19:26 +03:00
Dmitriy Zaporozhets
ddaa493ef3
Improve MR building
...
* fix 500 error when no parent for initial commit
* fix link from diff files to wrong commit
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-07-28 20:54:40 +03:00
Jeroen van Baarsen
16eea49277
Moved some behaviour to one place
...
Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com >
2014-07-25 22:23:42 +02:00
Dmitriy Zaporozhets
be5b6db883
Refactor diff suppress logic and diff views
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-07-15 18:28:21 +03:00
Dmitriy Zaporozhets
45623089e2
Refactor MR build process
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-07-15 15:34:06 +03:00
Christian Taedcke
c1b7e904ff
Add a mention of the merge request into its default commit message.
2014-07-01 21:54:19 +02:00
Dmitriy Zaporozhets
4f0bfdb500
Merge branch 'strong-parameters' into 'master'
...
Strong parameters
Replace protected_attributes with strong parameters.
Fixes #1340
2014-06-30 17:01:22 +00:00
Jacob Vosmaer
b5007c1565
Rename MergeRequest#lock! to #lock_mr!
...
As a warning from the StateMachine gem points out to us, there already
exists a method ActiveRecord#lock!. This change renames the `lock` and
`unlock` events defined on MergeRequest to `lock_mr` and `unlock_mr`.
2014-06-26 14:09:17 +02:00
Dmitriy Zaporozhets
1dab15940d
Remove protected_atrributes gem and start moving to strong params
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-06-26 14:30:07 +03:00
Jacob Vosmaer
3f1ece2690
Detect closing issues in Merge Request description
2014-06-13 17:25:44 +02:00
Dmitriy Zaporozhets
ffd50e8cf5
Add merged mrs list to milestone page
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-06-05 16:28:13 +03:00
Dmitriy Zaporozhets
affd376f7a
Dont show remove source branch ckecbox/button if you dont have such
...
permissions for MR page
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-05-27 18:51:41 +03:00
Dmitriy Zaporozhets
1f1c59b61d
Merge pull request #6778 from dblessing/feature/mr_labels
...
Merge Request Labels
2014-05-13 14:43:46 +03:00
Drew Blessing
5f25cdfe19
Implement Merge Request Labels
2014-05-13 06:41:36 -05:00
Dmitriy Zaporozhets
23de3551ab
Add MergeRequest#target_project_namespace
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-05-08 15:37:36 +03:00
Dmitriy Zaporozhets
36f861f1b1
Re-annotate models
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-04-09 15:05:03 +03:00
Dmitriy Zaporozhets
d92e4830f7
Allow people to remove source branch of fork project in MR
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-04-07 19:11:02 +03:00
Dmitriy Zaporozhets
9b598fa62d
Fix MR fork validation and services load
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-04-03 10:36:10 +03:00
Dmitriy Zaporozhets
9ee697dd68
Use MergeRequest services in API and controllers
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-04-02 21:51:53 +03:00
Dmitriy Zaporozhets
f08464c055
Remove author_id_of_changes from app
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-03-25 14:01:52 +02:00
Daniel Cestari and Dmitriy Zaporozhets
55fbe71ad1
Fix error with reopened merge request not properly reloading
...
If you reopen a Merge Request and then try to update the source branch
it won't properly reload the code since the "reload_code" method still
checks if the MR is "opened" and not just "open" (which includes reopened)
2014-03-12 08:54:42 +02:00
Dmitriy Zaporozhets
36b065e634
Feature: reopen closed merge request
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-02-28 22:43:16 +02:00
Dmitriy Zaporozhets
1c61ac1c64
Refactor MR code reload
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-02-18 20:17:26 +02:00
Dmitriy Zaporozhets
1e106756fa
For form MR render only namespace name
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-02-15 14:36:58 +02:00
Dmitriy Zaporozhets
f416b2f5cf
Fix bug with merge request branch select
...
Merge request target branch select is broken if you submit form and have
some errors on page
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-01-31 13:24:38 +02:00
Dmitriy Zaporozhets
1338c7dd71
Fix mr update issue if merge_request_diff missing
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-01-24 14:38:02 +02:00
Dmitriy Zaporozhets
48f741eed9
MergeRequests services
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-01-24 14:18:32 +02:00
Dmitriy Zaporozhets
380342784d
Fix MR spinach tests
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-01-23 12:55:43 +02:00
Dmitriy Zaporozhets
4b3afe2325
Always create merge_request_diff if MR created
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-01-22 20:22:20 +02:00
Dmitriy Zaporozhets
51ea42e238
Improve commit render performnace for MR show page
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-01-22 15:54:53 +02:00
Dmitriy Zaporozhets
79bfbe5918
Remove commits/diff store login from MergeRequest model
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-01-22 15:20:20 +02:00
Dmitriy Zaporozhets
09d5868c22
Fix mr controller specs
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-01-14 10:47:28 +02:00
Dmitriy Zaporozhets
db966364de
MergeRequest#automerge accepts custom message now. MergeRequest#merge_commit_message generate default one
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-01-13 17:20:30 +02:00
Drew Blessing
63723ef6df
Fix dashboard event caching
2013-12-13 13:40:45 -06:00
Dmitriy Zaporozhets
cb599a09be
Allow close of broken MR
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2013-12-12 12:20:54 +02:00
Dmitriy Zaporozhets
6c3459978d
Add new methods to MR to check if source or target branch exists
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2013-12-12 11:34:42 +02:00
Dmitriy Zaporozhets
b658489f27
Fix bugs when discussion visible in wrong project
...
Because notes scope was not limited by project in
MergeRequest#mr_and_commit_notes it causes comments from project A
appears in discussions for MR in project B.
2013-10-07 14:49:01 +03:00
Dmitriy Zaporozhets
e219cf7246
Annotate!
2013-10-01 15:15:28 +03:00
Dmitriy Zaporozhets
76a0739454
Add description to MergeRequest model
2013-09-09 16:32:43 +03:00
ash wilson
c8a115c0e3
Link issues from comments and automatically close them
...
Any mention of Issues, MergeRequests, or Commits via GitLab-flavored markdown
references in descriptions, titles, or attached Notes creates a back-reference
Note that links to the original referencer. Furthermore, pushing commits with
commit messages that match a (configurable) regexp to a project's default
branch will close any issues mentioned by GFM in the matched closing phrase.
If accepting a merge request would close any Issues in this way, a banner is
appended to the merge request's main panel to indicate this.
2013-08-25 18:58:41 -04:00
Dmitriy Zaporozhets
8dd37afe34
Reannotate
2013-08-21 12:34:02 +03:00
Dmitriy Zaporozhets
625fb2f29d
Add iids to milestones. Moved iids logic to separate concern
2013-08-21 12:16:26 +03:00
Dmitriy Zaporozhets
7047a44a26
Sett iid on create. Use iid as value to_param
2013-08-19 22:10:56 +03:00