Fix for a "500: Encoding error" in the blame view
What does this MR do?
- The change enforces UTF-8 encoding on the source line data obtained from the Git.
Are there points in the code the reviewer needs to double check?
- The fix might not be enough to fix all encoding error issues in the blame view. There might be similar encoding issues if there are non-UTF-8 encoded names, for example
Why was this MR needed?
- This change fixes the "500: encoding error" that I get when I try to view the Gitlab source CHANGELOG file.
What are the relevant issue numbers / Feature requests?
- Gitlab issue #894: https://gitlab.com/gitlab-org/gitlab-ce/issues/894
See merge request !298
Remove hidden settings text on project settings
No need to have the hidden settings text anymore as the danger area is now unified.
See merge request !320
Disable turbolink on links pointing out to CI services
### What does this MR do?
This MR adds 'data-no-turbolink' attribute into all links pointing to CI services.
### Are there points in the code the reviewer needs to double check?
No
### Why was this MR needed?
In rare cases where gitlab and CI service is installed on the same host, turbolink will be used for links between those two. This may result in corrupted css and javascript.
This change is harmless for installations that do not share the domain name for GitLab and CI system - in such case, all links modified are already pointing out outside of the domain so turbolink won't handle them.
### What are the relevant issue numbers / Feature requests?
I consider this a small fix, no issue has been added.
See merge request !305
Show tags in commit view
### What does this MR do?
With this MR you can see the assigned tags for a commit in the commit view.
### Are there points in the code the reviewer needs to double check?
I don't think so. But it would be awesome if the reviewer can tell me how to add a tag to the sample_commit in spec/support/repo_helpers.rb.
Then I can add a test for the new tag_names_contains method as soon as possible :)
### Why was this MR needed?
At the moment if one click on a commit will see details such as: parent commit, amount of additions, deletions, but will not see if this commit has Tag linked to it.
Showing branch, tag details will give better overview about the commit
### What are the relevant issue numbers / Feature requests?
Feature request: http://feedback.gitlab.com/forums/176466-general/suggestions/3962044-show-tags-in-commit-view
### Screenshots
@dblessing Can you take a look at this MR as well please?
See merge request !297
Valery Sizov
Dmitriy Zaporozhets
Sytse Sijbrandij
Jeroen van Baarsen
Jason Blanchard
Marin Jankovski
Achilleas Pipinellis
Dmitriy Zaporozhets
Hannes Rosenögger
Steven ThonusandHannes Rosenögger
Drew Blessing
