Enable the Rubocop DeprecatedClassMethods cop
This reports uses of `File.exists?` and `Dir.exists?`, which were both
deprecated in Ruby and will eventually be removed in favor of `.exist?`.
Also fixes all existing uses of the deprecated methods.
See merge request !4087
Update build log incrementally
Proof of concept implementation of incremental sending of build log to browser.
cc @jschatz1 @vsizov @grzesiek @tmaczukin
See merge request !3737
- Fix naming of API::CommitStatuses
- Ensure we use require_dependency instead of require
- Ensure the namespace is right in lib/api/api.rb, otherwise, we
might require Grape::API::Helpers which defines the `#params` method.
This is to avoid requiring a file multiple times and getting an "Already
initialized constant" error.
Signed-off-by: Rémy Coutable <remy@rymai.me>
We send a state of ansi2html to client, client needs to send this state back.
The state describes the configuration of generator and position within trace.
This reports uses of `File.exists?` and `Dir.exists?`, which were both
deprecated in Ruby and will eventually be removed in favor of
`.exist?`. Also fixes all existing uses of the deprecated methods.
Make all of the nested constant instrumentation for core app code work
the same way, add mailer instrumentation, and add instrumentation to the
premailer gem.
Add more parameters to the filter_parameters config.
Adds Sentry DSN, Webhooks, Deploy Keys, etc.
Alphabetized the parameters and included line breaks between each parameter. Easier to merge into EE if there are any differences.
This also seems to be the more popular syntax for adding new parameters, from what I can find.
In the future we may want to [increase the specificity of some of these](http://blog.bigbinary.com/2016/03/07/parameter-filtering-enhacement-rails-5.html) once Rails 5 is out. e.g. instead of `:hook`, `"hook.url"` would be just as effective without removing potentially useful information from the logs.
cc: @stanhu
See merge request !3971
Adds Sentry DSN, Webhooks, Deploy Keys, etc.
Alphabetized the parameters and included line breaks between each parameter. Easier to merge into EE if there are any differences.
This also seems to be the more popular syntax for adding new parameters, from what I can find.
This button depends on Issue#can_be_worked_on? which in turn depends on
Issue#related_branches. By rendering this button asynchronously we can
finally remove all usages of Issue#related_branches and
Issue#referenced_merge_requests from the issues "show" page.
Yorick Peterse
Kamil Trzcinski
Gabriel Mazetto
Robert Speicher
Douwe Maan
Jacob Schatz
DJ Mountney
Douwe Maan
Rémy Coutable
Long Nguyen
Stan HuandRémy Coutable
Dmitriy Zaporozhets
Connor Shea
Robert Speicher
Artem Sidorenko
Sean McGivern
Jacob Vosmaer
Timothy AndrewandKamil Trzcinski
