Dmitriy Zaporozhets
218219abbd
Refactoring inside refactoring. We need to go deeper
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-09-08 21:54:52 +03:00
Dmitriy Zaporozhets
bde3f25d26
Specs for diff parser! Yay!
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-09-08 20:42:12 +03:00
Dmitriy Zaporozhets
531f16beb0
Use new diff parsing logic
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-09-08 16:27:12 +03:00
Dmitriy Zaporozhets
4ef809c77d
Gitlab::Diff classes added
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-09-08 16:25:50 +03:00
Marin Jankovski
721b75733c
Take the next type into consideration
2014-09-08 09:05:17 +02:00
Marin Jankovski
f827482c12
Remove duplication, expand for next_line.
2014-09-08 09:05:16 +02:00
Marin Jankovski
1067b00724
Duplicate the behaviour and refactor for use with parallel diff.
2014-09-08 09:05:16 +02:00
Dmitriy Zaporozhets
9f505954a6
Fix tests for CI
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-09-06 13:20:37 +03:00
Sean Edge
468b2e8e0b
Added annotated tags. Updated tag haml file and call to gitlab-shell. Updated API for annotated tags. Added tests for API. Strip leading/trailing whitespace from message, if present. Update CHANGELOG.
2014-09-04 09:47:20 -04:00
Robert Schilling
551145bc98
Validate branch-names and references in WebUI, API
...
Add specs for GitRefValidator
2014-09-03 13:08:35 +02:00
Dmitriy Zaporozhets
596bf4c2a5
Merge branch 'feaure-ldap-oauth-tests'
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
Conflicts:
spec/lib/gitlab/oauth/user_spec.rb
2014-09-03 13:52:40 +03:00
Dmitriy Zaporozhets
6438ac72fc
Merge branch 'master' of github.com:gitlabhq/gitlabhq
2014-09-02 12:22:45 +03:00
Dmitriy Zaporozhets
3a3c4ea436
Merge branch 'gitlab-shell-2-0' into 'master'
...
Modify GitLab to work with gitlab-shell 2.0
Related to #1516
See merge request !1057
2014-09-02 09:20:15 +00:00
Dmitriy Zaporozhets
19bda55fb6
Merge pull request #7663 from Razer6/all_is_not_a_valid_user
...
'all' is not a valid username
2014-09-02 11:54:06 +03:00
Dmitriy Zaporozhets
0306a4e2e4
Rewrite GitAccess for gitlab-shell v2
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-09-01 19:57:25 +03:00
Robert Schilling
3e127a054b
'all' is not a valid username
2014-09-01 18:07:00 +02:00
Jan-Willem van der Meer
c0323b40ee
Refactor: beter naming for active directory disabled users
2014-09-01 16:35:18 +02:00
Jan-Willem van der Meer
26b14dd2d5
Get uid from auth instead of info hash
...
As found in the omniauth specs: https://github.com/intridea/omniauth/wiki/Auth-Hash-Schema
2014-09-01 16:31:27 +02:00
Jan-Willem van der Meer
ca17e4b7ad
Remove duplicate method
2014-09-01 14:30:31 +02:00
Jan-Willem van der Meer
262276c5f5
Ensure oath callbacks without a nickname work (google)
2014-09-01 14:26:10 +02:00
Jan-Willem van der Meer
5801d520a7
Handle user creation if email is not provided
...
This fixes #1541
2014-09-01 14:05:01 +02:00
Jan-Willem van der Meer
6143cef4c4
Handle user creation if email is not provided
...
This fixes #1541
2014-09-01 13:49:16 +02:00
Jan-Willem van der Meer
0c34fa3ea0
Add tests for finding an oauth authenticated user
2014-09-01 12:59:04 +02:00
Dmitriy Zaporozhets
14f5199cdc
Merge branch 'feature-ldap-tests' into 'master'
...
Feature ldap tests
Move specs to proper places. Relates to #154
This is already mergeable, will continue in a new branch for additions & refactorings.
See merge request !1053
2014-08-30 07:16:45 +00:00
Jan-Willem van der Meer
0d5ae2802e
Move and rename ldap / oauth specs
2014-08-29 17:30:42 +02:00
Jacob Vosmaer
614ca3ec65
Remove LDAP::Access#find_user
...
This method existed to allow LDAP users to take over existing GitLab
accounts if the part before the '@' of their LDAP email attribute
matched the username of an existing GitLab user. I propose to disable
this behavior in order to prevent unintended GitLab account takeovers.
After this change it is still possible to take over an existing GitLab
account with your LDAP credentials, as long as the GitLab account email
address matches the LDAP user email address.
2014-08-29 15:38:05 +02:00
Job van der Voort
68fd66c6e3
block visibility level restriction override in controller
2014-08-28 20:33:41 +02:00
Dmitriy Zaporozhets
c5c906fe64
Fix tests
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-08-27 15:26:35 +03:00
Dmitriy Zaporozhets
8b00d01c67
Search by issue/mr title and description
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-08-27 12:47:30 +03:00
Dmitriy Zaporozhets
9e5bc43263
Pass scope and page to Gitlab::SearchResults#objects instead of initialize
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-08-27 00:04:14 +03:00
Dmitriy Zaporozhets
9a4ef7e7eb
Search results libraries added
...
Gitlab::SearchResults and Gitlab::ProjectSearchResults are libraries we
are going to use to get search results based on query, enitity type and
pagination.
It will allow us to get only issues from project #23 where title or
description includes 'foo'.
Ex:
search_results = Gitlab::ProjectSearchResults.new(project.id, 'foo', 'issues')
search_results.objects => # [<Issues #23>, <Issues #34>]
search_results.issues_count => 2
search_results.total_count => 12 (it includes results from comments and
merge requests too)
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-08-26 23:32:41 +03:00
Dmitriy Zaporozhets
3cbacad86c
Merge branch 'blacklist/unsubscribes' into 'master'
...
Add 'unsubscribes' to the paths blacklist
This is to prevent issues with the admin email feature in GitLab EE.
See merge request !1034
2014-08-23 20:47:40 +00:00
Jacob Vosmaer
3dbd8d2293
Always set the origin remote in satellite actions
...
This prevents issues with satellites containing outdated origin remotes
after administrators move the git repositories directory.
2014-08-22 14:32:04 +02:00
Jacob Vosmaer
abb415276f
Add 'unsubscribes' to the paths blacklist
...
GitLab EE has a /unsubscribes/ route.
2014-08-22 10:25:13 +02:00
Jacob Vosmaer
e4f75fd262
Use one word per line in Gitlab::Blacklist
2014-08-22 10:21:04 +02:00
skv
4e40800166
diff unfold
2014-08-14 15:48:14 +04:00
Dmitriy Zaporozhets
ffc284301e
Merge branch 'ldap/cache_check' into 'master'
...
Cache LDAP check everywhere
See merge request !1008
2014-08-13 13:11:04 +00:00
Dmitriy Zaporozhets
4535db04b2
Increase import timeout from 2 to 4 minutes
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-08-11 20:58:39 +03:00
Robert Schilling
99eb283101
Use readme we support to render if there are multiple readmes
2014-08-11 08:50:56 +02:00
Jacob Vosmaer
82dc40936a
Cache LDAP check in Gitlab::UserAccess
...
This changes the number of LDAP calls when users access GitLab via
Git-over-SSH or the API. LDAP check results are cached for 1 hour.
2014-08-06 18:03:01 +02:00
Jacob Vosmaer
669682686e
Move LDAP timeout code to Gitlab::LDAP::Access
2014-08-06 18:03:01 +02:00
Dmitriy Zaporozhets
8f1e60b057
Fix satellite tests
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-08-06 09:52:56 +03:00
Dmitriy Zaporozhets
b2a6f4e136
Refactor label rendering and default label set generation
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-07-29 22:19:47 +03:00
Dmitriy Zaporozhets
d45a6b2941
Migrate issue/mr labels from act_as_taggable to own labels
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-07-29 19:19:26 +03:00
Dmitriy Zaporozhets
2f780af246
Git::Compare does not have limit param any more
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-07-29 14:29:59 +03:00
Dmitriy Zaporozhets
bf9ce1f4cf
Refactor compare logic for MR. Use satellites only for forks for better performance
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-07-29 12:11:16 +03:00
Dmitriy Zaporozhets
d30454e112
Override Gitlab::Git::Compare limit
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-07-29 10:29:12 +03:00
Dmitriy Zaporozhets
06154af09a
Merge branch 'satellite_compare_gitlab_git' into 'master'
...
Use Gitlab::Git::Compare in Satellite::CompareAction
See merge request !976
2014-07-29 07:28:15 +00:00
Jacob Vosmaer
03ae6b89bd
Log Sidekiq arguments
2014-07-28 16:46:36 +02:00
Dmitriy Zaporozhets
931f27ae32
Merge pull request #7141 from PuzzleFlow/uid_should_always_be_string
...
Ensure that uid in OAuth is a string
2014-07-23 20:26:16 +03:00