Dmitriy Zaporozhets
5999fec7a3
Merge branch 'rs-form_errors' into 'master'
...
Standardize the way we check for and display form errors
- Some views had a "Close" button. We've removed this, because we don't
want users accidentally hiding the validation errors and not knowing
what needs to be fixed.
- Some views used `li`, some used `p`, some used `span`. We've
standardized on `li`.
- Some views only showed the first error. We've standardized on showing
all of them.
- Some views added an `#error_explanation` div, which we've made
standard.
See merge request !3531
2016-04-11 12:01:50 +00:00
Felipe Artur
32c7e42b61
Improve code
2016-04-05 11:53:39 -03:00
Robert Speicher
7a2370f740
Standardize the way we check for and display form errors
...
- Some views had a "Close" button. We've removed this, because we don't
want users accidentally hiding the validation errors and not knowing
what needs to be fixed.
- Some views used `li`, some used `p`, some used `span`. We've
standardized on `li`.
- Some views only showed the first error. We've standardized on showing
all of them.
- Some views added an `#error_explanation` div, which we've made
standard.
2016-04-04 21:37:07 -04:00
Jacob Schatz
00246d3f01
Merge branch 'fix_missing_tooltip_next_to_project_title' into 'master'
...
Fix missing tooltip in project title
closes #14516

See merge request !3351
2016-03-23 19:16:05 +00:00
Arinde Eniola
b1a93fffac
fix missing tooltip in project title
2016-03-22 22:54:34 +01:00
Jacob Schatz
fb1a7553c7
Merge branch 'issue_13885' into 'master'
...
Display nav controls on mobile
Set inputs inside .nav-controls to full-width on viewports below 600px
Fixes #13885
**Affected pages**
/dashboard/groups
/admin/builds
/dashboard/projects
/dashboard/issues
/dashboard/merge_requests
/dashboard/milestones
/dashboard/todos
/explore
/groups/{group-name}/issues
/groups/{group-name}
/groups/{group-name}/milestones
/{group-name}/{project-name}/builds
/{group-name}/{project-name}/forks
/{group-name}/{project-name}/issues
/{group-name}/{project-name}/labels
/{group-name}/{project-name}/merge_requests
/{group-name}/{project-name}/milestones
/{group-name}/{project-name}/wikis/home
/{group-name}/{project-name}/wikis/pages
Some Screenshots
**Groups**

**Admin > Builds**

**TODOs**

**Dashboard > Projects**

**Project Issues**

**Project Merge Requests**

See merge request !3214
2016-03-22 19:49:46 +00:00
Douwe Maan
31266c5be4
Address feedback
2016-03-22 00:09:20 +01:00
Douwe Maan
8db1292139
Tweaks, refactoring, and specs
2016-03-20 21:04:07 +01:00
Zeger-Jan van de Weg and Felipe Artur
b959ae553b
Improve group visibility level feature
2016-03-18 16:58:04 -03:00
Alfredo Sumaran
cc66dbeac9
Add missing label
2016-03-18 14:45:44 -05:00
Felipe Artur
0a7f716119
Code fixes
2016-03-17 19:42:46 -03:00
Felipe Artur
44c127447b
Merge 4009-external-users into issue_12658
2016-03-16 20:16:42 -03:00
Felipe Artur
ec20fdf366
Code improvements and add Create group service
2016-03-16 19:44:33 -03:00
Dmitriy Zaporozhets
6c791f7da7
Redesign project tabs on group page
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2016-03-14 18:31:14 +01:00
Dmitriy Zaporozhets
d324bf8434
Merge branch 'share-project-ce' into 'master'
...
Bring from EE: Share Project with Group
- [x] Models and migrations
- [x] Logic, UI
- [x] Tests
- [x] Documentation
- [x] Share with group lock
- [x] Api feature
- [x] Api docs
- [x] Api tests
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
For #12831
cc @DouweM @rspeicher @vsizov
See merge request !3186
2016-03-14 16:38:52 +00:00
Dmitriy Zaporozhets
9a95b15552
Add share project from group lock
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2016-03-11 19:03:19 +01:00
Dmitriy Zaporozhets
f8163c81e7
Show shared projects on group page
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2016-03-11 18:42:16 +01:00
Felipe Artur
c3e70280df
Prevent projects to have higher visibility than groups
...
Prevent Groups to have smaller visibility than projects
Add default_group_visibility_level to configuration
Code improvements
2016-03-10 10:38:36 -03:00
Felipe Artur
f2a9ee258e
Add permission level to groups
2016-03-10 10:38:36 -03:00
Dmitriy Zaporozhets
90ffb1c0db
Fix header title
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2016-03-10 14:35:23 +01:00
Dmitriy Zaporozhets
e3efce9237
Move group activity feed to separate page for consistency with dashboard and project pages
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2016-03-10 14:29:38 +01:00
Dmitriy Zaporozhets
c674ffe0e0
Merge branch 'improve-archived-projects'
2016-03-09 09:51:59 +01:00
Rubén Dávila
95b06a62c0
Updates from last code review.
2016-03-06 23:07:19 -05:00
Rubén Dávila
96058605c3
Show some stats about Milestone according to the new UI.
2016-03-04 22:37:03 -05:00
Rubén Dávila
7cc102a0e6
Make Merge Requests tab have the same look as Issues.
2016-03-04 22:37:03 -05:00
Rubén Dávila
e0a18829ee
Show project name for Issues tab in Group and Dashboard context.
2016-03-04 22:37:03 -05:00
Rubén Dávila
ed48085558
Refactor Merge Requests tab into a custom partial
...
* Add Labels tab to Groups
* Add decorator for label so it's aware of Milestones.
2016-03-04 22:37:03 -05:00
Rubén Dávila
834b5d49ec
Refactor Merge Requests tab into a custom partial
2016-03-04 22:37:03 -05:00
Rubén Dávila
e805becfe8
Eager load Issues/MRs project for Milestone.
...
With this change we avoid doing N+1 queries when viewing Milestone's
Issues/MRs from a Group context.
2016-03-04 22:37:03 -05:00
Rubén Dávila
37d92d0b7b
Refactor Merge Requests tab into a custom partial
2016-03-04 22:37:03 -05:00
Rubén Dávila
70028d36be
Recator Issues Tab into a custom partial.
2016-03-04 22:37:03 -05:00
Rubén Dávila
a056dfa9a0
Refactor GlobalMilestone queries.
...
Make methods return ActiveRecord Relations instead of Arrays.
2016-03-04 22:37:03 -05:00
Dmitriy Zaporozhets
2c431f89b1
Add projects list sort dropdown to group page
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2016-03-04 19:26:10 +01:00
Dmitriy Zaporozhets
022e38540a
Remove unnecessary project limit argument from group projects page
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2016-03-03 13:47:32 +01:00
Dmitriy Zaporozhets
7455d950bc
Refactor projects list
...
1. Fix double bottom border if pagination
2. Fix broken search on forks page
4. Remove duplicate js logic
4. Remove unused show all link
5. Remove duplicate “no project” message in different views
After this merge request you can easily render shared projects template
with all necessary html/js included to make searchable list with
pagination. All you need to provide is controller that returns
projects list with seach nad pagination and render html form with
project-filter-form id and text field with filter_projects name.
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2016-03-03 13:09:58 +01:00
Robert Speicher
76ed2afcfc
Change js-quick-submit behavior to expect the class on the form
...
Now it will work on any field inside that form, and it's easier to scope
new behavior, which is what we're adding next!
2016-03-02 15:11:15 -05:00
Drew Blessing
9b9abb1654
Only show group member roles if explicitly requested
2016-03-01 13:47:53 -06:00
Jacob Schatz and Alfredo Sumaran
0267954403
Fix group projects styles
...
Makes new project button visible when no projects are available.
Fixes #13193
2016-02-23 18:47:48 -05:00
Josh Frye
cf8a74be5f
Cleanup to use one selector
2016-02-09 20:21:47 -05:00
Josh Frye
120dca0f35
MR feedback
2016-02-09 10:10:41 -05:00
Josh Frye
8b4e9720d9
Extract events rendering to own action.
2016-02-09 10:10:41 -05:00
Josh Frye
30e022a2fe
Starred, All, and Trending on explore are paged also group projects. Need ajax filter.
2016-02-09 10:10:41 -05:00
Dmitriy Zaporozhets
9258636021
Re-use top-are css component for issues/mr pages
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2016-02-05 11:35:55 +01:00
Dmitriy Zaporozhets
8cd25901d3
Use top-area component for top page navigation for pages that contains list of items
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2016-02-03 18:41:55 +01:00
Dmitriy Zaporozhets
4beae990b3
Refactor nav controls section (search and new project/group btn)
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2016-02-03 16:14:11 +01:00
Yorick Peterse
de7c9c7ab1
Use Atom update times of the first event
...
By simply loading the first event from the already sorted set we save
ourselves extra (slow) queries just to get the latest update timestamp.
This removes the need for Event.latest_update_time and significantly
reduces the time needed to build an Atom feed.
Fixes gitlab-org/gitlab-ce#12415
2016-01-27 10:33:33 +01:00
Dmitriy Zaporozhets
cf673ba9f6
Fix UI for pages with panels
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2016-01-22 13:37:40 -08:00
Dmitriy Zaporozhets
49c310e45c
Fix missing padding for user/group pages
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2016-01-14 16:42:25 +01:00
Dmitriy Zaporozhets
620d8b68a1
Merge branch 'remove-gray-bg'
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2016-01-14 14:09:49 +01:00
Dmitriy Zaporozhets
9c69c89941
Add margin to pages where is no header
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2016-01-14 12:48:02 +01:00