Dmitriy Zaporozhets
5999fec7a3
Merge branch 'rs-form_errors' into 'master'
...
Standardize the way we check for and display form errors
- Some views had a "Close" button. We've removed this, because we don't
want users accidentally hiding the validation errors and not knowing
what needs to be fixed.
- Some views used `li`, some used `p`, some used `span`. We've
standardized on `li`.
- Some views only showed the first error. We've standardized on showing
all of them.
- Some views added an `#error_explanation` div, which we've made
standard.
See merge request !3531
2016-04-11 12:01:50 +00:00
Phil Hughes
643fe43d78
Addressed feedback
...
Removed important from css
2016-04-11 09:43:59 +01:00
Robert Speicher
7a2370f740
Standardize the way we check for and display form errors
...
- Some views had a "Close" button. We've removed this, because we don't
want users accidentally hiding the validation errors and not knowing
what needs to be fixed.
- Some views used `li`, some used `p`, some used `span`. We've
standardized on `li`.
- Some views only showed the first error. We've standardized on showing
all of them.
- Some views added an `#error_explanation` div, which we've made
standard.
2016-04-04 21:37:07 -04:00
Robert Speicher
8406318d87
Remove tabstop from the WIP toggle links
...
[ci skip]
2016-03-28 17:04:27 -04:00
Alfredo Sumaran
5f6166a256
Fix cancel link
2016-03-28 01:35:53 -05:00
Alfredo Sumaran
35ef7ff6cb
Fix link when issuable is new
2016-03-24 14:40:20 -05:00
Alfredo Sumaran
7f43049012
Fix cancel link on issuable edit form
2016-03-24 14:29:09 -05:00
Zeger-Jan van de Weg
73a8088e2c
User has to confirm deletion of issuables
2016-03-22 14:06:03 +01:00
Zeger-Jan van de Weg
6e5461c6ee
Merge branch 'master' into 2489-soft-delete-issues
2016-03-21 19:32:37 +01:00
Zeger-Jan van de Weg
3b088fc5b5
Minor improvements on IssuableActions
2016-03-21 16:59:35 +01:00
Grzegorz Bizon
91963267a0
Change icon and cursor for issue move field tooltip
2016-03-20 17:38:08 +01:00
Grzegorz Bizon
797af06491
Merge branch 'master' into feature/issue-move
...
* master:
Fix bug where wrong commit ID was being used in a merge request diff to show old image
Remove CHANGELOG item that was added during merge resolution
Improve the "easy WIP & un-WIP from link" feature
Fix specs
\#to_branch_name now uses the iid as postfix
Add label description in tooltip to labels in issue index and sidebar
Easily (un)mark merge request as WIP using link
Use specialized system notes when MR is (un)marked as WIP
another attempt to fix oauth issue
attempting to fix omniauth problem
Conflicts:
app/assets/javascripts/issuable_form.js.coffee
2016-03-20 11:01:08 +01:00
Grzegorz Bizon
802b28e04a
Add tooltip info about issue move filed purpose
2016-03-20 10:01:12 +01:00
Zeger-Jan van de Weg
7342a4566c
Dry destroy action on issuables
2016-03-19 21:24:05 +01:00
Zeger-Jan van de Weg
67043ec53b
Hide delete botton on edit page
2016-03-19 21:23:03 +01:00
Grzegorz Bizon
0115ad66d2
Merge branch 'master' into feature/issue-move
...
* master: (121 commits)
Dedupe labels in labels selector in Dashboard pages
Refactor colors and lists
Add a safeguard in MergeRequest#compute_diverged_commits_count
Fix an issue when the target branch of a MR had been deleted
Add avatar to issue and MR pages header
Cleanup somce css colors
Re-group scss variables
Refactor `Todo#target`
Fixes issue with filter label missing on labels & milestones
Rename `Todo#to_reference` to `Todo#target_reference`
Fixed failing tests
Updated controller with before_action Fixed other issues based on feedback
Fixes issue on dashboard issues
Full labels data in JSON
Fixed issue with labels dropdown getting wrong labels
Update CHANGELOG
Use `Note#for_project_snippet?` to skip notes on project snippet
Use `Commit#short_id` instead of `Commit.truncate_sha`
Reuse `for_commit?` on conditional validations
Update schema info comment on todo related files
...
Conflicts:
app/models/issue.rb
db/schema.rb
spec/models/issue_spec.rb
2016-03-19 18:50:15 +01:00
Grzegorz Bizon
9b13ce0b7a
Improvements in issue move feaure (refactoring)
...
According to endbosses' suggestions.
2016-03-19 18:46:01 +01:00
Rémy Coutable
cafa408b25
Merge remote-tracking branch 'origin/master' into remove-wip
2016-03-18 23:29:18 +01:00
Rémy Coutable
0b942541da
Improve the "easy WIP & un-WIP from link" feature
2016-03-18 23:27:35 +01:00
Douglas Barbosa Alexandre
6b86d3fb80
Add an option to user make an issue confidential
2016-03-17 20:55:38 -03:00
Grzegorz Bizon
b9036ba610
Prevent issue move if issue has been already moved
2016-03-17 11:48:51 +01:00
Grzegorz Bizon
5e3c9475a9
Add minor improvements in code related to issue move
2016-03-17 07:39:16 +01:00
Grzegorz Bizon
1dd279d833
Use helper to create list of projects issue can be moved to
...
This also adds confirmation message if issue move has been requested.
2016-03-17 07:39:16 +01:00
Grzegorz Bizon
58df72fac1
Make it possible to exclude project in projects select
2016-03-17 07:39:16 +01:00
Grzegorz Bizon
bcd5806960
Add access-level filter support for projects select
...
This also refactores ProjectSelect adding some decorator-like functions.
2016-03-17 07:39:16 +01:00
Grzegorz Bizon
a91101b19a
Make it possible to move issue if user is a reporter
...
Discussed it here:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/2831#note_4190228
2016-03-17 07:39:16 +01:00
Grzegorz Bizon
8a02449440
Do not show issue move form unless user can move
2016-03-17 07:39:15 +01:00
Grzegorz Bizon
11f817b3fd
Add ability to choose id attribute in project select helper
2016-03-17 07:39:15 +01:00
Grzegorz Bizon
5dea8fb9ed
Add mock-up for interface being used to move issue
2016-03-17 07:39:15 +01:00
Robert Speicher
76ed2afcfc
Change js-quick-submit behavior to expect the class on the form
...
Now it will work on any field inside that form, and it's easier to scope
new behavior, which is what we're adding next!
2016-03-02 15:11:15 -05:00
Douwe Maan
09ff9bc722
Easily (un)mark merge request as WIP using link
...
Fixes #3768
2016-02-26 19:36:38 -08:00
Douwe Maan
79c90821ac
Rename .issuable-details to .detail-page (and -header and -description)
2015-12-16 16:13:22 +01:00
Dmitriy Zaporozhets
238ca3e472
Merge remote-tracking branch 'origin/ui/issuable-form'
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-12-04 15:12:03 +01:00
Douwe Maan
879d1f9b76
Merge branch 'master' into ui/issuable-form
2015-12-03 13:25:31 +01:00
Douwe Maan
0520cd7164
Merge branch 'master' into ui/form-consistency
2015-12-03 13:21:19 +01:00
Douwe Maan
0159d78a3b
Remove padding around form-actions
2015-12-02 14:48:06 +01:00
Douwe Maan
da48fdc2a5
Don't write "Optional" or "Required" unless non-obvious
2015-12-02 14:41:55 +01:00
Douwe Maan
ffabf1df50
Add cancel button to forms that didn't have one already
2015-12-02 14:41:54 +01:00
Douwe Maan
67119e15c0
Use consistent casing for form field labels
2015-12-02 14:41:54 +01:00
Douwe Maan
6c54823dce
Use select2 placeholder instead of blank option
2015-12-02 14:24:29 +01:00
Douwe Maan
89488a7cf9
Move "Please review the contribution guide" next to MR/issue Submit button
2015-12-02 14:21:03 +01:00
Dmitriy Zaporozhets
4099751ce9
Render same markdown hint for issue, merge request, wiki and comment forms
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-11-07 20:22:16 +01:00
Robert Speicher
de3ff174e7
Quick Submit all the things!
...
Adds quick submit behavior to the forms for:
- Blobs ("new file")
- Commit messages
- Issuables
- Notes
- Labels
- Milestones
- Wikis
2015-10-07 15:23:42 -04:00
Stan Hu
0346e9724a
Tweak remaining CSS for Markdown preview
...
Missed a few items in !1378
2015-09-21 14:08:26 -07:00
Darby
def939a562
Turned off autocomplete for new issue titles
2015-09-09 15:04:38 -07:00
Douwe Maan
0daa21ed8c
Merge branch 'fix-email-autocomplete' into 'master'
...
Fix bug preventing invite by e-mail
This was broken in 70f5291808 as a result of introducing the ability to filter by current user.
Closes #2320
See merge request !1181
2015-08-21 22:25:59 +00:00
Stan Hu
577df6b8ca
List the current user first in issuable dropdowns
2015-08-21 14:27:21 -07:00
Stan Hu
3715a0f29b
Fix bug preventing invite by e-mail
...
This was broken in 70f5291808 as a result of introducing the ability to filter by current user.
Closes #2320
2015-08-21 13:47:56 -07:00
Douwe Maan
77e508d8fd
Fix bug where non-project members of the target project could set labels on new merge requests.
2015-08-20 18:32:32 -07:00
Dmitriy Zaporozhets
91836272fe
Merge branch 'mr-widget-text' into 'master'
...
Improve text of MR merge widget and manual merge modal
Modal with manual merge instructions:

Archived:

WIP:

Missing target branch:

Missing source branch:

Nothing to merge:

Checking ability to merge:

Conflicts when allowed to merge:

Conflicts when not allowed to merge:

Mergeable when allowed to merge:

Mergeable when not allowed to merge:

Merge in progress:

Merge failed:

Merged:

Closed:

cc @dzaporozhets @rspeicher
See merge request !1120
2015-08-11 19:24:50 +02:00