Douwe Maan and Robert Speicher
4ed89992f3
Check permissions on target project in merge request create service.
2015-08-21 11:03:23 -07:00
Dmitriy Zaporozhets
9d029a05f1
Revert "Merge branch 'web-editor-rugged' into 'master'"
...
This reverts commit 5a1aa49b55 , reversing
changes made to a675bea2c1 .
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-08-11 13:04:38 +02:00
Dmitriy Zaporozhets
9bc512314a
Revert "Create and edit files in web editor via rugged"
...
This reverts commit 734a4ba87d .
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-08-11 11:52:33 +02:00
Dmitriy Zaporozhets
0806605962
Revert "Fix adding new file to empty repo"
...
This reverts commit 27a158506e .
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-08-11 11:51:26 +02:00
Dmitriy Zaporozhets
815e678c4e
Revert "Use rugged in web editor for base64 encoding"
...
This reverts commit 541133197b .
2015-08-11 11:50:48 +02:00
Dmitriy Zaporozhets
34975f0180
Revert "Create activity event and execute hooks on web editor commit"
...
This reverts commit 3d416f1682 .
2015-08-11 11:50:43 +02:00
Dmitriy Zaporozhets
24332b7b99
Revert "Make web editor work correctly after switch from satellites"
...
This reverts commit 435f680b89 .
2015-08-11 11:49:29 +02:00
Dmitriy Zaporozhets
d4cfa0bf76
Revert "Refactor web editor"
...
This reverts commit dfccb06dda .
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-08-11 11:49:09 +02:00
Dmitriy Zaporozhets
3b02ad8467
Revert "Merge branches inside one repository using rugged instead of satellites"
...
This reverts commit d24c40ec21 .
2015-08-11 10:50:39 +02:00
Dmitriy Zaporozhets
9f10943c1a
Revert "Merge branch 'drop-satellites'"
...
This reverts commit 957e849f41 , reversing
changes made to 6b9dbe9f5a .
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-08-11 10:28:42 +02:00
Dmitriy Zaporozhets
59e7b7a654
Refactor Trigger post-receive hooks after commits are made by GitLab
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-08-10 13:15:36 +02:00
Dmitriy Zaporozhets
99585a738c
Trigger post-receive hoooks when commits are made by GitLab
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-08-10 10:54:42 +02:00
Robert Speicher
a71bed53e0
Merge branch 'merge-notifs' into 'master'
...
See merge request !1077
2015-08-07 18:47:02 -04:00
Douwe Maan
8b6ae0104d
Merge branch 'master' into comment-updated-by
2015-08-06 12:52:26 +02:00
Douwe Maan
4f24eb2aa6
Merge branch 'master' into merge-notifs
2015-08-06 12:16:36 +02:00
Dmitriy Zaporozhets
ab8c71de4e
Fix merge request creation without branch selected
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-08-05 11:03:41 +02:00
Dmitriy Zaporozhets
b48b07044b
Merge branch 'master' into drop-satellites
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-08-04 16:42:36 +02:00
Douwe Maan
d9e26ca6d2
Reset correct event cache
2015-07-31 14:29:18 +02:00
Douwe Maan
fa9004c78c
Send notification to all participants when MR is merged.
2015-07-30 15:29:43 +02:00
Douwe Maan
36bd6c8494
Show who last edited a comment if it wasn't the original author
2015-07-30 14:45:54 +02:00
Valery Sizov
e1cdc26e48
Merge branch 'rs-dev-issue-306' into 'master'
...
Create project services on Project creation
Closes internal https://dev.gitlab.org/gitlab/gitlab-ee/issues/306#note_53354
See merge request !1045
2015-07-27 07:36:14 +00:00
Robert Speicher
88aed40962
Create project services on Project creation
2015-07-25 16:43:55 -04:00
Robert Speicher
b9b2d08638
Dynamically check :admin_* ability in IssuableBaseService
...
Closes #2092
2015-07-24 15:50:12 -04:00
Douwe Maan
0484ae7e6a
Return true/false from AutoMergeService#merge!
2015-07-23 13:10:32 +02:00
Douwe Maan
276ca427ea
Fix Remove source-branch for MRs from same project
2015-07-22 14:07:41 +02:00
Dmitriy Zaporozhets
f0116f1335
Store commit count in project table
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-07-17 15:22:56 +02:00
Dmitriy Zaporozhets
67ca5a53f6
Build missing cache items in background job after each push
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-07-17 14:50:03 +02:00
Dmitriy Zaporozhets
989329c9d9
Fix refresh service
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-07-16 16:34:58 +02:00
Dmitriy Zaporozhets
a7fded9b95
Huge refactoring for accepting merge requests
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-07-16 16:03:07 +02:00
Dmitriy Zaporozhets
26f5d6047d
Refactor compare and fetch logic
2015-07-15 17:28:09 +02:00
Dmitriy Zaporozhets
2a6f522cac
Implement merge from forks without satellites
2015-07-15 16:45:50 +02:00
Dmitriy Zaporozhets
a87989fb7d
Remove satellites
2015-07-15 15:45:57 +02:00
Dmitriy Zaporozhets
277f311f20
Fetch reference from fork repo when create merge request
2015-07-15 15:27:14 +02:00
Robert Speicher
f3d4767d0c
Rename notice_added_references to create_new_cross_references!
2015-07-13 21:31:16 -04:00
Douwe Maan and Robert Speicher
b93053695a
Fix transferring of project to another group using the API.
2015-07-11 16:47:33 -04:00
Robert Speicher
8a148793af
Simplify Issue and MergeRequest UpdateServices
...
Now that those pesky task states are gone, these become a lot simpler.
2015-07-08 18:00:42 -04:00
Robert Speicher
0e5fbb29f4
Remove unused task_[un]check states from Update services
...
These were left over from the old Task handling.
2015-07-08 17:56:56 -04:00
Valery Sizov
411829fdb5
Audit log for user authentication
2015-07-06 12:36:08 +03:00
Dmitriy Zaporozhets
d24c40ec21
Merge branches inside one repository using rugged instead of satellites
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-07-01 16:23:58 +02:00
Dmitriy Zaporozhets
083d4604c4
Change dynamic abilities to new format
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-06-26 17:18:40 +02:00
Dmitriy Zaporozhets
342d553709
Rename abilities to correspond contoller/model action names
...
write_ was renamed to create_
modify_ was renamed to update_
So now in update action we have next code
def create
can?(current_user, :create_issue, @issue)
end
def update
can?(current_user, :update_issue, @issue)
end
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-06-26 15:55:56 +02:00
Dmitriy Zaporozhets
d5947ada44
Simplify set of assignee, milestone and label to admin_issue rule
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-06-26 15:45:45 +02:00
Dmitriy Zaporozhets
0bcfe9a0dc
Dont allow set assignee, milestone or labels if user is guest
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-06-25 16:17:48 +02:00
Adam Meily
0cf2e62fb2
Updated merge request merged web hook to correctly fire action=merged.
...
Fixes #879
Fixes #498
2015-06-24 10:15:18 -04:00
Stan Hu
e80d7a804f
Fix error when deleting a user who has projects
...
Closes #1856
Closes https://github.com/gitlabhq/gitlabhq/issues/9394
2015-06-23 04:39:49 -07:00
Robert Speicher and Dmitriy Zaporozhets
2120e2dd95
Replace remaining references to Note.create_cross_reference_note
2015-06-22 12:13:46 +02:00
Douwe Maan
903132bc07
Merge branch 'fix-ext-issue-webbased-hooks' into 'master'
...
Fix hooks for web based events with external issue references
The creation of cross references for external issues (which would fail)
is now prevented. This fixes a 500 error and the execution of hooks when
creating a merge request or commenting on one.
Fixes #1650 , GH-9333.
This regression might have been introduced by
8f8a8ab32b . There is actually a TODO by
@rspeicher mentioning external issues which is lost (unhandled) in a
later commit.
This fix is related to !766 and !804 which fix a similar issue for hooks for
Git based events.
See merge request !794
2015-06-16 11:36:31 +00:00
Douwe Maan
6617e9bbf3
Merge branch 'fix-post-receive-external-tracker' into 'master'
...
Fix post-receive errors on a push when an external issue tracker is configured
### What does this MR do?
This MR improves upon !766 , fixing errors upon a git push that occur only when an external issue tracker (not JIRA) is used. This MR takes into account that external issue trackers, such as JIRA, may close issues. Disabling the processing of post-receive commits when an external issue tracker is configured seems like the wrong behavior.
### Why was this MR needed?
When a user adds an issue reference, the refactoring in 8f8a8ab and a6defd157 caused `project.get_issue` to be called, causing `ExternalIssue` to be returned when an external issue tracker was configured. This object does not have a `close` method, as needed in `CloseService`. Nor does it make sense to associate a `SystemNote` with this object.
GitLab EE uses a [special case for JIRA](https://gitlab.com/gitlab-org/gitlab-ee/blob/master/app/services/git_push_service.rb#L87 ). I would recommend moving this logic into `CloseService` too.
### What are the relevant issue numbers?
* Closes #1700
* Closes #1720
See merge request !804
2015-06-15 07:42:24 +00:00
Daniel Gerhardt
92bb845e1e
Fix hooks for web based events with external issue references
...
The creation of cross references for external issues (which would fail)
is now prevented.
Fixes #1650 , GH-9333.
2015-06-14 17:41:11 +02:00
Stan Hu
d45112258e
Fix post-receive errors on a push when an external issue tracker is configured
...
Closes #1700
Closes #1720
2015-06-12 06:59:27 -07:00