Dmitriy Zaporozhets
06ab7d89f9
Merge branch 'rs-issue-1887' into 'master'
...
Reorder MergeRequestTabs constructor
The tab was being activated before we set the `[commits|diffs]Loaded`
variable, so even when the `/diffs` route is accessed directly, like
from the "Side-by-side" link, the tab was being loaded from its default
source.
Fixes #1887
See merge request !892
2015-06-26 16:17:07 +00:00
Dmitriy Zaporozhets
b9fa82daee
Update tests and use js-issuable class for context form
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-06-26 15:05:30 +02:00
Robert Speicher
e14d517b61
Fix merge request diff features
2015-06-25 21:30:18 -04:00
Dmitriy Zaporozhets
883438970d
Merge branch 'rubocop-for-tests' into 'master'
...
Enable rubocop for tests too
cc @DouweM @rspeicher
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
See merge request !862
2015-06-23 10:36:36 +00:00
Dmitriy Zaporozhets
f189c36d8d
Merge branch 'rs-dev-issue-2414' into 'master'
...
Allow Admin to filter users by 2FA status
> 
Closes internal https://dev.gitlab.org/gitlab/gitlabhq/issues/2414
See merge request !852
2015-06-23 08:48:22 +00:00
Dmitriy Zaporozhets
f40b99d02e
Merge branch 'master' into rubocop-for-tests
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
Conflicts:
spec/features/issues_spec.rb
spec/models/forked_project_link_spec.rb
spec/models/hooks/service_hook_spec.rb
spec/models/hooks/web_hook_spec.rb
spec/models/project_services/hipchat_service_spec.rb
spec/requests/api/project_members_spec.rb
spec/requests/api/projects_spec.rb
spec/requests/api/system_hooks_spec.rb
spec/services/archive_repository_service_spec.rb
spec/support/matchers.rb
spec/tasks/gitlab/backup_rake_spec.rb
2015-06-23 10:44:03 +02:00
Stan Hu
359ed48638
Fix Style/AlignHash cop violations
2015-06-22 22:24:39 -07:00
Robert Speicher
15a05be70d
Fix Style/Blocks cop violations
2015-06-22 16:00:54 -04:00
Robert Speicher
8832839291
Fix Style/CommentIndentation cop violation
2015-06-22 14:56:48 -04:00
Robert Speicher
0bb320cfda
Fix Style/HashSyntax violations
2015-06-22 14:54:33 -04:00
Robert Speicher
56246b70fb
Fix Style/TrailingBlankLines cop violations
2015-06-22 14:38:33 -04:00
Robert Speicher and Dmitriy Zaporozhets
bf71d53f63
Change to_not calls to not_to
...
Both work, but now we're consistent across the entire app.
2015-06-22 12:13:49 +02:00
Robert Speicher and Dmitriy Zaporozhets
1f7490a23f
Update spec/features/security specs
2015-06-22 12:13:46 +02:00
Robert Speicher and Dmitriy Zaporozhets
5a9ede4721
Update mock and stub syntax for specs
2015-06-22 12:13:46 +02:00
Robert Speicher and Dmitriy Zaporozhets
afec5efc7d
Fix features syntax
2015-06-22 12:13:45 +02:00
Robert Speicher
516b4c1248
Allow Admin to filter users by 2FA status
2015-06-19 16:35:53 -04:00
Robert Speicher
22dd2240a6
Add 2FA status to Admin::Users#show
2015-06-19 15:04:47 -04:00
swellard
98615ef536
Fix duplicate 'Email has already been taken' message when creating a user
2015-06-16 14:24:05 +01:00
Dmitriy Zaporozhets
7300729190
Merge branch 'rs-dev-issue-2228' into 'master'
...
Allow user to customize default Dashboard page
Renames the "Design" profile page to "Preferences" and adds a field to customize the default Dashboard page:
> 
See merge request !778
2015-06-15 11:29:36 +00:00
Robert Speicher
b00f447db4
Add allowing_for_delay helper method for feature specs
2015-06-14 20:33:29 -04:00
Robert Speicher
37066267e7
Use page.all and page.within in specs
2015-06-13 18:37:30 -04:00
Robert Speicher
422236c71e
Change foo.should syntax to expect(foo).to in specs
2015-06-13 18:37:30 -04:00
Robert Speicher
bf9dd4327e
Add feature specs for default dashboard preference
2015-06-13 17:59:12 -04:00
Robert Speicher
0e21436aaf
Simplify the javascript behavior for Preference updating
2015-06-13 17:58:17 -04:00
Robert Speicher
844d72716e
Add Gitlab::Themes module; remove Gitlab::Theme
...
Now we can simply loop through all themes, among other things.
This also removes the `dark_theme` / `light_theme` classes and the
`theme_type` helper, since they weren't used anywhere.
2015-06-13 17:58:16 -04:00
Robert Speicher
0c0c31ff34
Move the "Design" templates and logic to Preferences
2015-06-13 17:58:16 -04:00
Robert Speicher
821fc4b034
Add Profiles::PreferencesController
2015-06-13 17:58:15 -04:00
Dmitriy Zaporozhets
e414463d9e
Merge branch 'repo-remove'
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
Conflicts:
spec/features/projects_spec.rb
2015-06-03 16:17:36 +02:00
Dmitriy Zaporozhets
58ab8a4a9d
Fix tests and increase delay time before remove repository
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-06-03 15:09:12 +02:00
Robert Speicher
442a0663da
Add feature specs for Project and Group description rendering
2015-06-02 13:04:10 -04:00
Robert Speicher
7424d2fa5b
Add ExternalLinkFilter to Markdown pipeline
...
Forces a `rel="nofollow"` attribute on all external links.
2015-05-27 15:39:08 -04:00
Robert Speicher
5a9c5520d9
Make use of to_reference in more specs
2015-05-26 15:49:22 -04:00
Robert Speicher
68f74aa826
Add a note about the commented-out test in Markdown Feature
2015-05-26 15:49:22 -04:00
Robert Speicher
ca268b85f6
Use to_reference in Markdown feature spec
2015-05-26 15:48:30 -04:00
Robert Speicher
9789b56a31
Update ffaker gem
...
Adds a version requirement which it didn't have before, at 2.0.0. This
version has breaking API changes in that the namespace is now `FFaker`
instead of `Faker`.
2015-05-20 19:22:00 -04:00
Robert Speicher
24bef5e67a
Handle password reset for users with 2FA enabled
2015-05-11 14:31:31 -04:00
Robert Speicher
5cd526f77f
Prevent "You are already signed in." error message upon 2FA login
2015-05-09 17:32:49 -04:00
Robert Speicher
c845347b23
Generate 10 2FA backup codes instead of the default of 5
2015-05-09 17:32:48 -04:00
Robert Speicher
5f43cae6ca
Add :two_factor trait to User factory
2015-05-09 17:32:48 -04:00
Robert Speicher
b050bb5bad
Fix 2FA backup code removal
2015-05-09 17:32:48 -04:00
Robert Speicher
32971b0af4
Refactor SessionsController
...
Also adds test case for providing an invalid 2FA code and then a valid
one without re-entering username and password.
2015-05-09 17:32:09 -04:00
Robert Speicher
5520397f04
Make two-factor login work and add a feature spec
2015-05-09 17:32:08 -04:00
Robert Speicher
70bbf093aa
Remove class and id attributes from SanitizationFilter whitelist
2015-05-08 12:31:34 -04:00
Dmitriy Zaporozhets
6c32abc5f7
Merge branch 'rs-task_list' into 'master'
...
Use task_list gem for task lists
Task Lists can now be used in comments, and they'll render in previews. 👏
Closes internal https://dev.gitlab.org/gitlab/gitlabhq/issues/2271
See merge request !599
2015-05-08 09:39:48 +00:00
Robert Speicher
cb079c8208
Fix Markdown feature spec
2015-05-06 20:43:12 -04:00
Robert Speicher
1108915f75
Change wording for task list summaries
2015-05-06 17:27:10 -04:00
Robert Speicher
fdff815a4c
Add Markdown feature specs for markup inside links
...
It was already working, just want to make sure we don't break it in the
future.
2015-05-06 17:21:19 -04:00
Robert Speicher
51c3393974
Task List feature and JS specs
2015-05-06 13:16:37 -04:00
Robert Speicher
c915c7b001
Add TaskList to Markdown feature spec
2015-05-06 13:00:13 -04:00
Dmitriy Zaporozhets
e097812f57
Merge pull request #9234 from dsander/group-milestones-by-title
...
Group milestones by title in the dashboard and all other issue views
2015-05-03 14:29:31 +03:00