Jacob Vosmaer
e93523ed31
Merge commit '79190fe06b' into merge-79190fe06b-7.3.0-pre
...
Conflicts:
Gemfile
README.md
VERSION
db/schema.rb
doc/install/installation.md
lib/gitlab/git_access.rb
lib/gitlab/ldap/user.rb
spec/lib/gitlab/ldap/access_spec.rb
2014-09-15 11:24:51 +02:00
Jan-Willem van der Meer
f3346a472e
Patch oauth refactoring into EE
2014-09-11 11:53:52 +02:00
Jan-Willem van der Meer
bf0de1a500
Merge remote-tracking branch 'origin/master' into feature-oauth-refactoring
2014-09-11 11:46:08 +02:00
Dmitriy Zaporozhets
218219abbd
Refactoring inside refactoring. We need to go deeper
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-09-08 21:54:52 +03:00
Dmitriy Zaporozhets
bde3f25d26
Specs for diff parser! Yay!
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-09-08 20:42:12 +03:00
Jan-Willem van der Meer
11bb67c3c6
Test authenticate method for Gitlab::LDAP::User
2014-09-08 14:53:59 +02:00
Jan-Willem van der Meer
f27830fa4c
Ensure Gitlab::LDAP::authentication is tested
2014-09-08 13:26:25 +02:00
Jan-Willem van der Meer
f88b6d0330
Refactor gitlab auth tests
2014-09-08 13:11:39 +02:00
Jan-Willem van der Meer
5b86dab03b
Move auth hash to a seperate class
2014-09-04 12:55:10 +02:00
Jan-Willem van der Meer
6c4b51e263
Reset ldab.enabled setting after test
...
Should prevent CI failure
2014-09-04 11:38:43 +02:00
Jan-Willem van der Meer
41f46bfac3
Add basic tests for LDAP::Access.update_permissions
2014-09-03 11:47:48 +02:00
Jan-Willem van der Meer
a68b1963a3
Less private methods, more test ordering
2014-09-03 11:28:32 +02:00
Jan-Willem van der Meer
61d0bf0bad
Match method order for implementation and class
...
This will prevent a mess, and keeps everything clean.
In addition i made the non interface methods private
2014-09-03 10:38:07 +02:00
Jan-Willem van der Meer
1a59ce4ee7
Add extra tests around OAUTH / LDAP find_or_create
2014-09-03 10:29:03 +02:00
Jan-Willem van der Meer
f019821dbf
In between patches fixup
2014-09-03 10:18:20 +02:00
Jan-Willem van der Meer
9d3eb09158
Move LDAP tests to proper location
...
Same patch as gitlab-ce
https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/1053
2014-09-03 10:10:55 +02:00
Jan-Willem van der Meer
c0323b40ee
Refactor: beter naming for active directory disabled users
2014-09-01 16:35:18 +02:00
Jan-Willem van der Meer
26b14dd2d5
Get uid from auth instead of info hash
...
As found in the omniauth specs: https://github.com/intridea/omniauth/wiki/Auth-Hash-Schema
2014-09-01 16:31:27 +02:00
Jan-Willem van der Meer
92a9964940
Add basic find / create specs for LDAP user
2014-09-01 15:30:46 +02:00
Jan-Willem van der Meer
262276c5f5
Ensure oath callbacks without a nickname work (google)
2014-09-01 14:26:10 +02:00
Jan-Willem van der Meer
5801d520a7
Handle user creation if email is not provided
...
This fixes #1541
2014-09-01 14:05:01 +02:00
Jan-Willem van der Meer
0ec4abf73c
Use local vars for tests
2014-09-01 13:02:41 +02:00
Jan-Willem van der Meer
0c34fa3ea0
Add tests for finding an oauth authenticated user
2014-09-01 12:59:04 +02:00
Dmitriy Zaporozhets
14f5199cdc
Merge branch 'feature-ldap-tests' into 'master'
...
Feature ldap tests
Move specs to proper places. Relates to #154
This is already mergeable, will continue in a new branch for additions & refactorings.
See merge request !1053
2014-08-30 07:16:45 +00:00
Jan-Willem van der Meer
0d5ae2802e
Move and rename ldap / oauth specs
2014-08-29 17:30:42 +02:00
Jan-Willem van der Meer
97547428bd
Rename ldap tests even further
2014-08-29 16:04:00 +02:00
Jacob Vosmaer
614ca3ec65
Remove LDAP::Access#find_user
...
This method existed to allow LDAP users to take over existing GitLab
accounts if the part before the '@' of their LDAP email attribute
matched the username of an existing GitLab user. I propose to disable
this behavior in order to prevent unintended GitLab account takeovers.
After this change it is still possible to take over an existing GitLab
account with your LDAP credentials, as long as the GitLab account email
address matches the LDAP user email address.
2014-08-29 15:38:05 +02:00
Jacob Vosmaer
90ce0be420
Merge branch 'master' of dev.gitlab.org:gitlab/gitlab-ee into feature-120-multiple-ldap-groups
...
Conflicts:
app/models/group.rb
app/views/groups/members.html.haml
db/schema.rb
2014-08-29 14:43:20 +02:00
Jan-Willem van der Meer
6840a276d5
Fix naming convention of LDAP tests
2014-08-29 13:49:01 +02:00
Jan-Willem van der Meer
5238efd80c
Only return found LDAP groups for processing
2014-08-29 11:09:06 +02:00
Jan-Willem van der Meer
2e21c362db
Replace Group id with the answer to the answer to life the universe and everything
2014-08-15 19:50:47 +02:00
Jan-Willem van der Meer
3ba7a3a5ca
Remove traces from ldab_cn and ldap_access
...
Also add notes about refactoring the old single-ldap API and LdapGroupResetService
2014-08-15 12:33:05 +02:00
Jan-Willem van der Meer
5ff230a11d
Add more use cases for update_ldap_group_links to unit tests
2014-08-15 12:07:30 +02:00
Jan-Willem van der Meer
2541571014
Add unit test for update_ldap_group_links
...
This is the first stage, need to add some other to test revoking and
upgrading of the permissions
2014-08-15 11:31:52 +02:00
Jan-Willem van der Meer
f6252e8784
Use rspec's 'create anyway' syntax
2014-08-15 10:40:44 +02:00
Jacob Vosmaer
ee8836a903
Merge commit '27cf081e1b0b1df166' into merge_ce_27cf081e1b0b1df166
...
Conflicts:
VERSION
app/models/user.rb
app/services/merge_requests/build_service.rb
config/gitlab.yml.example
db/schema.rb
doc/integration/README.md
features/project/merge_requests.feature
features/steps/project/merge_requests.rb
2014-08-15 10:25:23 +02:00
Jan-Willem van der Meer
bb93dfb2c8
Remove old code
2014-08-14 12:54:26 +02:00
Jan-Willem van der Meer
673b9a373b
Add method to get the current cns the user has access to
2014-08-13 16:48:36 +02:00
Jan-Willem van der Meer
22b0b2b40e
Match rails naming convention
...
Otherwise IDE won't be able to find the tests
2014-08-13 11:00:19 +02:00
Robert Schilling
99eb283101
Use readme we support to render if there are multiple readmes
2014-08-11 08:50:56 +02:00
Dmitriy Zaporozhets
8f1e60b057
Fix satellite tests
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-08-06 09:52:56 +03:00
Dmitriy Zaporozhets
c23e1f3d41
Fix test
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-07-24 12:48:47 +03:00
Ayrton Araújo
07537faca7
Add support to set satellites timeout
2014-07-21 11:50:29 -04:00
Dmitriy Zaporozhets
a74b66cdee
Merge branch 'master' of dev.gitlab.org:gitlab/gitlabhq into upstream-ce
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
Conflicts:
app/models/group.rb
app/models/project.rb
features/steps/shared/project.rb
2014-07-10 23:43:42 +03:00
Jacob Vosmaer
526959ab63
Use a scope to add/remove LDAP keys
...
For some reason I needed to add a reload statement in the specs.
2014-07-09 12:13:09 +02:00
Dmitriy Zaporozhets
6a0cb25096
Dont allow ? in project path
...
Because it causes 500 error on every page where link to such project
exists
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2014-07-08 18:15:23 +03:00
Marvin Frick
423960a435
adds spec for LDAPKeys (+4 squashed commits)
...
Squashed commits:
[812406c] fixes bug from last refactoring
[53e9508] hides "delete" button if a key is a LDAPKey
[bafc66b] refactores update_ssh_keys in own method
[7895858] makes name of ssh public key configurable
2014-07-08 12:41:12 +02:00
Jacob Vosmaer
0096f28087
Merge branch 'ee_admins_from_ldap_group' into 'master'
...
synchronise admins from LDAP group
from http://feedback.gitlab.com/forums/176466-general/suggestions/5738973-make-all-members-of-ldap-group-gitlab-admins :
> Make all members of LDAP group GitLab admins
>
> In GitLab EE it would be nice if you could make everyone in a certain LDAP group GitLab administrators.
>
> For instance, you would have a LDAP group 'GitLab admins' and anyone added to that group would automatically become admin in GitLab.
2014-07-02 12:22:07 +00:00
Dmitriy Zaporozhets
e64343d6e1
Merge branch 'master' of dev.gitlab.org:gitlab/gitlabhq into ce-changes
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
Conflicts:
VERSION
app/views/layouts/devise.html.haml
features/project/project.feature
features/steps/project/project.rb
2014-06-26 13:02:08 +03:00
Marvin Frick
4be5c5a7a2
adds feature to sync GitLab admins with LDAP group
2014-06-23 18:17:14 +02:00