Dmitriy Zaporozhets
747f66559e
Merge branch 'mr-approves'
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
Conflicts:
db/schema.rb
2015-06-10 16:51:07 +02:00
Dmitriy Zaporozhets
8c830688aa
Add ability to change amount of required approvals in project settings
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-06-09 17:14:25 +02:00
Dmitriy Zaporozhets
15b17b3f6a
Implement approve button
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-06-09 16:12:52 +02:00
Douwe Maan
844cca4a1e
Add Git hook to validate maximum file size.
2015-06-09 10:23:38 +02:00
Dmitriy Zaporozhets
a83d0034e3
Merge branch 'master' of dev.gitlab.org:gitlab/gitlabhq into ce-to-ee
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
Conflicts:
app/services/files/base_service.rb
app/services/files/create_service.rb
app/services/files/delete_service.rb
app/services/files/update_service.rb
doc/workflow/README.md
2015-06-08 18:24:34 +02:00
Dmitriy Zaporozhets
87f9c475db
Merge branch 'refactor-web-editor' into 'master'
...
Refactor web editor
* fix problem with editing non-master branch
* before commit make sure branch exists
* dont allow user change file in one branch and commit to another existing branch
* remove a lot of code duplication
* remove outdated statellite errors
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
Fixes #1761
See merge request !773
2015-06-05 16:14:34 +00:00
Dmitriy Zaporozhets
dfccb06dda
Refactor web editor
...
* fix problem with editing non-master branch
* before commit make sure branch exists
* dont allow user change file in one branch and commit to another existing branch
* remove a lot of code duplication
* remove outdated statellite errors
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-06-05 15:01:38 +02:00
Douwe Maan
4ae67fcaef
Show warning when a comment will add 10 or more people to the discussion.
2015-06-05 12:07:13 +02:00
Dmitriy Zaporozhets
935fc796d1
Merge branch 'master' of dev.gitlab.org:gitlab/gitlabhq into ce-to-ee
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
Conflicts:
VERSION
app/controllers/admin/application_settings_controller.rb
app/controllers/omniauth_callbacks_controller.rb
app/controllers/projects/project_members_controller.rb
app/helpers/application_settings_helper.rb
app/models/user.rb
app/services/files/base_service.rb
app/views/profiles/accounts/show.html.haml
db/schema.rb
doc/install/installation.md
doc/update/6.x-or-7.x-to-7.11.md
doc/workflow/README.md
lib/gitlab/markdown/external_issue_reference_filter.rb
lib/gitlab/reference_extractor.rb
lib/gitlab/upgrader.rb
2015-06-05 11:40:36 +02:00
Robert Speicher
6e5473f930
Remove show actions from Admin and Project DeployKeys
2015-06-03 18:03:04 -04:00
Dmitriy Zaporozhets
7bab4817f7
Merge branch 'repo-remove' into fix-group-remove
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
Conflicts:
spec/features/projects_spec.rb
2015-06-03 15:15:46 +02:00
Dmitriy Zaporozhets
61cfd1d273
Wrap group removal into service
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-06-03 14:07:20 +02:00
Dmitriy Zaporozhets
97ff86e07c
Move repository when project is removed
...
Ths commit does next:
* When we remove project we move repository to path+deleted.git
* Then we schedule removal of path+deleted with sidekiq
* If repository move failed we abort project removal
This should help us with NFS issue when project get removed but
repository stayed. The full explanation of problem is below:
* rm -rf project.git
* rm -rf removes project.git/objects/foo
* NFS server renames foo to foo.nfsXXXX because some NFS client (think
* Unicorn) still has the file open
* rm -rf exits, but project.git/objects/foo.nfsXXX still exists
* Unicorn closes the file, the NFS client closes the file (foo), and the
* NFS server removes foo.nfsXXX
* the directory project.git/objects/ still exists => problem
So now we move repository and even if repository removal failed
Repository directory is moved so no bugs with project removed but
repository directory taken. User still able to create new project with
same name. From administrator perspective you can easily find stalled
repositories by searching `*+deleted.git`
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-06-03 13:05:43 +02:00
Douwe Maan
d99637bf69
Merge branch 'feature/sso_integration' into 'master'
...
Add an option to automatically sign-in with an Omniauth provider
Split of !669 as requested
This is useful when integrating with existing SSO environments and we want to use a single Omniauth provider for all user authentication.
See merge request !723
2015-06-02 08:50:54 +00:00
Robert Speicher
d1bca53bcf
Show "Remove logo" buttons only when Appearance settings are persisted
...
This also adds the CarrierWave cache fields to the form as recommended
by https://github.com/carrierwaveuploader/carrierwave#making-uploads-work-across-form-redisplays
so that uploaded files aren't lost between form submits (i.e., when
there are errors on the form).
2015-05-30 18:23:24 -04:00
Alex Lossent
60225a067d
Allow to configure a URL to show after sign out
2015-05-29 18:20:15 +02:00
Alex Lossent
5491f6fbde
Add an option to automatically sign-in with an Omniauth provider without showing the GitLab sign-in page
...
This is useful when integrating with existing SSO environments and we want to use a single Omniauth provider for
all user authentication.
2015-05-29 18:15:03 +02:00
Dmitriy Zaporozhets
a3b60982e5
Merge branch 'leave-project' into 'master'
...
Add ability to leave project
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
See merge request !744
2015-05-29 15:10:46 +00:00
Dmitriy Zaporozhets
ab2e67550b
Merge branch 'user-oauth-applications' into 'master'
...
Add option to disallow users from registering any application to use GitLab as an OAuth provider
Addresses internal issue https://dev.gitlab.org/gitlab/gitlabhq/issues/2264 .

See merge request !742
2015-05-29 14:51:33 +00:00
Dmitriy Zaporozhets
2afa5fcb52
Add ability to leave project
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-05-29 16:23:36 +02:00
Dmitriy Zaporozhets
394fe7614c
Merge branch 'leave-group' into 'master'
...
User should be able to leave group. If not - show him proper message
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
See merge request !743
2015-05-29 13:35:05 +00:00
Dmitriy Zaporozhets
cef746dc94
User should be able to leave group. If not - show him proper message
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-05-29 14:12:30 +02:00
Douwe Maan
96d6fdc27c
Add option to disallow users from registering any application to use GitLab as an OAuth provider
2015-05-29 13:29:16 +02:00
Douwe Maan
70b29c3576
Merge branch 'feature/saml_support' into 'master'
...
Add SAML support via Omniauth
Split of !669 , with doc
See merge request !722
2015-05-29 10:37:27 +00:00
Robert Speicher
f46b367068
Add MergeRequests#commits action and route
...
/:namespace_id/:project_id/merge_requests/:id/commits(.:format)
2015-05-29 00:09:28 -04:00
Dmitriy Zaporozhets
2db026793d
Fix current user removal
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-05-28 12:53:04 +02:00
Dmitriy Zaporozhets
499154518a
You can not remove user if he/she is an only owner of group
...
To prevent loose of group data you need to transfer or remove group
first before you can remove user
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-05-28 12:00:02 +02:00
Alex Lossent
22de5443c5
Add SAML support via Omniauth
2015-05-27 16:38:10 +02:00
Douwe Maan
45e4727f97
Set milestone on new issue when creating issue from index with milestone filter active.
2015-05-27 14:22:11 +02:00
Dmitriy Zaporozhets
3ed05b2191
Merge branch 'rs-manual-2fa-entry' into 'master'
...
Add support for manually entering 2FA details
> 
Related to #1679 though I'm not sure if it entirely fixes it, since I don't have access to a Windows Phone.
See merge request !694
2015-05-27 09:53:40 +00:00
Robert Speicher
7b879bb8bd
Bump secret key length to 32
2015-05-23 18:47:53 -04:00
Robert Speicher
e73ea12695
Add support for manually entering 2FA details
2015-05-23 15:04:40 -04:00
Stan Hu
deeff56967
Add support for Webhook note events
...
Closes https://github.com/gitlabhq/gitlabhq/issues/6745
2015-05-21 23:48:16 -04:00
Dmitriy Zaporozhets
f5f0ed55bd
Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ce
2015-05-18 17:58:22 +03:00
Nikita Verkhovin
241f5971ba
Add search issues/MR by number
2015-05-18 13:09:13 +06:00
Vinnie Okada
af428b1259
Fill in email on the new password form
2015-05-16 14:03:18 -06:00
Vinnie Okada
c68c23210b
Redirect if password reset token is expired
...
Don't display the password editing form if the user's token is expired;
redirect to the form that allows users to request a new password reset
token.
2015-05-16 14:03:18 -06:00
Dmitriy Zaporozhets
1af8b1e4f8
Merge branch 'master' of dev.gitlab.org:gitlab/gitlabhq into ce-to-ee
...
Conflicts:
app/views/help/index.html.haml
lib/gitlab/git_access.rb
public/500.html
public/502.html
2015-05-15 13:29:58 +03:00
Robert Speicher
0ad9fc60ec
Enable 2FA for LDAP logins
2015-05-14 14:45:31 -04:00
Robert Speicher
c802d8eee1
Refactor SessionsController to use a controller concern
2015-05-14 14:24:05 -04:00
Dmitriy Zaporozhets
8ad91d5840
Merge branch 'text-batch-1' into 'master'
...
Batch 1 of text improvements
Batch 1 of changes from my effort at !635 to walk through every piece of text in GitLab and see if it can be improved.
This batch includes:
- Improve text on error pages.
- Improve Git access error messages.
- Improve description of branch protection levels.
- Improve OAuth signup error message.
- Improve OAuth application flash messages.
cc @rspeicher
See merge request !642
2015-05-13 12:05:17 +00:00
Dmitriy Zaporozhets
f32a045ef4
Merge branch 'version-check' into 'master'
...
Version check
See merge request !1509
2015-05-13 11:17:16 +00:00
Dmitriy Zaporozhets
b2d45bb544
Merge branch 'master' of dev.gitlab.org:gitlab/gitlabhq into ce-to-ee
...
Conflicts:
app/controllers/uploads_controller.rb
app/helpers/application_helper.rb
app/models/note.rb
app/services/test_hook_service.rb
db/schema.rb
spec/models/note_spec.rb
2015-05-13 14:10:14 +03:00
Douwe Maan
17a41547a0
Improve OAuth signup error message.
2015-05-13 09:41:56 +02:00
Dmitriy Zaporozhets
4a373be861
Merge branch '2fa' into 'master'
...
Two-factor authentication
Implement's Two-factor authentication using tokens.
- [X] Authentication logic
- [X] Enable/disable 2FA feature
- [x] Make 2-step login process if 2FA enabled
- [x] Backup codes
- [x] Backup code removed after being used
- [x] Check backup codes for mysql db (mention mysql limitation if applied)
- [x] Add tests
- [x] Test if https://github.com/tinfoil/devise-two-factor#disabling-automatic-login-after-password-resets applies, and address if so
- [x] Wait for fixed version of `attr_encrypted` or fork and use forked version - https://github.com/attr-encrypted/attr_encrypted/issues/155
Fixes http://feedback.gitlab.com/forums/176466-general/suggestions/4516817-implement-two-factor-authentication-2fa
See merge request !474
2015-05-12 09:41:27 +00:00
Dmitriy Zaporozhets
e1a8089cc2
Merge branch 'create-merge-request' into 'master'
...
Add Create Merge Request buttons to commits page and push event.
Commits page:

Branches page:

Push event: (Only for new branches, and only shown to the pushing user)

Push event with multiple commits and a Compare link:

See merge request !632
2015-05-11 19:43:56 +00:00
Robert Speicher
24bef5e67a
Handle password reset for users with 2FA enabled
2015-05-11 14:31:31 -04:00
Douwe Maan
783b286ac0
Don't symbolize params.
2015-05-11 11:55:02 +02:00
Robert Speicher
414ddc0021
Clear all 2FA-related fields when user disables the feature
2015-05-09 17:32:49 -04:00
Robert Speicher
5cd526f77f
Prevent "You are already signed in." error message upon 2FA login
2015-05-09 17:32:49 -04:00