Robert Speicher
1d2d67b9e3
Merge branch 'fix/gitlab-importer-issue' into 'master'
...
Fix gitlab importer issue
Fixed credentials not being called correctly - probably some bad refactoring or search & replace...
Fixes https://gitlab.com/gitlab-org/gitlab-ee/issues/565
See merge request !4301
2016-05-26 21:36:01 +00:00
Yorick Peterse
9bdfc98242
Merge branch 'measure-proxy-timing' into 'master'
...
Measure proxy flight time
See merge request !4278
2016-05-26 17:05:26 +00:00
Jacob Vosmaer
5771114f9b
Rename metric to 'rails queue duration'
2016-05-26 17:53:21 +02:00
James Lopez
bf484ffee4
fix bad refactoring of import data credentials
2016-05-26 11:25:35 +02:00
Dmitriy Zaporozhets
adc64e4583
Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ce
2016-05-26 10:30:11 +02:00
Jacob Schatz
3d009f7785
Merge branch 'updated-contrib-calendar' into 'master'
...
POC: Updated contrib calendar
In an effort to cut down the JS file size - i've removed the heatmap calendar used for the contributing calendar on users profiles. We already have d3 on the page so why not use it instead of using a library which uses it?

cc. @jschatz1
See merge request !3944
2016-05-25 23:29:41 +00:00
Douwe Maan
99cd419132
Merge branch 'fix/import-url-uri-issue' into 'master'
...
Fix for import URL URI problem when URL contains a space
Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/17559
Prevents an already encoded URL to be encoded again - preventing %20 => %25%20
See merge request !4180
2016-05-25 20:48:30 +00:00
Douwe Maan
74fb500415
Merge branch 'issue_10725' into 'master'
...
Fix forks creation when visibility level is restricted
fixes #10725
See merge request !4283
2016-05-25 20:47:46 +00:00
Douwe Maan
9971782200
Merge branch 'fix-issue-17496' into 'master'
...
Fix groups API to list only user's accessible projects
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/17496
See merge request !1966
2016-05-25 20:28:17 +00:00
Robert Speicher
3c2d0cf24c
Merge branch 'complexity/enable-multiple-rubocop-cops-2' into 'master'
...
Enable multiple compatible Rubocop cops
## What does this MR do?
This MR enables multiple Rubocop cops, that are already compatible with
our codebase. See #17406 .
Cops enabled:
```text
Style/ArrayJoin:
Description: Use Array#join instead of Array#*.
StyleGuide: https://github.com/bbatsov/ruby-style-guide#array-join
----------------
Style/Attr:
Description: Checks for uses of Module#attr.
StyleGuide: https://github.com/bbatsov/ruby-style-guide#attr
----------------
Style/BlockComments:
Description: Do not use block comments.
StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-block-comments
----------------
Style/ClassMethods:
Description: Use self when defining module/class methods.
StyleGuide: https://github.com/bbatsov/ruby-style-guide#def-self-class-methods
----------------
Style/EndBlock:
Description: Avoid the use of END blocks.
StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-END-blocks
----------------
Style/EvenOdd:
Description: Favor the use of Fixnum#even? && Fixnum#odd?
StyleGuide: https://github.com/bbatsov/ruby-style-guide#predicate-methods
----------------
Style/FileName:
Description: Use snake_case for source file names.
StyleGuide: https://github.com/bbatsov/ruby-style-guide#snake-case-files
ExpectMatchingDefinition: false
----------------
Style/FirstMethodParameterLineBreak:
Description: Checks for a line break before the first parameter in a multi-line method
parameter definition.
----------------
Style/FlipFlop:
Description: Checks for flip flops
StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-flip-flops
----------------
Style/GlobalVars:
Description: Do not introduce global variables.
StyleGuide: https://github.com/bbatsov/ruby-style-guide#instance-vars
Reference: http://www.zenspider.com/Languages/Ruby/QuickRef.html
----------------
Style/IfWithSemicolon:
Description: Do not use if x; .... Use the ternary operator instead.
StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-semicolon-ifs
----------------
Style/LambdaCall:
Description: Use lambda.call(...) instead of lambda.(...).
StyleGuide: https://github.com/bbatsov/ruby-style-guide#proc-call
EnforcedStyle: call
----------------
Style/MethodName:
Description: Use the configured style when naming methods.
StyleGuide: https://github.com/bbatsov/ruby-style-guide#snake-case-symbols-methods-vars
EnforcedStyle: snake_case
----------------
Style/MultilineMethodDefinitionBraceLayout:
Description: Checks that the closing brace in a method definition is symmetrical with
respect to the opening brace and the method parameters.
----------------
Style/NestedModifier:
Description: Avoid using nested modifiers.
StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-nested-modifiers
----------------
Style/OpMethod:
Description: When defining binary operators, name the argument other.
StyleGuide: https://github.com/bbatsov/ruby-style-guide#other-arg
----------------
Style/SignalException:
Description: Checks for proper usage of fail and raise.
StyleGuide: https://github.com/bbatsov/ruby-style-guide#prefer-raise-over-fail
EnforcedStyle: only_raise
----------------
Style/SpaceAfterNot:
Description: Tracks redundant space after the ! operator.
StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-space-bang
----------------
Style/SpaceBeforeSemicolon:
Description: No spaces before semicolons.
----------------
Style/SpaceInsideRangeLiteral:
Description: No spaces inside range literals.
StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-space-inside-range-literals
----------------
Style/SpaceInsideStringInterpolation:
Description: Checks for padding/surrounding spaces inside string interpolation.
StyleGuide: https://github.com/bbatsov/ruby-style-guide#string-interpolation
EnforcedStyle: no_space
----------------
Style/StabbyLambdaParentheses:
Description: Check for the usage of parentheses around stabby lambda arguments.
StyleGuide: https://github.com/bbatsov/ruby-style-guide#stabby-lambda-with-args
EnforcedStyle: require_parentheses
----------------
Style/StringMethods:
Description: Checks if configured preferred methods are used over non-preferred.
PreferredMethods:
intern: to_sym
----------------
Style/VariableInterpolation:
Description: Don't interpolate global, instance and class variables directly in strings.
StyleGuide: https://github.com/bbatsov/ruby-style-guide#curlies-interpolate
----------------
Style/VariableName:
Description: Use the configured style when naming variables.
StyleGuide: https://github.com/bbatsov/ruby-style-guide#snake-case-symbols-methods-vars
EnforcedStyle: snake_case
----------------
Style/WhenThen:
Description: Use when x then ... for one-line cases.
StyleGuide: https://github.com/bbatsov/ruby-style-guide#one-line-cases
----------------
Style/WhileUntilModifier:
Description: Favor modifier while/until usage when you have a single-line body.
StyleGuide: https://github.com/bbatsov/ruby-style-guide#while-as-a-modifier
MaxLineLength: 80
```
Closes #17406
See merge request !4286
2016-05-25 19:41:10 +00:00
DJ Mountney
1a7326ba9a
Switch the gitlab:db:configure task to use tables.any? instead of looking specifically for the schema_migrations table
2016-05-25 10:47:09 -07:00
DJ Mountney
24632d2150
Update hash syntax and add changelog for the gitlab:db:configure rake task
2016-05-25 10:44:22 -07:00
DJ Mountney
c6e7d826b2
Add a gitlab:db:configure rake task to handle conditionally seeding or migrating the database.
2016-05-25 10:44:22 -07:00
Felipe Artur
5273335247
Fix forks creation when visibility level is restricted
2016-05-25 10:57:00 -04:00
Jacob Vosmaer
c049534da6
Align class name with field name
2016-05-25 14:55:23 +02:00
Jacob Vosmaer
3c785a761c
Send data to InfluxDB instead of stdout
2016-05-25 14:28:21 +02:00
Jacob Schatz
318b22459b
Merge branch 'incremental-fixes' into 'master'
...
Fix concurrent request when updating build log in browser
If you have a slow internet connection the trace will not be updated correctly. We need to check if our request is the latest one.
Fixes: https://gitlab.com/gitlab-org/gitlab-ce/issues/17535
See merge request !4183
2016-05-25 11:51:20 +00:00
Douwe Maan
019a3c781e
Merge branch 'fix-registry-backups' into 'master'
...
Fix backups if registry is disabled
Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/17749
See merge request !4263
2016-05-25 09:28:22 +00:00
Grzegorz Bizon
2c7439db4d
Enable multiple compatible Rubocop cops
...
Closes #17406
2016-05-25 06:17:29 +02:00
Kamil Trzcinski
718fe268c4
Improve after review
2016-05-24 22:52:31 -05:00
Stan Hu
b359d5d57f
Fix groups API to list only user's accessible projects
...
Closes #17496
2016-05-24 18:14:12 -07:00
Jacob Vosmaer
cee07c5919
Measure proxy timing: needs influxdb code
2016-05-24 17:07:41 +02:00
Kamil Trzcinski
cdec9e472d
Replace \n to <br>
2016-05-23 21:59:07 -05:00
Robert Speicher
43d9e06b68
Add rubocop-rspec
...
Almost all cops are starting as disabled until we can fix their
violations.
2016-05-23 15:59:32 -04:00
Robert Speicher
18ac02a3fe
Merge branch 'rs-space-around-keyword' into 'master'
...
Enable Style/SpaceAroundKeyword cop and fix offenses
Ref: https://gitlab.com/gitlab-org/gitlab-ce/issues/17478
See merge request !4259
2016-05-23 19:29:25 +00:00
Kamil Trzcinski
12bd781031
Fix backups if registry is disabled
2016-05-23 14:18:39 -05:00
Robert Speicher
42aca7df08
Merge branch 'rs-range-include' into 'master'
...
Enable Performance/RangeInclude cop and fix single offense
Ref: https://gitlab.com/gitlab-org/gitlab-ce/issues/17478
See merge request !4255
2016-05-23 18:25:47 +00:00
Robert Speicher
3ba72f69af
Enable Style/SpaceAroundKeyword cop and fix offenses
2016-05-23 14:16:35 -04:00
Robert Speicher
51c167eeb7
Enable Performance/RangeInclude cop and fix single offense
2016-05-23 13:10:42 -04:00
Robert Speicher
013bccbd93
Enable Style/DefWithParentheses cop and fix single offense
2016-05-23 13:06:36 -04:00
James Lopez
d83ce65c1a
fix changelog and merge
2016-05-23 09:11:21 +02:00
Stan Hu
9bb0d0b407
Fix Error 500 in CI charts by gracefully handling commits with no durations
...
Closes #17730
2016-05-22 23:52:50 -07:00
Achilleas Pipinellis
399d5e723a
Merge branch 'registry_admin_docs' into 'master'
...
Docker container registry configuration docs.
Part of gitlab-org/omnibus-gitlab!764 and gitlab-org/gitlab-ce!4040
See merge request !4141
2016-05-23 01:52:37 +00:00
Achilleas Pipinellis
f55f628531
Add note about port needed in NGINX config
2016-05-22 19:20:28 -05:00
Grzegorz Bizon
7f9092da1e
Extend comment for migrations helper MySQL fix
2016-05-22 23:31:33 +02:00
Grzegorz Bizon
2df8b48dbb
Add MySQL compatibility fix in migration helpers
2016-05-22 22:44:59 +02:00
Achilleas Pipinellis
c1af75192d
Add NGINX config file for Registry
2016-05-22 14:54:29 -05:00
Douwe Maan
ec86644545
Merge branch 'zj-gitignore-dropdown'
2016-05-20 17:14:22 -05:00
Douwe Maan
fc1910ddc5
Merge branch 'adambutler/gitlab-ce-feature/support-diff-of-issue-title-rename'
...
# Conflicts:
# app/services/system_note_service.rb
2016-05-20 16:23:04 -05:00
Douwe Maan
ba5b47c2e3
Merge branch 'eReGeBe/gitlab-ce-feature/milestone-md' into 'master'
...
Implement special GitLab markdown reference for milestones
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/3453 by @eReGeBe, with two additions:
- Move changelog item to 8.8
- Fix cross-project milestone ref with invalid project, like https://gitlab.com/gitlab-org/gitlab-ce/commit/f7348cd348ad8f4a18d74dd668283a4e236f5790 did for labels
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/13829
See merge request !3897
2016-05-20 21:08:57 +00:00
Alfredo Sumaran
ab96ca2bf1
Dropdown implementation
2016-05-20 15:58:36 -05:00
Zeger-Jan van de Weg and Alfredo Sumaran
79620c501d
Update API and fetching task
2016-05-20 15:58:36 -05:00
Zeger-Jan van de Weg and Alfredo Sumaran
e166a8022a
Backend for a gitignores dropdown
2016-05-20 15:58:36 -05:00
Robert Speicher
f26389a02a
Merge branch 'feature/runner-config-untagged-jobs' into 'master'
...
Add config for CI Runner that prevents it from picking untagged jobs
Closes #3456
See merge request !4039
2016-05-19 21:54:33 +00:00
Jeroen van Baarsen
fa7a682bb0
Merge branch 'fix-generator-templates-directory' into 'master'
...
Move generator templates to generator_templates/
See merge request !4217
2016-05-19 21:24:05 +00:00
Douwe Maan
18ef054bc7
Merge branch '17464-backport-email-syntax-highlighting' into 'master'
...
Syntax-highlight diffs in push emails

Based on:
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/151
See merge request !4147
2016-05-19 21:12:53 +00:00
Grzegorz Bizon
bf9cc351c2
Add minor corrections related to config of runner
2016-05-19 22:01:53 +02:00
Grzegorz Bizon
0fd100d28d
Improve setting default runner attrs when using API
2016-05-19 22:01:53 +02:00
Grzegorz Bizon
b8cf2a340b
Set run untagged option when registering a runner
2016-05-19 22:01:53 +02:00
Grzegorz Bizon
da8b72d453
Extend runner options that are configurable via API
2016-05-19 22:01:53 +02:00