Douwe Maan
822ba95f75
Merge branch 'fix-commit-data-url-generation' into 'master'
...
Fix bug where commit data would not appear in some subdirectories
Fix issue where commit data would not show up in some subdirectories due to escaped slashes. For example:
https://gitlab.common-lisp.net/ecl/ecl/tree/develop/src/gc (now patched with fix)
The upgrade from Rails v4.1.2 to v4.1.9 (76aad9b76e ) caused slashes in a tree to be escaped automatically. Using a wildcard glob in the route prevents this behavior.
* Closes #1478 , #1459
* Closes https://github.com/gitlabhq/gitlabhq/issues/9037
See merge request !581
2015-04-28 15:46:36 +00:00
Dmitriy Zaporozhets
8140c68289
Merge branch 'rs-issue-2269' into 'master'
...
Remove duplicate settings for default_url_options
Closes #2269
See merge request !1797
2015-04-28 08:34:34 +00:00
Stan Hu
ef0055b52d
Fix bug where commit data would not appear in some subdirectories
...
The upgrade from Rails v4.1.2 to v4.1.9 (76aad9b76e ) caused slashes in a tree to be escaped automatically.
Using wildcard globs prevents this behavior.
Closes #1478 , #1459
2015-04-26 23:52:40 -07:00
Vinnie Okada
bd557e4b64
Add new admin settings
...
Add new global application settings for default project and snippet
visibility levels.
2015-04-26 07:48:19 -06:00
Robert Speicher
2c90579749
Set default_url_options in test environments too
2015-04-25 19:46:05 -04:00
Dmitriy Zaporozhets
b0ed2ff1a6
Merge branch 'atom-feeds-everywhere' into 'master'
...
Add project activity atom feed and show atom feed buttons everywhere where applicable.
See merge request !555
2015-04-24 10:15:13 +00:00
Robert Speicher
b71e5a17e9
Add default_url_options initializer
...
Fixes #2266
2015-04-23 12:58:11 -04:00
Douwe Maan
a6dfd065ca
Add atom feed for project activity.
2015-04-23 17:11:39 +02:00
Dmitriy Zaporozhets
f9119150ec
Merge branch 'rs-rails-env-predicates' into 'master'
...
Fix two places where we should be using `Rails.env.development?`
See merge request !550
2015-04-23 12:37:46 +00:00
Dmitriy Zaporozhets
71f6143552
Merge branch 'master' into new-sidebar
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
Conflicts:
app/controllers/snippets_controller.rb
2015-04-23 12:08:03 +03:00
Dmitriy Zaporozhets
a22f3139f3
Merge branch 'rs-reply-hotkey' into 'master'
...
"Reply quoting selected text" shortcut/hotkey
Adds the <kbd>r</kbd> hotkey for quoting selected text on Issuable forms.
This MR also updates the jasmine gem and adds jasmine-rails to let us use the asset pipeline (and Coffeescript) in JS specs.
See merge request !1775
2015-04-22 19:57:40 +00:00
Dmitriy Zaporozhets
4a63573b21
Start applying new layout to snippets pages
2015-04-22 18:17:43 +03:00
Robert Speicher
6c3591279f
Fix two places where we should be using Rails.env.development?
2015-04-20 18:28:19 -04:00
Marin Jankovski
225b43de22
Merge branch 'master' of github.com:gitlabhq/gitlabhq
2015-04-20 09:43:28 +02:00
Robert Speicher
d5c7b62b8e
rails g jasmine_rails:install
2015-04-18 15:17:25 -04:00
Roshan Gautam
984f8077b3
Fix Resource Owner Password Authentication Flow
2015-04-17 11:47:02 -05:00
Robert Speicher
2d4ffce826
Loosen help page parameter constraints for category
2015-04-15 13:15:18 -04:00
Robert Speicher
e24cb79f31
Add constraints to help#show route parameters
2015-04-15 12:25:37 -04:00
Robert Speicher
1e27b68b36
Add Markdown to Mime types
2015-04-15 12:25:24 -04:00
Robert Speicher
ef47ea3d39
Revert "Fix and improve help rendering"
...
This reverts commit d365004e68 .
2015-04-15 12:24:44 -04:00
Dmitriy Zaporozhets
4ab22a8c32
Merge branch 'ldap-block_auto_created_users' into 'master'
...
Add config var to block auto-created LDAP users.
Addresses private issue https://dev.gitlab.org/gitlab/gitlabhq/issues/2110 .
See merge request !522
2015-04-15 12:36:43 +00:00
Dmitriy Zaporozhets
e3d818a4e8
Merge branch 'invitation' into 'master'
...
Allow users to be invited.
Addresses private issue https://dev.gitlab.org/gitlab/gitlabhq/issues/2058 .
The "Add members" panes for both Group Members and Project Members have gained a line of text by the People field.

Entering an email address that is not already a member will give you the option to invite them.

Choosing the option will add them to the People field. This works the right way (TM) in combination with adding existing users as members.

The invited member will be shown in the members list as such. The access level can be changed, and the invite can be revoked by deleting the member.

The invited user will receive an email with an "Accept invitation" link.

If they're not already logged in, clicking this link will redirect them to the sign in/up page with a helpful notice.

Signing in or signing up will redirect them back to the invite detail page, where they can actually accept the invitation, which will update the member record in question to point to the user in question.

Accepting the invitation will redirect them to the group (or project) with an appropriate notice.

As currently, they will also receive this information by email.

At the same time, the person who initially invited the email address is sent a notification as well, so they know of the new member and to tell them what name the user signed up with.

The member row on the Members page will now have been updated with the new user account.

See merge request !500
2015-04-15 10:48:28 +00:00
Douwe Maan
63b21945d2
Merge branch 'google-code-import' into 'master'
...
Import projects from Google Code.
Resolves #1257 .
Issue import logic almost entirely taken from https://gitlab.com/o9000/google-code-to-gitlab ( ♥️ @o9000).
### To do
- [x] List projects from Google Takeout file
- [x] Import Git repository
- [x] Import issues
- [x] Link to correct attachment URL (https://code.google.com/p/support-tools/issues/detail?id=50 )
- [x] Handle deleted attachments
- [x] Handle blockedOn attribute
- [x] Add directions on how to get data from Google Takeout
### Import instructions

### Imported issue

See merge request !471
2015-04-15 06:53:42 +00:00
Douwe Maan
55d086ba08
Clarify config var and add to LDAP docs.
2015-04-14 18:17:46 +02:00
Douwe Maan
238e4f0295
Add config var to block auto-created LDAP users.
2015-04-14 17:09:05 +02:00
Dmitriy Zaporozhets
bf7932bd06
Merge branch 'dir-traversal' into 'master'
...
Fix directory traversal vulnerabilities
Fixes gitlab/gitlab-ee#272.
As @joern mentions:
> This is not exploitable via the front-end nginx. But nevertheless this issue should be addressed.
See merge request !1760
2015-04-14 13:07:27 +00:00
Douwe Maan
dba63d667d
Allow user map to be specified.
2015-04-14 14:50:56 +02:00
Douwe Maan
e50556fcc8
Let invites be declined.
2015-04-14 12:08:11 +02:00
Douwe Maan
453340d449
Let membership invitations be resent.
2015-04-14 12:08:10 +02:00
Douwe Maan
39f389ae0f
Add invites controller.
2015-04-14 12:07:33 +02:00
Dmitriy Zaporozhets
4ab717ea6a
Merge branch 'ldap_migration'
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
Conflicts:
db/schema.rb
2015-04-13 17:18:02 +03:00
Jacob Vosmaer
f39b150a02
Call your existing LDAP server 'main'
...
By imposing this rule we avoid having to demand that 'ldapmain' exists
in the settings initializer.
2015-04-13 15:45:19 +02:00
Dmitriy Zaporozhets
7f04a4174e
Merge branch 'shell-version-warning' into 'master'
...
Warn when gitlab-shell version doesn't match requirement.
Addresses private issue https://dev.gitlab.org/gitlab/gitlabhq/issues/1791 .
See merge request !495
2015-04-13 13:05:47 +00:00
Jacob Vosmaer
ec7a68a1a5
Simplify legacy LDAP config interpretation
2015-04-13 11:50:44 +02:00
Dmitriy Zaporozhets
9c14ed0689
Merge branch 'public-deploy-keys' into 'master'
...
Allow admin to create public deploy keys that are accessible to any project.
Addresses private issue https://dev.gitlab.org/gitlab/gitlabhq/issues/1774 .
Project settings:

The "Public deploy keys" section is only shown when there are any. If there are public deploy keys but no project deploy keys, only public deploy keys are shown. If there are no public deploy keys and no project deploy keys, the current "Deploy keys from projects you have access to will be displayed here" placeholder is shown.
The list of projects below the public key has been changed to only show projects the user has access to.
"Public deploy key" seems to be repeated on the left, but the first is just the title. The label is always visible for public deploy keys.
Admin index:

Admin detail page:

Projects using the deploy key are listed on the left and can be disabled easily.
See merge request !469
2015-04-13 09:08:13 +00:00
Valery Sizov
8666f497ff
fix ldap identities
2015-04-11 17:56:45 +03:00
Douwe Maan
0ece6bd828
Use \A and \z in regexes instead of ^ and $.
2015-04-10 18:31:07 +02:00
Douwe Maan
93133f4da9
Fix directory traversal vulnerability around uploads routes.
2015-04-10 18:18:37 +02:00
Robert Speicher
91c39fd8c7
Add lib/gitlab.rb to autoload non-conventional paths
2015-04-09 14:19:25 -04:00
Robert Speicher
a3601d6005
Revert "Preload lib/"
...
This reverts commit 5511a731bc .
2015-04-09 12:21:59 -04:00
Douwe Maan
f915a4b80f
Warn when gitlab-shell version doesn't match requirement.
2015-04-06 14:02:49 +02:00
Douwe Maan
45ca39e81b
Merge remote-tracking branch 'github.com/master'
2015-04-04 14:23:32 +02:00
Douwe Maan
bc2edc359d
Remove sidekiq-limit_fetch because it require Redis 2.6.
2015-04-03 18:38:31 +02:00
Douwe Maan
04a42ce3f1
Merge branch 'custom-email-reply-to' into 'master'
...
Add ability to configure Reply-To address
### What does this MR do?
This MR adds configuration variable `email_reply_to` to make it possible to configure a custom Reply-To address other than the default `noreply@mydomain.com `.
### What are the relevant issue numbers / [Feature requests](http://feedback.gitlab.com/ )?
#1305
See merge request !455
2015-04-03 15:14:04 +00:00
Stan Hu
81a5a9713d
Add ability to configure Reply-To address in gitlab.yml
...
Closes #1305
2015-04-03 06:47:54 -07:00
Douwe Maan
7b5bc32cad
Allow projects to be imported from Google Code.
2015-04-03 15:29:27 +02:00
Douwe Maan
edc4a56d26
Allow admin to create public deploy keys that are accessible to any project.
2015-04-03 12:23:20 +02:00
Sullivan SENECHAL and Sullivan SENECHAL
d365004e68
Fix and improve help rendering
2015-04-03 11:56:50 +02:00
Douwe Maan
317206300d
Merge branch 'configurable-attachment-size' into 'master'
...
Support configurable attachment size in Application Settings page
### What does this MR do?
This MR provides the ability to configure the maximum size of an attachment inside a note. A parameter has been added to the Application Settings page.
### Are there points in the code the reviewer needs to double check?
What should be done with the legacy note attachment validation? I added code to make the validation work with the configurable setting. I could see an issue where an admin lowers the limit from 10 megabytes to 5 megabytes, which could cause an existing model to be invalid.
### Why was this MR needed?
We often have attachments that exceed 10 MB, and it would be nice to be able to override the defaults.
### What are the relevant issue numbers / [Feature requests](http://feedback.gitlab.com/ )?
See Issue #1258
### Screenshots
Before:

After:

See merge request !407
2015-04-03 08:47:55 +00:00
Stan Hu
dfd256f29e
Support configurable attachment size via Application Settings
...
Fix bug where error messages from Dropzone would not be displayed on the issues page
Closes #1258
2015-04-02 00:04:08 -07:00