Fix endless redirections when accessing user OAuth applications when they are disabled
## What does this MR do?
This MR fixes a bug where the browser would be redirect endlessly when attempting to access the user's OAuth applications when an admin has disabled this system-wide setting.
## Are there points in the code the reviewer needs to double check?
I assume disabling the nav button is better than showing a page that says, "OAuth applications are disabled by the admin."
## Why was this MR needed?
Lots of users were confused when they hit endless redirect errors.
## What are the relevant issue numbers?
#14770
See merge request !4525
Add flexbox to project header
## What does this MR do?
Adds flexbox to project header to keep components vertically centered regardless of description presence/length
## What are the relevant issue numbers?
Closes #18080
## Screenshots (if relevant)
See merge request !4417
Notifications dropdown on project page now has descriptions
## What does this MR do?
Adds descriptions to the notification settings dropdown on project pages. Also changed the order of them to make more sense.
## What are the relevant issue numbers?
Part of #12758
## Screenshots (if relevant)
See merge request !4374
Sub navigation
## What does this MR do?
Styles sub nav
cc @dzaporozhets @skyruler @jschatz1
## What are the relevant issue numbers?
#18058 and #17983
## Screenshots (if relevant)
See merge request !4468
Implement compact side nav
## What does this MR do?
Implements new compact nav design
Note- new navbar icons are in a separate MR (https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4268)
## What are the relevant issue numbers?
Closes#18013
## Screenshots (if relevant)
cc @dzaporozhets
See merge request !4447
Rename ci_commit in application code
This is third iteration of renaming `[ci_]commit(s)` in application code to `pipeline(s)`.
See merge request !4464
Rename Ci::Commit in specs
This is second iteration of renaming Ci::Commit occurences, this time I try to rename all `let's` and `factories` to match what type of object is created:
1. Rename factories: `ci_[...]_commit_[...]` to `ci_[...]_pipeline_[...]`,
2. Rename all `let's(:[ci_]commit)` to `let(:pipeline)`,
3. Rename all occurrences of `[ci_]commit` to `pipeline` if Pipeline object is created
cc @grzesiek @DouweM
See merge request !4463
Add padding to bottom of wiki page, fix#12921.
## What does this MR do?
Adds padding to the bottom of the wiki page so it's not right up against the edge of the browser window.
## What are the relevant issue numbers?
#12921
## Screenshots (if relevant)
Before:
After:
cc: @jschatz1
See merge request !4490
Fixed issue with activity links not being consistent
## What does this MR do?
Previously, links for opening an issue/merge request & commenting where different. Opening would only have a link on the number whereas commenting would have link on the text as well. This standardises it to include the type as well (ie. issue)
## What are the relevant issue numbers?
Closes#17621
## Screenshots (if relevant)
See merge request !4400
Shows the edit comment button on mobile
## What does this MR do?
Shows the edit comment button on mobile.
## What are the relevant issue numbers?
Closes#17214
## Screenshots (if relevant)
See merge request !4402
Remove prev/next buttons on issues and merge requests
## What does this MR do?
Remove prev/next buttons on issues and merge requests sidebar
## Are there points in the code the reviewer needs to double check?
No
## Why was this MR needed?
The buttons were rarely used and added at least 1 query each on every page load which we could live without.
## What are the relevant issue numbers?
#18026
## Screenshots (if relevant)
Below is how it looks. Not sure if it's too much empty space. #17697 discusses a possible substitute for what to put there.
See merge request !4442
Add confidential issue notice in comment box.
## What does this MR do?
Adds a warning about confidential issues to the comment field when the issue is confidential.
## Are there points in the code the reviewer needs to double check?
I don't think so.
## Why was this MR needed?
It wasn't clear to users that they were commenting on a confidential issue, this makes it more explicit.
## What are the relevant issue numbers?
Fixes#15288
## Screenshots (if relevant)
This is what it looks like at various screen sizes:
cc: @jschatz1 @dzaporozhets
See merge request !4473
Work around ActiveRecord count and column aliases issue as described at:
<https://github.com/rails/rails/issues/15138#issuecomment-61325080>
AR doesn't promise that `#count` (which is called by `#any?`) will work
for relations using `#select`, which means we need a workaround instead.
Notes are awardables
## What does this MR do?
Makes sure we can :thunder_cloud_rain: comments/notes.
## What are the relevant issue numbers?
Follows up upon !2901, depends on !3785Closes#3655
## Screenshots (if relevant)
TODO
See merge request !4291
Rémy Coutable
Stan Hu
Jacob Schatz
Annabel Dunstone
Phil Hughes
Douwe Maan
Douwe Maan
Kamil Trzcinski
Alejandro Rodríguez
Connor Shea
Alfredo Sumaran
Sean McGivernandAlfredo Sumaran
Thijs WoutersandAlfredo Sumaran
Douglas Barbosa Alexandre