Kamil Trzcinski
0672258915
Cleanup CiCommit and CiBuild
...
- Remove all view related methods from Ci::Build and CommitStatus
- Remove unused Ci::Commit and Ci::Build methods
- Use polymorphism to render different types of CommitStatus
2016-03-14 13:20:35 +01:00
Rubén Dávila and Robert Speicher
169070ba4b
Some updates from last code review.
2016-02-19 13:14:54 -05:00
Rubén Dávila and Robert Speicher
d958d027dc
Make #commit_with_hooks return the new obj id plus some other fixes.
2016-02-19 13:14:54 -05:00
Rubén Dávila and Robert Speicher
d34733efc4
Don't show revert button if commit/MR has already been reverted.
2016-02-19 13:14:54 -05:00
Rubén Dávila and Robert Speicher
e8d15f1339
Refactor revert_commit_link helper.
2016-02-19 13:14:54 -05:00
Rubén Dávila and Robert Speicher
5ad78cdbda
Use a custom title in the revert modal.
2016-02-19 13:14:53 -05:00
Rubén Dávila and Robert Speicher
ccd2a8d6b5
Show a tooltip on revert link.
2016-02-19 13:14:53 -05:00
Rubén Dávila and Robert Speicher
328b52d58a
Some updates after last code review.
2016-02-19 13:14:52 -05:00
Rubén Dávila and Robert Speicher
4dc8350517
Reuser revert commit modal in MR detail page.
2016-02-19 13:14:51 -05:00
Rubén Dávila and Robert Speicher
b0693318c3
Show list of branches plus some fixes.
2016-02-19 13:14:51 -05:00
Rubén Dávila and Robert Speicher
34e26b8212
Add button to revert commit on Commit detail page.
2016-02-19 13:14:50 -05:00
Rubén Dávila and Robert Speicher
006089f972
Add new endpoint and button to revert any commit.
2016-02-19 13:14:50 -05:00
Kamil Trzcinski
055afab5c7
Make the CI permission model simpler
...
This MR simplifies CI permission model:
- read_build: allows to read a list of builds, artifacts and trace
- update_build: allows to cancel and retry builds
- create_build: allows to create builds from gitlab-ci.yml (not yet implemented)
- admin_build: allows to manage triggers, runners and variables
- read_commit_status: allows to read a list of commit statuses (including the overall of builds)
- create_commit_status: allows to create a new commit status using API
Remove all extra methods to manage permission.
Made all controllers to use explicitly the new permissions.
2016-02-02 09:18:08 +01:00
Rubén Dávila
c8db25c37c
Merge branch 'master' into issue_3945
2016-01-14 17:28:44 -05:00
Dmitriy Zaporozhets
cd2ddaaa45
add missing padding for commit -> builds page
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2016-01-14 21:47:12 +01:00
Dmitriy Zaporozhets
bb5213588b
Update files/diffs to match new layout
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2016-01-14 12:31:31 +01:00
Dmitriy Zaporozhets
03090a88d8
Replace all navigation menu with nav-links class
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2016-01-13 15:58:04 +01:00
Rubén Dávila
21b602c60a
Change strategy to highlight diffs. #3945
...
Now we apply syntax highlighting to the whole old and new files.
This basically help us to highlight adequately multiline content.
2016-01-07 22:37:01 -05:00
Douwe Maan
bd21e3d731
Add Open Graph data for group, project and commit.
2015-12-25 16:41:02 +01:00
Kamil Trzcinski
58a56a0396
Don't create CI status for refs that doesn't have .gitlab-ci.yml, even if the builds are enabled
2015-12-17 16:33:47 +01:00
Robert Speicher
f49ac5c8d3
Fix clipboard buttons on MR instructions and Commit#show
2015-12-15 16:11:01 -05:00
Grzegorz Bizon
32d83ee79f
Merge branch 'master' into ux/suppress-ci-yml-warning
...
* master: (24 commits)
Fix runners admin view
Fix migrations
Run builds from projects with enabled CI
Use Gitlab::Git instead of Ci::Git
Fix last specs
Fix specs
Fix after column rename
Fix errors
Update badge
Finishing touches
Fix triggers tests
Rename columns and rename migrations
Reimplement Trigger API
Remove ci_ prefix from all ci related things
Add runners token
Migrate CI::Project to Project
Fix indentation and BuildsEmailService
Change default values
Enhance migrate CI emails
Fix issue tracker service
...
Conflicts:
spec/features/commits_spec.rb
2015-12-14 12:25:37 +01:00
Grzegorz Bizon
b8f67c5e47
Do not display ci build status if builds enabled but no .gitlab-ci.yml
...
Ref #3827
2015-12-14 11:28:49 +01:00
Kamil Trzcinski
dd8102f2d1
Fix specs
2015-12-11 18:02:10 +01:00
Kamil Trzcinski
73b04bebad
Fix errors
2015-12-11 18:02:09 +01:00
Kamil Trzcinski
1e2a4895c8
Finishing touches
2015-12-11 18:02:09 +01:00
Kamil Trzcinski
e80e3f5372
Migrate CI::Project to Project
2015-12-11 18:02:09 +01:00
Douwe Maan
10387f6b8a
Merge branch 'master' into tmp-reference-pipeline-and-caching
...
# Conflicts:
# spec/lib/gitlab/markdown/autolink_filter_spec.rb
# spec/lib/gitlab/markdown/commit_range_reference_filter_spec.rb
# spec/lib/gitlab/markdown/commit_reference_filter_spec.rb
# spec/lib/gitlab/markdown/cross_project_reference_spec.rb
# spec/lib/gitlab/markdown/emoji_filter_spec.rb
# spec/lib/gitlab/markdown/external_issue_reference_filter_spec.rb
# spec/lib/gitlab/markdown/external_link_filter_spec.rb
# spec/lib/gitlab/markdown/issue_reference_filter_spec.rb
# spec/lib/gitlab/markdown/label_reference_filter_spec.rb
# spec/lib/gitlab/markdown/merge_request_reference_filter_spec.rb
# spec/lib/gitlab/markdown/redactor_filter_spec.rb
# spec/lib/gitlab/markdown/reference_gatherer_filter_spec.rb
# spec/lib/gitlab/markdown/relative_link_filter_spec.rb
# spec/lib/gitlab/markdown/sanitization_filter_spec.rb
# spec/lib/gitlab/markdown/snippet_reference_filter_spec.rb
# spec/lib/gitlab/markdown/syntax_highlight_filter_spec.rb
# spec/lib/gitlab/markdown/table_of_contents_filter_spec.rb
# spec/lib/gitlab/markdown/task_list_filter_spec.rb
# spec/lib/gitlab/markdown/upload_link_filter_spec.rb
# spec/lib/gitlab/markdown/user_reference_filter_spec.rb
2015-12-10 14:04:34 +01:00
Douwe Maan
6c94a44295
Merge branch 'master' into mr-builds
...
# Conflicts:
# app/controllers/projects/merge_requests_controller.rb
# app/views/projects/merge_requests/widget/_heading.html.haml
2015-12-08 22:26:29 +01:00
Robert Speicher
bcd89a58e7
Merge branch 'reference-pipeline-and-caching' into 'master'
...
Implement different Markdown rendering pipelines and cache Markdown
Builds on !1090 .
Related to !1014 .
Fixes #2054 .
See merge request !1602
2015-12-08 20:22:23 +00:00
Douwe Maan
a17ba43bfd
Move commit builds to partial
2015-12-08 13:10:33 +01:00
Douwe Maan
0dcff1342b
Merge branch 'master' into reference-pipeline-and-caching
2015-12-03 13:34:25 +01:00
Douwe Maan
7d3edf2520
Merge branch 'master' into ui/misc
2015-12-03 13:27:39 +01:00
Dmitriy Zaporozhets
ca7e31c48f
Merge branch 'ui/consistency' into 'master'
...
UI: Improve consistency across the board
Depends on !1953
See the commits for more details, the messages mostly speak for themselves.
Fixes https://dev.gitlab.org/gitlab/gitlabhq/issues/2577
See merge request !1954
2015-12-02 22:17:48 +00:00
Douwe Maan
8b7dd1c1ce
Add clipboard button to commit box SHA
2015-12-02 14:59:33 +01:00
Douwe Maan
e718bab9e1
"CI build passed", not "CI build success"
2015-12-02 14:59:25 +01:00
Douwe Maan
854deae412
Brefer "Directory" over "Dir", "Files" over "Code
2015-12-02 14:56:17 +01:00
Douwe Maan
1c595681e5
Remove double border between gray blocks
2015-12-02 14:49:29 +01:00
Douwe Maan
3ad1d320ef
Remove duplicated styling for center top menus
2015-12-02 14:49:12 +01:00
Douwe Maan
f5a630111f
Merge branch 'master' into reference-pipeline-and-caching
2015-11-19 15:46:04 +01:00
Douwe Maan
e49190cad9
Don't use params[:view] directly.
2015-11-17 16:33:38 +01:00
Jason Lee
18cb430f79
Replace CoffeeScript block into JavaScript in Views.
...
For example view: shared/issuable/_context
CoffeeScript: 190ms
JavaScript: 19.7ms
2015-11-10 19:17:37 +08:00
Kamil Trzcinski
2becd53015
Add missing stage to builds view
2015-11-05 15:24:27 +01:00
Kamil Trzcinski
ba68facf8d
CI details cleanup
...
- Add page titles to CI settings.
- Fix CI admin navigation.
- Remove duplicated scope.
- Use monospace font for commit sha.
- Add page title and header title to build page.
- Proper authorization for cancel/retry builds.
- Use gitlab pagination theme for builds and group members.
- Don't paginate builds widget on build page.
- Add badges to commit page Changes/Builds tabs.
- Add "Builds" to commit Builds tab page title.
- Add and use Ci::Build#retryable? method.
- Add CI::Build#retried? method.
- Allow all failed commit builds to be retried.
- Proper authorization for cancel/retry all builds.
- Remove unused param.
- Use time_ago_with_tooltip where appropriate.
- Tweak builds index text
- Remove duplication between builds/build and commit_statuses/commit_status.
- Use POST rather than GET for canceling and retrying builds.
- Remove redundant URL helpers.
- Add build ID to build page.
- Link branch name on build page.
- Move commit/:sha/ci to commit/:sha/builds.
2015-11-05 15:24:27 +01:00
Douwe Maan
de0acf3cf7
Merge branch 'master' into reference-pipeline-and-caching
2015-10-21 11:36:41 +02:00
Douwe Maan
a32f776609
Make tables full width.
2015-10-19 11:19:45 +02:00
Douwe Maan
539de0dd81
Merge branch 'master' into rs-redactor-filter
2015-10-14 20:23:36 +02:00
Douwe Maan
ed41333a6e
Use Gitlab::Markdown.render with :pipeline option rather than different methods
2015-10-14 19:28:09 +02:00
Kamil Trzcinski
33c9d6e45c
Fix retry and cancel for build
2015-10-14 12:56:52 +02:00
Kamil Trzcinski
4bf69b0bd9
Fix feature tests
2015-10-12 23:59:21 +02:00