Resolve "Scrolling horz on iOS for the secondary nav is broken"
## What does this MR do?
Moves absolutely positioned `div`s outside of the scrolling container because mobile safari causes those elements to jump around on scroll.
## Are there points in the code the reviewer needs to double check?
Check on a real iPhone (was only able to check in iOS simulator)
## Why was this MR needed?
Mobile Safari.
## What are the relevant issue numbers?
Closes#18438
## Screenshots (if relevant)
See merge request !4869
Restrict header logo to 36px so it doesn't overflow.
## What does this MR do?
Fixes the logo in the header.
## Are there points in the code the reviewer needs to double check?
I don't think so.
## Why was this MR needed?
Logos that weren't 36px by 36px were broken in 8.9.0
## What are the relevant issue numbers?
Fixes#18980
## Screenshots (if relevant)
Before:
After:
## Does this MR meet the acceptance criteria?
- [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
cc: @jschatz1 @dzaporozhets @rspeicher
See merge request !4861
Hide nav arrows by default
## What does this MR do?
- Fixes the arrow icon flashing on page load
- Removes settings dropdown at higher breakpoint
- Removes unneeded CSS
Closes#18941
## Screenshots (if relevant)
Arrow flashing bug:
Settings dropdown breaking nav:
<img src="/uploads/4351035f4cf8cb9fd892b621e6339e50/Screen_Shot_2016-06-21_at_4.25.50_PM.png" width="800px">
@alfredo1 would you mind double checking this to make sure the arrow flashing is definitely not happening?
See merge request !4843
Resolve "Graphs and Wiki subnav"
Styles sub nav in `Wiki` and `Graphs`
Closes#18533
cc @dzaporozhets
See merge request !4678
Update gray block under subnav to match other pages
## What does this MR do?
Makes Compare sub nav full width; replaces gray block with white one to match rest of pages
## What are the relevant issue numbers?
Closes#18934
## Screenshots (if relevant)
cc @dzaporozhets
See merge request !4838
Fixed issue with navbar counts being misaligned
## What does this MR do?
Fixes an issue in FireFox with the number counts being mis-aligned.
## What are the relevant issue numbers?
Closes#18916
## Screenshots (if relevant)
See merge request !4829
Fixed hover of date picker calendar
## What does this MR do?
Fixes the hover styling of days on the datepicker dropdown in the issuable sidebar.
## Screenshots (if relevant)
See merge request !4786
Updated blank state for environments and deployments
## What does this MR do?
Adds a designed blank state to environments and deployments.
@markpundsack do we want to hide the new environments when empty? Looks weird otherwise with the green button at the top.
## What are the relevant issue numbers?
Closes#18661
## Screenshots (if relevant)
See merge request !4818
Make lists on notes to look the same in preview mode and published
## What does this MR do?
Makes list styles on notes to be the same. Previously the styles weren't shared.
## Screenshots (if relevant)
**Previous**
**After**
See merge request !4765
Corrected top search area css media query param
## What does this MR do?
Corrects top search area css media query so it switches styles at the correct screen size.
## Are there points in the code the reviewer needs to double check?
It's a regression so likely
## Why was this MR needed?
UX
## What are the relevant issue numbers?
Closes#18490. (This stops the search bar dropping into its own row until it needs to be 100% column stacked anyway)
## Screenshots (if relevant)
## Does this MR meet the acceptance criteria?
- [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- [ ] Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
See merge request !4756
Refs dropdown is now loaded async
## What does this MR do?
The refs dropdown is loaded async so not to block the page.
## What are the relevant issue numbers?
Part of #18202
## Screenshots (if relevant)
See merge request !4508
Display Star and Fork on mobile, fix#18537.
## What does this MR do?
Displays the Star and Fork buttons on mobile devices.
## Are there points in the code the reviewer needs to double check?
Nope.
## Why was this MR needed?
I wanted to star and/or fork projects while on my phone, I couldn't do that before.
## What are the relevant issue numbers?
#18537
## Screenshots (if relevant)
cc: @jschatz1
See merge request !4714
Allow creating Personal Access Tokens through the website
Related to #2979
- Allow a user to create personal access tokens, and use them to authenticate
- Refactor `API::Helpers` into `API::Helpers::Core` and `API::Helpers::Authentication`
# Tasks
- [ ] #2979 (!3749) - Personal Access Tokens
- [x] Basic Implementation
- [x] Add UI to add "Personal Access Tokens"
- [x] Reload `lib/api` on every request
- [x] Respect these tokens for API requests
- [x] Just a param or a header too?
- [x] Allow revoking tokens
- [x] Expire tokens
- [x] Left bar should have a "PAT" icon
- [x] Scopes?
- [x] Copy to Clipboard
- [x] Show active/inactive tokens separately
- [x] No need to check for expired/revoked in the appropriate places
- [x] Why does regular ApplicationController check for private token?
- [x] Support non-API requests
- [x] Revert (or work on) `lib/api` eager loading
- [x] Create MR
- [x] Refactoring
- [x] Fix tests
- [x] Write more tests
- [x] Add screenshots to MR
- [x] Add description of query performance to MR
- [x] Limit the number of queries in the `personal_access_tokens` page
- [x] Wait for CI to pass
- [x] Fix merge issues in schema.rb
- [x] Assign MR to endboss
- [x] Wait for feedback
- [x] Fix feedback
- [x] Wait for CI to pass
- [x] Assign to @rspeicher
- [x] Fix @rspeicher's comments
- [x] Wait for CI to pass
- [x] Assign back to @rspeicher
- [x] Write documentation and ping @axil
- [x] Wait for Axil to respond
- [x] Assign to endboss
- [x] Address Douwe's feedback
- [x] Use the `private_token` or `authentication_token` param instead of `personal_access_token`
- [x] Ditto for the header
- [x] Assign to endboss
- [x] Make sure CI is green
- [x] Address Douwe's feedback
- [x] Don't go through the `authenticate_user_from_private_token!` method, if a private token is supplied (or combine them)
- [x] In `authenticate_user_from_personal_access_token!` don't hit DB if `token_string` is `nil`
- [x] Use `current_user.personal_access_tokens.build` in the controller
- [x] Remove the "We aren't using `personal_access_token` as the root param" comment
- [x] `No need for = "...", we can just have the Inactive ... #{...} on the next line` in the view
- [x] Render dates in a (more) human format
- [x] CSS issue with table
- [x] Don't show the tokens in the UI indefinitely
- [x] How to implement scopes? Add-on to current impl? Doorkeeper?
- [x] Wait for @DouweM's comments about scopes
- [x] Address @DouweM's second review
- [x] Try not using `native['innerHTML']`
- [x] use contexts for all "when ..."
- [x] Ensure consistency (styling) with other pages for "You don't have any tokens" message
- [x] "Actions" table column doesn't need a label
- [x] %td can be moved outside of the if/else statement
- [x] The header title should be "Profile Settings"
- [x] Can this be a `before_create`, so we don't need to use `generate`?
- [x] If it couldn't be revoked, will we show an error?
- [x] If it couldn't be saved, will we show an error?
- [x] Merge master
- [x] Update CHANGELOG entry
- [x] Add tests for form errors?
- [x] Post screenshots
- [x] Tag @jschatz1 for review
- [x] Wait for [build](https://gitlab.com/gitlab-org/gitlab-ce/commit/0dff6fd/builds) to pass
- [x] Respond to @jschatz1's comments
- [x] Hardcoded colors should be variables
- [x] Should not be allowed to chose a date in the past
- [x] Use the same table as in the Applications tab
- [x] button should say "Create Personal Access Token"
- [x] Float the revoke to the right on the `a`
- [x] Change revocation message. "Are you sure you want to revoke this certificate? This action cannot be undone."
- [x] Date stays selected and looks selected even though date is set as "never".
- [x] ~~hover on the calendar button shifts~~ (not caused by this MR - happens on `milestones#new` as well)
- [x] Don't use the panel for the created token
- [x] Use a normal flash for "Your new personal access token has been created"
- [x] Show the input (with the token) below it full width.
- [x] Put the "Make sure you save it - you won't be able to access it again." message near the input
- [x] Have the input highlight all on single click
- [x] Update screenshots
- [x] Merge master in + conflicts
- [x] Assign to @jschatz1 again
- [x] Respond to @jschatz1's comments
- [x] No button for clipboard, only link
- [x] text-danger
- [x] highlight fade on that area where the token was created
- [x] Make sure [build](https://gitlab.com/gitlab-org/gitlab-ce/commit/d754d99179f1ffe846fcc1d8e858163b39efc5dc/builds) is green
- [x] Assign to @jschatz1
- [x] Wait for [build](https://gitlab.com/gitlab-org/gitlab-ce/commit/faa0e3f7580bc38d4d12916b4589c64d6c2678a7/builds) to pass
- [x] Respond to @DouweM's feedback
- [x] move the redirect_to out of the if/else
- [x] certificate -> token
- [x] datepicker back to text field
- [x] combine the get_user_from_private_token and get_user_from_personal_access_token methods in ApplicationController
- [x] combine the get_user_from_private_token and get_user_from_personal_access_token methods in `lib/api/helpers`
- [x] don't need the new constants
- [x] Wait for [build](https://gitlab.com/gitlab-org/gitlab-ce/commit/9d7cda3ddce52baad9618466a5d00319b333be57/builds) to pass
- [ ] Wait for merge
# Screenshots
See merge request !3749
Fixed last push event banner not being in container
## What does this MR do?
Adds the last push event content into a container with the correct class.
## What are the relevant issue numbers?
Closes#18567
## Screenshots (if relevant)
See merge request !4644
Lighten each logo path color instead of white
## What does this MR do?
Changes highlight/loading colors of tanuki from white to a lighter version of each path color
## Why was this MR needed?
Since the logo is no longer on the dark sidebar, the highlight color was getting lost against the light gray background
## What are the relevant issue numbers?
Closes#18521
## Screenshots (if relevant)
cc @jschatz1 @lbennett @dzaporozhets
See merge request !4690
Pinned sidebar navigation option
## What does this MR do?
Gives the ability to pin the sidebar navigation. Pinning is only possible on screens with above `lg` which is `1200px` if not it reverts to being hidden by default.
## What are the relevant issue numbers?
Closes#18542
## Screenshots (if relevant)
### Un-pinned
### Pinned
See merge request !4683
Improve usability for prioritized labels
## What does this MR do?
- Adds an icon next to prioritized label rows serving as a hint to the user that the labels can be sorted by dragging them.
- Adds description about prioritized labels.
- Restores empty message when removing all prioritized labels.
## Screenshots (if relevant)
Closes#18575
See merge request !4652
added hover state to top nav links
## What does this MR do?
Adds hover state to top nav links.
## Are there points in the code the reviewer needs to double check?
Ney.
## Why was this MR needed?
UX.
## What are the relevant issue numbers?
Closes#18301.
## Screenshots (if relevant)
See merge request !4521
Aligned the two navs horizontally
## What does this MR do?
Previously the 2 top navs were not aligned horizontally together. The top nav would be slightly to the left due to the settings dropdown. This corrects that by putting `position: absolute` on the dropdown toggle.
## What are the relevant issue numbers?
Closes#18513
## Screenshots (if relevant)
See merge request !4616
Improve ui consistency. Part 2
* Use responsive top-area on project branches and tags pages
* Use default button size in the content list controls
* Improve button margin for btn-grouped css class
For https://gitlab.com/gitlab-org/gitlab-ce/issues/18324
See merge request !4536
Improved the UX of issue & milestone date picker
## What does this MR do?
Improves the UX of the date picker on issue form & milestone form.
## What are the relevant issue numbers?
Closes#18198
## Screenshots (if relevant)
### Issues
### Project milestones
### Group milestones
See merge request !4485
Fix local timeago on user dashboard
## What does this MR do?
Fixes incorrect date times on tooltips on the dashboard page
## Are there points in the code the reviewer needs to double check?
Yes, The tooltip has to be recreated again because we needed a custom CSS classname in order to fix the date being splitted into two lines.
## Why was this MR needed?
Because the datetimes were incorrect we have to have the same format for .timeago() instances.
## What are the relevant issue numbers?
#17607
## Screenshots (if relevant)
**Before**
<img src="/uploads/f40cd58e8086d9675262e98a1fe57885/Screen_Shot_2016-05-24_at_7.23.25_PM.png" width="705">
**After**
<img src="/uploads/bd48046ef11659cc742f827b3404fbcd/Screen_Shot_2016-05-24_at_7.22.29_PM.png" width="704">
See merge request !4285
Improve input padding, fix#18237.
## What does this MR do?
Improves horizontal padding for input fields.
## What are the relevant issue numbers?
#18237
## Screenshots (if relevant)
Before:
After:
cc: @jschatz1
See merge request !4489
#17562 Fixes issues list filter only visible when user is logged in
## What does this MR do?
1. Moves the issue/MR list search form out of the `if current_user` conditional, allowing guests to view the field.
2. Adds some margin to the search form, this is because in mobile view for guest users, the field was not supported by the RSS button and the New Issue button and would drop to meet the list.
## Are there points in the code the reviewer needs to double check?
Are there any views where the `margin-bottom: 12px` will affect the styling?
## Why was this MR needed?
Guest user UX. Nothing feels better than increasing intangible value!
## What are the relevant issue numbers?
Fixes#17562.
## Screenshots (if relevant)
/cc @jschatz1
**UPDATE:**
See merge request !4171
Side nav scrolls if content height taller than screen
## What does this MR do?
Header logo is now fixed at top; put back scrolling functionality in side nav
## Screenshots (if relevant)
<img src="/uploads/e1d1b60c296c39c61d7fe7da22b6c52d/scroll.gif" width="600px">
See merge request !4513
Add new icons in left sidebar and layout nav
Closes#17609Closes#17240Closes#17321
@skyruler I couldn't find the icons for `Projects`, `Merge Requests`, `Snippets`, or `Help` in the design repo. Do you have them available somewhere?
See merge request !4268
Fixed dropdown link line-height
## What does this MR do?
Fixes line-height issue on dropdown menu links
## Why was this MR needed?
The line-height of some dropdown links were taking the parent, most noticeable the commit header
## Screenshots (if relevant)
Before:
After:
See merge request !4531
Jacob SchatzandRobert Speicher
Dmitriy ZaporozhetsandRobert Speicher
Douwe MaanandRobert Speicher
Annabel Dunstone
Phil Hughes
Alfredo Sumaran