home/gitlabhq
2
0
Fork 0
mirror of https://github.com/wahyd4/gitlabhq.git synced 2026-08-10 21:26:07 +10:00
Code Issues Packages Projects Releases Wiki Activity
30,223 Commits 48 Branches 340 Tags
ac7cea308467709413f7a67b9e95fd0a0e2dcafe
Commit Graph
138 Commits
Author SHA1 Message Date
Robert SpeicherandRobert Speicher c6b9925335 Merge branch 'track-total-method-call-time' into 'master' 
Track method call times/counts as a single metric

This changes method call tracking so only a single metric is emitted regardless of the number of calls. This allows us to more accurately measure the total execution time of a method as well as the number of times a method is called. See 851e3ff7578973c2206628424eac3b951a3c656d for more details.

Method call tracking tracked calls individually meaning the end statistics may not always be accurate enough to get a good understanding of where time is spent.

See merge request !4754
 2016-06-17 14:23:05 -04:00
Yorick PeterseandRobert Speicher f4599c6f7a Merge branch 'fix_migration_style_guide' into 'master' 
Update migration_style_guide.md with new details

See merge request !4693
 2016-06-16 13:28:06 -04:00
Paco Guzman dadc531353 Instrument private/protected methods 
By default instrumentation will instrument public,
protected and private methods, because usually
heavy work is done on private method or at least
that’s what facts is showing
 2016-06-14 15:17:51 +02:00
Paco Guzman 120fbbd487 Measure CPU time for instrumented methods 2016-06-14 12:49:31 +02:00
Achilleas Pipinellis aa48eeef17 Merge branch 'doc-styleguide-move-locations' into 'master' 
Add guide on changing a document's location

## What does this MR do?

Add a documentation styleguide when changing a document's location.

## What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ce/issues/3349


See merge request !4624
 2016-06-13 13:26:43 +00:00
Achilleas Pipinellis cb7fa10cb5 Change to new Notes styleguide 
[ci skip]
 2016-06-13 15:04:22 +02:00
Achilleas Pipinellis d1abbb3b66 Add guide on changing a document's location 
[ci skip]
 2016-06-13 15:00:28 +02:00
Dmitriy Zaporozhets 366ad9ff72 Reject idea of using white/gray button depends on bg color 
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
 2016-06-08 17:11:43 +03:00
Connor Shea b2e85b7968 Add relevant commands to the licensing document, resolve some feedback. 2016-06-06 13:39:36 -06:00
Connor Shea 7045b9e908 Make sure to mention the GNU Project and OSI-provided information regarding the GPL so no one tries to disagree with that decision. 2016-06-06 13:39:36 -06:00
Connor Shea 3c32341215 Add Licensing information and guidelines to the Documentation. 2016-06-06 13:39:36 -06:00
Dmitriy Zaporozhets 814b26cfc3 Fix typo 
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
 2016-06-02 23:04:08 +03:00
Dmitriy Zaporozhets 33c499441a Add icons and buttons to UI guide 
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
 2016-06-02 22:43:02 +03:00
Chris Spicer 348d16f524 updtae -> update 2016-05-29 22:31:39 -07:00
Jacob Schatz 42e55585bb Merge branch 'dz-improve-ui-guide' into 'master' 
Write some thoughts to the UI guide

cc @skyruler 

See merge request !4290
 2016-05-25 19:55:14 +00:00
Jacob Schatz 16817cc49f Fix the english. 2016-05-25 14:57:15 -04:00
Dmitriy Zaporozhets f7da994cfd Write some thoughts to the UI guide 
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
 2016-05-25 20:44:02 +02:00
Robert Speicher 75739e54be Enable RSpec/NotToNot cop and auto-correct offenses 
Also removes the note from the development/testing.md guide
 2016-05-24 15:40:29 -04:00
Robert Speicher 883e2d2187 Merge branch 'migration-helpers' into 'master' 
Added helper methods for database migrations

These helpers can ultimately be used to write migrations that don't
require downtime.

See #15464 for more information.

See merge request !3860
 2016-05-19 16:49:14 +00:00
Achilleas Pipinellis 9eb4569ed9 Change all occurrences of doc.gitlab.com to docs.gitlab.com 
[ci skip]
 2016-05-13 16:26:56 -05:00
Yorick Peterse e8efaca23c Updated migration styleguide for new helpers 2016-05-12 13:03:55 +02:00
Rémy Coutable 898f613072 Merge branch 'document-adding-instrumentation' into 'master' 
Added documentation on how to instrument methods

This will hopefully remove me as a single point of failure when it comes to adding instrumentation.

cc @axil @rspeicher 

See merge request !4035
 2016-05-09 12:52:53 +00:00
Robert Speicher df9a7c6b4a Add a note to testing docs about the :each argument to RSpec hooks 
[ci skip]
 2016-05-05 17:22:18 -04:00
Yorick Peterse e449a6c05c Added documentation on how to instrument methods 
[ci skip]
 2016-05-05 19:26:41 +02:00
Yorick Peterse 70551217a6 Fixed username links in the performance guide 
These would end up being rendered as:

    <a href="...">@yorickpeterse</a>
    <a href="...">@yorickpeterse</a>

[ci skip]
 2016-05-04 13:17:43 +02:00
Achilleas Pipinellis 8bd793c9c5 Copyedit performance document 
[ci skip]
 2016-05-03 20:47:38 +03:00
Yorick Peterse b47a84b4be Added performance guidelines 
Fixes gitlab-org/gitlab-ce#15254 gitlab-org/gitlab-ce#14277

[ci skip]
 2016-04-30 02:10:25 +02:00
Yorick Peterse a54af831ba Use rake db:reset instead of db:setup 
Using db:reset ensures existing tables are first dropped. This in turn
ensures that we can drop tables regardless of any foreign key
constraints. While CE currently doesn't have any foreign keys EE defines
the following relation:

    remote_mirrors.project_id -> projects.id

MySQL will complain whenever you try to drop the "projects" table first
even when using "DROP TABLE ... CASCADE".
 2016-04-14 15:53:54 +02:00
Yorick Peterse 15cbbd09fb Merge branch 'metrics-measure-block-transaction' into 'master' 
Store block timings as transaction values

See merge request !3649
 2016-04-11 13:16:58 +00:00
Yorick Peterse d9110a7eca Track call counts in Gitlab::Metrics.measure_block 2016-04-11 13:27:52 +02:00
Yorick Peterse 16926a676b Store block timings as transaction values 
This makes it easier to query, simplifies the code, and makes it
possible to figure out what transaction the data belongs to (simply
because it's now stored _in_ the transaction).

This new setup keeps track of both the real/wall time _and_ CPU time
spent in a block, both measured using milliseconds (to keep all units
the same).
 2016-04-11 13:09:36 +02:00
Robert Speicher 0c6923e2d1 Re-add a note about sarcasm to the Code Review guide 
[ci skip]
 2016-04-10 22:54:44 -04:00
Robert Speicher c7ec5929b1 First pass at a Code Review guide 
Largely borrowed from thoughtbot's code review guide, so attribution is
included.

[ci skip]
 2016-04-09 21:49:47 -04:00
Robert Speicher cedcc1453c Minor Testing guide copyedits 
[ci skip]
 2016-04-09 01:19:21 -04:00
Dmitriy Zaporozhets 4a1fdc78a4 Merge branch 'remove-todo' into 'master' 
Remove TODO for not documented stuff

We should not put a `TODO` in a released product.

See merge request !3553
 2016-04-08 17:42:53 +00:00
Dmitriy Zaporozhets 0396c8525c Merge branch 'rs-testing-guide' into 'master' 
First pass at a Testing styleguide

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/14121

[ci skip]

See merge request !3465
 2016-04-08 17:34:55 +00:00
Yorick Peterse 352bc7d2b9 Added dev guide for measuring Ruby blocks 2016-04-06 14:32:27 +02:00
Robert Schilling 3911e77eb4 Remove TODO for not documented stuff 2016-04-05 23:08:22 +02:00
Robert Speicher 6ffda88c97 Add a link back to Development documentation to Testing guide 
[ci skip]
 2016-04-01 20:36:59 -04:00
Robert Speicher 2e83b56203 Add a section about let to the Testing guide 
[ci skip]
 2016-04-01 20:31:16 -04:00
Robert Speicher 60f4081e13 Factories don't have to be limited to ActiveRecord objects 
[ci skip]
 2016-04-01 20:31:12 -04:00
Robert Speicher 0b9d9816f8 Add a note about Four-Phase Test to Testing guide 
[ci skip]
 2016-04-01 20:31:12 -04:00
Robert Speicher fb8b0041d8 First pass at a Testing styleguide 
[ci skip]
 2016-04-01 20:31:12 -04:00
connorshea 2c9f6cfa42 SCSS Style Guide fixes. 
Fix a typo and add a section on ignoring issues.

[ci skip]
 2016-03-23 14:39:12 -06:00
connorshea 8d8b457ceb Add SCSS Lint, CSSComb config file, run SCSS Lint in GitLab CI, add documentation for SCSS Style Guide. 
See !3069 for more information.
 2016-03-14 20:33:54 -06:00
Yorick Peterse d69dff5b4b Removed benchmark suite and its documentation 
The rationale for this can be found in
https://gitlab.com/gitlab-org/gitlab-ce/issues/13718 but in short the
benchmark suite no longer serves a good purpose now that we have proper
production monitoring in place.

Fixes gitlab-org/gitlab-ce#13718
 2016-03-10 11:15:43 +01:00
Yorick Peterse 059df2256e Added basic SQL guidelines 
[ci skip]
 2016-03-08 11:28:50 +01:00
Achilleas Pipinellis bfeab78ab5 Change doc styleguide to use quotes for notes 
[ci skip]
 2016-02-29 15:00:40 +02:00
Douwe Maan 17251cf447 Merge branch 'rs-development-docs' into 'master' 
Add "Gotchas" to development docs

Also:

- Alphabetizes the "Developer" index page
- Fixes the broken `db_dump.md` link

See merge request !2846
 2016-02-29 11:00:33 +00:00
Achilleas Pipinellis 83ba37e544 Merge branch 'fix_git_tag_in_architecture' into 'master' 
Fixed ~git beeing displayed as link to issues tagged with git in architecture.md

The architecture documentation explains `~git` from the picture below which is replaced by a [link to issues tagged with `git`](https://gitlab.com/gitlab-org/gitlab-ce/issues?label_name=git). I believe that this was unintended and should be fixed by using backticks.

![Screenshot_from_2016-02-13_21-36-30](/uploads/5ea1a60e8b230952874e58eab0abe1ac/Screenshot_from_2016-02-13_21-36-30.png)

See merge request !2814
 2016-02-24 20:16:50 +00:00