Commit Graph
9 Commits
Author SHA1 Message Date
Jacob SchatzandRobert Speicher 4053a4046e Merge branch 'template_dropdown' into 'master'
Implements TemplateDropdown class to create custom template dropdowns

## What does this MR do?
Refactorize template dropdowns. This MR creates a base TemplateSelector class so it can be reused for multiple types of templates.

## Does this MR meet the acceptance criteria?

- [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- [ ] Tests
  - [ ] Added for this feature/bug
  - [x] All builds are passing
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

See merge request !4697
2016-06-16 13:34:02 -04:00
Sean McGivern ee26c3cab4 Fix label order by priority on labels page 2016-06-07 14:01:30 +01:00
Sean McGivernandAlfredo Sumaran 7bc65b2bef Clarify issue priority spec
We don't care particularly about the ordering within a priority level,
just that the levels are in the right order.
2016-06-06 11:59:49 -05:00
Alfredo Sumaran b0ec4b9cc3 Remove comment
Just to trigger CI
2016-06-06 11:59:49 -05:00
Alfredo Sumaran 2ca32a09b6 Add test for the case when user can't prioritize labels 2016-06-06 11:59:49 -05:00
Sean McGivernandAlfredo Sumaran 1cc0209a80 Fix style
- `reorder(nil)` is better than `reorder('')`
- Only use ASCII in comments
2016-06-06 11:59:49 -05:00
Alfredo Sumaran 6aea7666c3 Add tests for issues with multiple labels 2016-06-06 11:59:49 -05:00
Alfredo Sumaran 91e6bc1258 Add tests for issue prioritization 2016-06-06 11:59:49 -05:00
Alfredo Sumaran 0960cba090 Add tests for label prioritization 2016-06-06 11:59:49 -05:00