Stan Hu
a85dde9182
Fix Error 500 when using closes_issues API with an external issue tracker
...
Closes #18484
2016-06-11 19:50:08 -07:00
Rémy Coutable
5324c93643
Rename MergeRequest#cannot_be_merged_because_build_is_not_success? to #mergeable_ci_state?
...
The logic of the method was obviously inverted.
Signed-off-by: Rémy Coutable <remy@rymai.me >
2016-06-10 14:37:32 +02:00
Rémy Coutable
6dff7c1771
Improve initial implementation of the 'only_allow_merge_if_build_succeeds.rb' feature
...
Based on the feedback from reviewers.
Signed-off-by: Rémy Coutable <remy@rymai.me >
2016-06-10 14:36:57 +02:00
Rui Anderson and Rémy Coutable
07dbd6b388
Allow or not merge MR with failed build
...
Signed-off-by: Rémy Coutable <remy@rymai.me >
2016-06-10 14:36:54 +02:00
Kamil Trzcinski
842f0a3401
Merge branch 'rename-ci-commit' into rename-ci-commit-phase-2
...
# Conflicts:
# features/steps/shared/builds.rb
# spec/requests/ci/api/builds_spec.rb
2016-06-06 11:21:39 +02:00
Kamil Trzcinski
7ad7e10fee
Merge remote-tracking branch 'origin/master' into rename-ci-commit
2016-06-06 11:20:17 +02:00
Kamil Trzcinski
9614c52266
Fix tests offenses: use pipeline of Ci::Build and rename views
2016-06-06 11:19:54 +02:00
Kamil Trzcinski
20c7144ed2
Rename all [ci_]commit to [ci_]pipeline in specs and features
2016-06-03 16:22:26 +02:00
Kamil Trzcinski
8ce1896b46
Merge commit 'ca3c5c295ed653b483fe81c3918ffe60f46666b9' into rename-ci-commit
...
* commit 'ca3c5c295ed653b483fe81c3918ffe60f46666b9':
Let contributors know where to start
Ensure branch cleanup regardless of whether the import process succeeds
Fix failing todo tests
Reorder the todos because the use of the project finder attempts to order them differently
Update target todo test to use a public project
Use the project finder in the todos finder to limit todos to just ones within projects you have access to.
Move filtering todos by projects not pending deletion into a scope on the todo model
Reduce the filters on the todos joins project query by being explicit about the join
Ensure we don't show TODOS for projects pending delete
Fix deprecation warnings in spec/services/issues/bulk_update_service_spec.rb
Remove unused Issuable#is_assigned? method
fixup! Don't allow merges with new commits
fixup! Add `sha` parameter to MR accept API
Reduce Namespace queries in UserReferenceFilter
Added ReferenceFilter#nodes
Returning enums in ReferenceFilter#each_node
Don't allow merges with new commits
Add `sha` parameter to MR accept API
2016-06-03 15:53:26 +02:00
Z.J. van de Weg
9d491712cf
Merge branch 'master' into awardables
2016-06-03 15:20:11 +02:00
Kamil Trzcinski
021d3810c3
Rename Ci::Commit to Ci::Pipeline and rename some of the ci_commit to pipeline
2016-06-02 16:59:04 +02:00
Sean McGivern
d863d86aeb
Add sha parameter to MR accept API
...
The `sha` parameter is optional, and when present, must match the
current HEAD SHA of the source branch. Otherwise, the API call fails
with a 409 Conflict and a message containing the current HEAD for the
source branch.
Also tidy up some doc wording.
2016-06-01 20:29:54 +01:00
Zeger-Jan van de Weg
4558b5b9fe
Incorporate feedback
2016-05-11 22:43:58 +02:00
Rémy Coutable
f5240f9703
Expose MergeRequest#user_notes_count in the API and use the method in issues list
...
Signed-off-by: Rémy Coutable <remy@rymai.me >
2016-05-09 16:08:07 +02:00
Robert Schilling
a9200d93d3
Ensure that issues and merge requests are found
2016-04-13 17:15:42 +02:00
Robert Schilling
fa3009095f
Make subscription API more RESTful
2016-04-13 13:52:13 +02:00
Robert Schilling
f875189b39
API: Ability to subscribe and unsubscribe from a merge request
2016-04-13 13:45:01 +02:00
Abhi Rao
762d6ab4fd
Ensuring Merge Request API returns boolean values for work_in_progress
...
Fixes #14692
2016-03-28 22:11:44 -05:00
Zeger-Jan van de Weg
d28a587e82
Fix typos and denting
2016-03-21 19:30:45 +01:00
Zeger-Jan van de Weg
3b088fc5b5
Minor improvements on IssuableActions
2016-03-21 16:59:35 +01:00
Zeger-Jan van de Weg
1d77822816
minor improvements and fixed specs
2016-03-19 21:24:05 +01:00
Zeger-Jan van de Weg
212e83bab3
Soft delete issuables
2016-03-19 21:23:03 +01:00
Douwe Maan
0807bd5130
Merge branch 'skakirill/gitlab-ce-api-merge-request-setup-milestone' into 'master'
...
API: Allow to set or update a merge-request's milestone
_Originally opened at !2107 by @ skakirill._
- - -
See merge request !2755
2016-02-12 08:39:18 +00:00
Rémy Coutable
973a7d040e
Merge branch 'Schniz/gitlab-ce-feature/merge-request-closes-issues-in-api' into 'master'
...
Add merge_requests/:merge_request_id/closes_issues
_Originally opened at !2660 by @Schniz._
- - -
Added `/api/v3/projects/:id/merge_requests/:merge_request_id/closes_issues` route in the API for getting the issues that should be closed when a merge request merged successfully
See merge request !2779
2016-02-11 17:13:36 +00:00
Rémy Coutable
b91d1890a8
Pass current_user to merge_request.closes_issues in API ans streamline MR API specs
2016-02-11 09:34:07 +01:00
Gal Schlezinger and Rémy Coutable
78e36780be
Added '/api/v3/projects/:id/merge_requests/:merge_request_id/closes_issues' route in the API
...
Added some documentation for it
Added to changelog
Added curl example and an attribute table
Moved the api route definition from "lib/api/issues.rb" to "lib/api/merge_requests.rb"
Fixed the attributes and changed the documentation to be at "merge_requests.md" too
Changed generic titles to more specific titles
added an underscore
added tests. it depends on a newer version of gitlab-test project
I'm doing a since I need to add a branch to the `gitlab-test` repo
removed the before
using 'iid' instead of 'id' in the description to reference the issues. that makes the tests pass
Removed the 'closes-issues' key from test_env. so it should pass the tests
Moved the two initializations to the describe block
Changed the changelog
2016-02-11 09:34:07 +01:00
Rémy Coutable
2d59a0ff44
Add a spec for setting/updating a MR's milestone via the API
2016-02-09 10:06:26 +01:00
Rémy Coutable
f6a666bdc2
Add an API spec for MergeRequest#merge_status and properly document this resource
2016-02-08 17:18:44 +01:00
Dmitriy Zaporozhets
dfb8803c1c
Improve consistency and duplication for Merge Request API
...
* Follow REST for merge request API route
* Remove repeating comments API for MR
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2016-01-28 14:26:12 +01:00
Gabriel Mazetto
b5291f9599
Fixed Rubocop offenses
2015-12-15 00:53:52 -02:00
Zeger-Jan van de Weg
0e96d6eb10
Merge branch 'master' into merge-if-green
2015-12-07 10:06:07 +01:00
Zeger-Jan van de Weg
2462a96e45
Incorporate feedback
2015-12-05 15:42:38 +01:00
Dmitriy Zaporozhets
0b68a0e79e
Add API endpoint to fetch merge request commits list
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-12-04 11:08:10 +01:00
Zeger-Jan van de Weg
a7682f8775
Specs for 'Merge When Build Succeeds'
2015-12-02 13:27:16 +01:00
Stan Hu
2df573dac3
Fix bug where merge request comments created by API would not trigger notifications
...
Closes https://github.com/gitlabhq/gitlabhq/issues/9715
2015-10-10 10:59:02 -07:00
Stan Hu
1c289ac0c3
Fix broken sort in merge request API
...
Closes #2266
2015-09-15 22:55:22 -07:00
Dmitriy Zaporozhets
3e259ea8bc
Revert "Merge branch 'revert-satellites' into 'master'
"
...
This reverts commit 5daf44b7c8 , reversing
changes made to 2f706fbd23 .
2015-08-11 14:33:31 +02:00
Dmitriy Zaporozhets
9f10943c1a
Revert "Merge branch 'drop-satellites'"
...
This reverts commit 957e849f41 , reversing
changes made to 6b9dbe9f5a .
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-08-11 10:28:42 +02:00
Dmitriy Zaporozhets
b48b07044b
Merge branch 'master' into drop-satellites
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-08-04 16:42:36 +02:00
Dmitriy Zaporozhets
c17f5d06aa
Fix merge api and spec
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-08-04 16:33:53 +02:00
Stan Hu
6c9f527b3f
Return comments in created order in merge request API
...
Closes #1832
2015-07-16 22:33:58 -07:00
Dmitriy Zaporozhets
f40b99d02e
Merge branch 'master' into rubocop-for-tests
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
Conflicts:
spec/features/issues_spec.rb
spec/models/forked_project_link_spec.rb
spec/models/hooks/service_hook_spec.rb
spec/models/hooks/web_hook_spec.rb
spec/models/project_services/hipchat_service_spec.rb
spec/requests/api/project_members_spec.rb
spec/requests/api/projects_spec.rb
spec/requests/api/system_hooks_spec.rb
spec/services/archive_repository_service_spec.rb
spec/support/matchers.rb
spec/tasks/gitlab/backup_rake_spec.rb
2015-06-23 10:44:03 +02:00
Robert Speicher
15a05be70d
Fix Style/Blocks cop violations
2015-06-22 16:00:54 -04:00
Dmitriy Zaporozhets
cc9b5c49d1
Merge branch 'revert-mr-state-names'
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
Conflicts:
features/steps/project/merge_requests.rb
2015-06-22 15:43:09 +02:00
Dmitriy Zaporozhets
967214b2ec
Merge requests API returns closed for closed and merged for merged.
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com >
2015-06-22 15:11:53 +02:00
Robert Speicher and Dmitriy Zaporozhets
5a9ede4721
Update mock and stub syntax for specs
2015-06-22 12:13:46 +02:00
Robert Speicher
422236c71e
Change foo.should syntax to expect(foo).to in specs
2015-06-13 18:37:30 -04:00
Stan Hu
85145d1d77
Disable changing of the source branch in merge request update API
2015-05-29 09:40:35 -07:00
jubianchi
2c544d43c8
Query issues, merge requests and milestones with their IID through API
2015-05-02 10:44:52 +02:00
Douwe Maan
7e0eb486ed
Don't allow a merge request to be merged when its title starts with "WIP".
2015-04-30 15:46:36 +02:00