Rémy Coutable
d4d34b161b
Merge branch 'rs-backport-ee-372' into 'master'
...
Backport changes from gitlab-org/gitlab-ee!372
Mostly replaces several Spinach tests with RSpec Feature tests.
See merge request !4043
2016-05-09 14:48:48 +00:00
Takuya Noguchi
4ab49fab94
Use outer join for issues ordering by milestones due.
2016-05-06 19:57:26 +09:00
Robert Speicher
f18ec70743
Backport changes from gitlab-org/gitlab-ee!372
...
Mostly replaces several Spinach tests with RSpec Feature tests.
2016-05-04 17:05:16 -04:00
Douwe Maan
622ad2355a
Merge branch 'rs-unique-signup-fields' into 'master'
...
Improve uniqueness of field names on the signup form
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/15075
See merge request !3826
2016-05-04 13:33:15 +00:00
Rémy Coutable
5f89c9642e
Fix a spec that was failing due to !3483
...
Spec were skipped in this MR so that tests started to fail in master
instead of in this MR!
Signed-off-by: Rémy Coutable <remy@rymai.me >
2016-05-04 12:17:12 +02:00
Robert Speicher
c9bc3d20ef
Merge remote-tracking branch 'dev/master' into 'master'
2016-05-02 19:58:54 -04:00
Robert Speicher
0652d92526
Merge branch '15527-fix-wiki-page-creation-issue' into 'master'
...
Fix error when trying to create a wiki page
Closes #15527 , #15569 , #15623 , #15630 , #15637 , #15653 , #15870 , #16558 , #16875 , #16987 , #17016 , https://github.com/gitlabhq/gitlabhq/issues/10317 .
See merge request !3924
2016-05-02 17:18:22 +00:00
Rémy Coutable
f1e74de47c
Simplify specs by not over-expecting
...
Signed-off-by: Rémy Coutable <remy@rymai.me >
2016-05-02 18:34:14 +02:00
Phil Hughes and Jacob Schatz
b2ec176539
Removes duplicates from the label dropdown
...
It concats the duplicate labels into a single label in the dropdown with
the color being a gradient of the differnet colors being concatted.
Closes #16555
2016-04-29 12:10:30 -04:00
Rémy Coutable and Stan Hu
3811eb0ba1
Fix error when trying to create a wiki page
...
Closes #15527 .
Signed-off-by: Rémy Coutable <remy@rymai.me >
2016-04-29 06:50:18 -07:00
Arinde Eniola
ded3b02f33
Use a better message when milestone is newly created
...
make some changes for the checks to determine when the messages should be displayed
add item to changelog and also integration test
make some changes to the test
make some changes
2016-04-29 10:15:49 +01:00
Yorick Peterse and Jacob Schatz
0426647069
Load the "New Branch" button asynchronously
...
This button depends on Issue#can_be_worked_on? which in turn depends on
Issue#related_branches. By rendering this button asynchronously we can
finally remove all usages of Issue#related_branches and
Issue#referenced_merge_requests from the issues "show" page.
2016-04-28 16:13:48 -04:00
Alfredo Sumaran
d2f898e7ea
Fix Todos test
2016-04-27 14:52:51 -05:00
Jacob Schatz
90c966500a
Merge branch 'project-dropdown-tests' into 'master'
...
Project title dropdown tests
Added a test for when on an issue page to check whether the project
dropdown links will still work
See !3870
See merge request !3921
2016-04-27 17:28:48 +00:00
Alfredo Sumaran
5ba79f49a4
Syntax and code improvements
2016-04-26 14:01:40 -05:00
Alfredo Sumaran
7f263ca1de
Use variables instead of let
2016-04-26 14:01:40 -05:00
Alfredo Sumaran
0392dffdb6
Update wording
2016-04-26 14:01:40 -05:00
Alfredo Sumaran
89df29e09f
Use click_link
2016-04-26 14:01:40 -05:00
Alfredo Sumaran
5d5df26ab1
Add documentation for "Hide whitespace changes" button
2016-04-26 14:01:40 -05:00
Alfredo Sumaran
a1a9a1cf8d
Specs for toggle Whitespaces Changes
2016-04-26 14:01:40 -05:00
Marin Jankovski
2f5394f5d6
Merge branch 'master' of dev.gitlab.org:gitlab/gitlabhq
2016-04-26 11:08:56 +02:00
Phil Hughes
3e40b88547
Project title dropdown tests
...
Added a test for when on an issue page to check whether the project
dropdown links will still work
See !3870
2016-04-26 09:35:58 +01:00
Rémy Coutable and Robert Speicher
cd0750e045
Prevent private project name and namespace from leaking in the new MR view
...
Fixes #15591 .
Signed-off-by: Rémy Coutable <remy@rymai.me >
2016-04-25 15:32:44 -04:00
Jacob Schatz
d809507e05
Merge branch 'issue_14904' into 'master'
...
Add new shortcuts
Closes #14904
- On a project: `i` To navigate to New Issue page.
- On a issuable: `l` To open Label dropdown on a issuable.
- Global: Typing `?` multiple times now toggles the modal.
See merge request !3686
2016-04-25 19:13:25 +00:00
Grzegorz Bizon
ef032bb9f1
Fix error on commit builds page when no builds yet
...
Closes #15509
2016-04-25 17:19:57 +02:00
Robert Speicher
d83d43c553
Merge branch 'rs-todos-feature-spec' into 'master'
...
Refactor Todos feature spec to be faster and less brittle
We now only create two Todos instead of 21 when testing pagination, and
we've updated the test to be less brittle when dealing with slower CI
environments.
See merge request !3889
2016-04-22 17:51:08 +00:00
Robert Speicher
84d3649d57
Merge branch '15513-fix-undefined-can-method' into 'master'
...
Use the `can?` helper instead of `current_user.can?`
Fixes #15513 .
See merge request !3882
2016-04-22 17:38:10 +00:00
Robert Speicher
bdd844f312
Refactor Todos feature spec to be faster and less brittle
...
We now only create two Todos instead of 21 when testing pagination, and
we've updated the test to be less brittle when dealing with slower CI
environments.
2016-04-22 13:08:11 -04:00
Robert Speicher
10aaea1c91
Merge branch 'fix/cherry-pick-specs-location' into 'master'
...
Move cherry-pick feature specs to proper directory
Cherry pick feature specs were located in `spec/feature/project` directory while we have `spec/feature/projects`.
Later location is consistent with our namespaces (we have `Projects::` namespace, not `Project::`).
See merge request !3875
2016-04-22 15:33:23 +00:00
Rémy Coutable
c56ae831db
Merge branch 'issue_3799' into 'master'
...
Add tests for filtering owned projects
REF: #3799
See merge request !3873
2016-04-22 15:11:14 +00:00
Rémy Coutable
951e3459e1
Use the can? helper instead of current_user.can?
...
Fixes #15513 .
Signed-off-by: Rémy Coutable <remy@rymai.me >
2016-04-22 15:48:58 +02:00
Alfredo Sumaran
21a1e15677
Merge remote-tracking branch 'origin/master' into issue_3799
2016-04-22 08:37:15 -05:00
Phil Hughes
32be8bd2b1
Fixed issue with assignee object not being returned
...
Closes #15515
2016-04-22 13:30:58 +01:00
Grzegorz Bizon
b711fc0abd
Move cherry-pick feature specs to proper directory
2016-04-22 13:34:03 +02:00
Alfredo Sumaran
e0c07b5e3d
Add tests for filtering owned projects
2016-04-22 06:19:43 -05:00
Rémy Coutable
d5398e9656
Merge branch 'issue_3799' into 'master'
...
Allow filtering by Owned projects on dashboard page
Closes #3799

See merge request !3762
2016-04-22 08:40:01 +00:00
Phil Hughes and Robert Speicher
50ed43e490
Improved confirmation UX
...
Closes #4228
2016-04-21 20:20:09 -04:00
Yorick Peterse
a4510729a6
Merge branch '15465-fix-sort-by-due-date' into 'master'
...
Remove the `.distinct` when finding issues
See merge request !3858
2016-04-21 22:26:53 +00:00
Alfredo Sumaran
c9fe9f59d2
Merge remote-tracking branch 'origin/master' into issue_3799
2016-04-21 16:03:33 -05:00
Robert Speicher
1ea2408ba3
Merge branch 'dev_issue_15331' into 'master'
...
Fixes window.opener bug
Adds `noreferrer` value to rel attribute for external links
REF: https://gitlab.com/gitlab-org/gitlab-ce/issues/15331
See merge request !1953
2016-04-21 20:49:41 +00:00
Alfredo Sumaran
72debd840c
Fix failing spec
2016-04-21 14:38:44 -05:00
Alfredo Sumaran
6e9ce9a6cd
Add Rspec test for "i" shortcut
2016-04-21 14:24:36 -05:00
Jacob Schatz
6a27a80867
Merge branch 'label-dropdown-fix' into 'master'
...
Fixes "create label" functionality on label dropdown
**Issue sidebar**

**Issues page**

See merge request !3670
2016-04-21 17:32:24 +00:00
Rémy Coutable
5e37d02d0e
Remove the .distinct when finding issues
...
This is not needed anymore after !3815 .
Signed-off-by: Rémy Coutable <remy@rymai.me >
2016-04-21 18:49:08 +02:00
Douwe Maan
7ded28ff99
Merge branch 'fix/label-filters' into 'master'
...
Filter labels by including ALL filter titles
Fixed query to use `AND` and not `OR`. Refactored relevant specs
See merge request !3815
2016-04-21 13:13:10 +00:00
James Lopez
b09b175def
refactored specs based on feedback
2016-04-21 13:20:00 +02:00
Rémy Coutable
338f6f0902
Merge branch 'issue_5838' into 'master'
...
Show project members only for members
fixes #5838
See merge request !3752
2016-04-21 10:31:20 +00:00
James Lopez
2d2b73ae49
use wait_for_ajax instead of sleeping for 2 days!
2016-04-21 10:30:48 +02:00
James Lopez
6865bc16f8
refactored specs, adding more scenarios
2016-04-21 09:12:03 +02:00
Jacob Schatz
7dc16fe6ba
Merge branch 'issue_14678' into 'master'
...
Refresh page according remaining todos
Fixes #14678
See merge request !3428
2016-04-20 22:26:21 +00:00