Yorick Peterse and Jacob Schatz
0426647069
Load the "New Branch" button asynchronously
...
This button depends on Issue#can_be_worked_on? which in turn depends on
Issue#related_branches. By rendering this button asynchronously we can
finally remove all usages of Issue#related_branches and
Issue#referenced_merge_requests from the issues "show" page.
2016-04-28 16:13:48 -04:00
Jacob Schatz
6a27a80867
Merge branch 'label-dropdown-fix' into 'master'
...
Fixes "create label" functionality on label dropdown
**Issue sidebar**

**Issues page**

See merge request !3670
2016-04-21 17:32:24 +00:00
James Lopez
b09b175def
refactored specs based on feedback
2016-04-21 13:20:00 +02:00
James Lopez
2d2b73ae49
use wait_for_ajax instead of sleeping for 2 days!
2016-04-21 10:30:48 +02:00
James Lopez
6865bc16f8
refactored specs, adding more scenarios
2016-04-21 09:12:03 +02:00
Alfredo Sumaran
7e0ef892f4
Merge remote-tracking branch 'origin/master' into label-dropdown-fix
2016-04-20 17:10:10 -05:00
Jacob Schatz
692c35e6f4
Merge branch 'multi-filter-labels' into 'master'
...
Mutliple label filter
Fixes #989
See merge request !3438
2016-04-20 19:18:32 +00:00
Alfredo Sumaran
7b6fe0e259
Merge remote-tracking branch 'origin/master' into label-dropdown-fix
...
# Conflicts:
# app/views/shared/issuable/_sidebar.html.haml
2016-04-20 11:40:55 -05:00
Robert Speicher
17a730178d
Remove additional misuse of data-original-title attribute
2016-04-18 11:40:24 -04:00
Phil Hughes and Jacob Schatz
4b15a8ed26
Fixed up based on feedback
2016-04-16 16:13:16 -04:00
Phil Hughes and Jacob Schatz
ce2e37d446
Fixed tests
2016-04-16 16:13:16 -04:00
Alfredo Sumaran
6c29e1ef69
Add tests to check if a new label is added
2016-04-15 14:54:21 -05:00
Arinde Eniola
a0a423fee7
fix failing tests
2016-04-15 18:18:31 +01:00
Arinde Eniola
d0ad566972
rename the test file
2016-04-14 18:52:40 +01:00
Arinde Eniola
0c61f052de
add some tests for the new feature
2016-04-14 13:23:46 +01:00
Jacob Schatz
f026e53c4d
Merge branch 'label-filter' into 'master'
...
Fixed not being able to filter by any or no labels
Brings back the options to filter by any or no label
Closes #15008

See merge request !3589
2016-04-13 13:24:44 +00:00
Phil Hughes
a6ba94dbd1
Filtering by any label keeps the text on the toggle button
2016-04-12 09:32:12 +01:00
Arinde Eniola
91905ae3f5
write test to prevent reoccurence of issue
2016-04-09 23:31:45 +01:00
Phil Hughes
122b4148f7
Added label filter tests
2016-04-07 11:24:12 +01:00
Arinde Eniola
1e87679702
complete the tests
2016-04-06 03:42:27 +01:00
Arinde Eniola
55b2fae327
set up test for preventing this issue from reoccuring
2016-04-06 02:50:01 +01:00
Phil Hughes
6a3d8ac207
Spec updates
2016-03-29 18:20:10 +01:00
Phil Hughes
31fea92295
Updated based on Ruby feedback
2016-03-29 15:26:12 +01:00
Phil Hughes
c9dea7761d
Added tests for upcoming milestone filter
2016-03-29 11:57:04 +01:00
Alfredo Sumaran and Jacob Schatz
531331f79d
Fix specs
2016-03-25 08:10:25 -04:00
Rémy Coutable
2824972c36
Fix specs broken by !3270 and !3337 .
2016-03-24 10:10:46 +01:00
Phil Hughes
23bfa7a3bd
Update milestone spec
2016-03-23 11:45:24 +00:00
Phil Hughes
84f124a14f
Assignee tests
2016-03-23 11:19:32 +00:00
Phil Hughes
7e2806a123
Added tests for setting multiple status on issues
2016-03-23 11:19:32 +00:00
Grzegorz Bizon
0115ad66d2
Merge branch 'master' into feature/issue-move
...
* master: (121 commits)
Dedupe labels in labels selector in Dashboard pages
Refactor colors and lists
Add a safeguard in MergeRequest#compute_diverged_commits_count
Fix an issue when the target branch of a MR had been deleted
Add avatar to issue and MR pages header
Cleanup somce css colors
Re-group scss variables
Refactor `Todo#target`
Fixes issue with filter label missing on labels & milestones
Rename `Todo#to_reference` to `Todo#target_reference`
Fixed failing tests
Updated controller with before_action Fixed other issues based on feedback
Fixes issue on dashboard issues
Full labels data in JSON
Fixed issue with labels dropdown getting wrong labels
Update CHANGELOG
Use `Note#for_project_snippet?` to skip notes on project snippet
Use `Commit#short_id` instead of `Commit.truncate_sha`
Reuse `for_commit?` on conditional validations
Update schema info comment on todo related files
...
Conflicts:
app/models/issue.rb
db/schema.rb
spec/models/issue_spec.rb
2016-03-19 18:50:15 +01:00
Douglas Barbosa Alexandre
43d8bdb4f0
Restrict access to references for confidential issues
2016-03-17 20:55:59 -03:00
Grzegorz Bizon
fcf106897e
Do not use javascript in specs for issue move
...
Feature specs that were using javascript took a long time to finish
(about 10x longer) and where hitting Poltergeist timeouts.
This modification skips using javascript with select2 selecbox, thus it
is faster, but this also does not check some JavaScript related
features.
2016-03-17 12:25:17 +01:00
Zeger-Jan van de Weg
9337406671
Fix specs
...
Spinach was right, I was a fool..
2016-03-17 12:05:54 +01:00
Grzegorz Bizon
b9036ba610
Prevent issue move if issue has been already moved
2016-03-17 11:48:51 +01:00
Grzegorz Bizon
e3d32ff036
Add feature specs for issue move
2016-03-17 07:39:16 +01:00
Zeger-Jan van de Weg
4827458155
Incorporate the review and update spec
...
The feature spec now also tests the absence of the new branch button
2016-03-15 21:59:25 +01:00
Zeger-Jan van de Weg
2b97c92119
Incorporate review
2016-03-15 20:21:11 +01:00
Phil Hughes
ee9a6d7fb3
Fixed failing milestone filter tests
2016-03-10 13:54:54 +00:00
Phil Hughes
8d7e0f0ba9
Fixed failing tests
2016-03-10 13:54:54 +00:00
Robert Speicher
4fcaa7a474
Fix issue milestone filter spec
2016-02-26 18:14:49 -05:00
Douwe Maan
79c90821ac
Rename .issuable-details to .detail-page (and -header and -description)
2015-12-16 16:13:22 +01:00
Grzegorz Bizon and Grzegorz Bizon
8fe821cfa5
Trigger notes refresh in specs instead of waiting for ajax
2015-12-15 14:19:35 +01:00
Grzegorz Bizon and Grzegorz Bizon
3e789eab8b
Add minor fixes in note polling specs
2015-12-15 14:19:35 +01:00
Grzegorz Bizon and Grzegorz Bizon
7c14541d2b
Add feature specs for note polling
...
Ref. #4032 , !2084
2015-12-15 14:19:35 +01:00
Stan Hu and Robert Speicher
098ced4faa
Improve features to ensure Ajax filter has actually executed
2015-07-08 15:57:24 -04:00
Robert Speicher
098ad0a5b4
Remove "mystery guest" from Milestone filtering features
2015-07-08 15:49:37 -04:00
Robert Speicher
4b4351a18c
Add feature tag to feature specs
...
Not to be confused with the RSpec `type: :feature` tag, this tag is used
by the `spec:feature` Rake task for filtering/grouping specs.
2015-07-06 22:39:55 -04:00
Robert Speicher
d00cb00d6b
Rename NoMilestone to Milestone::None
...
Also refactors IssuableFinder to avoid redundant title check.
2015-07-06 22:39:55 -04:00
Robert Speicher
3ee3cb24d4
Allow user to filter by Issues/Merge Requests without a Milestone
2015-07-06 22:39:55 -04:00